0eead9ab41
akiphie points out that a.out core-dumps have that odd task struct dumping that was never used and was never really a good idea (it goes back into the mists of history, probably the original core-dumping code). Just remove it. Also do the access_ok() check on dump_write(). It probably doesn't matter (since normal filesystems all seem to do it anyway), but he points out that it's normally done by the VFS layer, so ... [ I suspect that we should possibly do "vfs_write()" instead of calling ->write directly. That also does the whole fsnotify and write statistics thing, which may or may not be a good idea. ] And just to be anal, do this all for the x86-64 32-bit a.out emulation code too, even though it's not enabled (and won't currently even compile) Reported-by: akiphie <akiphie@lavabit.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
46 lines
974 B
C
46 lines
974 B
C
#ifndef _LINUX_COREDUMP_H
|
|
#define _LINUX_COREDUMP_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/fs.h>
|
|
|
|
/*
|
|
* These are the only things you should do on a core-file: use only these
|
|
* functions to write out all the necessary info.
|
|
*/
|
|
static inline int dump_write(struct file *file, const void *addr, int nr)
|
|
{
|
|
return access_ok(VERIFY_READ, addr, nr) && file->f_op->write(file, addr, nr, &file->f_pos) == nr;
|
|
}
|
|
|
|
static inline int dump_seek(struct file *file, loff_t off)
|
|
{
|
|
int ret = 1;
|
|
|
|
if (file->f_op->llseek && file->f_op->llseek != no_llseek) {
|
|
if (file->f_op->llseek(file, off, SEEK_CUR) < 0)
|
|
return 0;
|
|
} else {
|
|
char *buf = (char *)get_zeroed_page(GFP_KERNEL);
|
|
|
|
if (!buf)
|
|
return 0;
|
|
while (off > 0) {
|
|
unsigned long n = off;
|
|
|
|
if (n > PAGE_SIZE)
|
|
n = PAGE_SIZE;
|
|
if (!dump_write(file, buf, n)) {
|
|
ret = 0;
|
|
break;
|
|
}
|
|
off -= n;
|
|
}
|
|
free_page((unsigned long)buf);
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
#endif /* _LINUX_COREDUMP_H */
|