1
0
Fork 0
alistair23-linux/drivers/net/ethernet/intel/i40e
Mitch Williams 1001dc3739 i40e: don't overload fields
Overloading the msg_size field in the arq_event_info struct is just a
bad idea. It leads to repeated bugs when the structure is used in a
loop, since the input value (buffer size) is overwritten by the output
value (actual message length).

Fix this by splitting the field into two and renaming to indicate the
actual function of each field.

Since the arq_event struct has now changed, we need to change the drivers
to support this. Note that we no longer need to initialize the buffer size
each time we go through a loop as this value is no longer destroyed by
arq processing.

In the process, we also fix a bug in i40evf_verify_api_ver where the
buffer size was not correctly reinitialized each time through the loop.

Change-ID: Ic7f9633cdd6f871f93e698dfb095e29c696f5581
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Acked-by: Shannon Nelson <shannon.nelson@intel.com>
Acked-by: Ashish Shah <ashish.n.shah@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2014-11-20 14:56:42 -08:00
..
Makefile i40e: adds FCoE to build and updates its documentation 2014-08-02 19:41:13 -07:00
i40e.h i40e: Modify Tx disable wait flow in case of DCB reconfiguration 2014-11-18 01:09:17 -08:00
i40e_adminq.c i40e: don't overload fields 2014-11-20 14:56:42 -08:00
i40e_adminq.h i40e: don't overload fields 2014-11-20 14:56:42 -08:00
i40e_adminq_cmd.h i40e: Add support to firmware CEE DCBX mode 2014-11-18 01:09:02 -08:00
i40e_alloc.h i40e: Fix GPL header 2014-01-09 02:10:23 -08:00
i40e_common.c i40e: Add support to firmware CEE DCBX mode 2014-11-18 01:09:02 -08:00
i40e_dcb.c i40e: Check for LLDP AdminStatus before querying DCBX 2014-11-18 01:09:06 -08:00
i40e_dcb.h i40e: Add support to firmware CEE DCBX mode 2014-11-18 01:09:02 -08:00
i40e_dcb_nl.c i40e: Add support to firmware CEE DCBX mode 2014-11-18 01:09:02 -08:00
i40e_debugfs.c i40e: Add support to firmware CEE DCBX mode 2014-11-18 01:09:02 -08:00
i40e_diag.c i40e: Rework register diagnostic 2014-06-05 01:27:46 -07:00
i40e_diag.h i40e: Fix GPL header 2014-01-09 02:10:23 -08:00
i40e_ethtool.c i40e: Prevent link flow control settings when PFC is enabled 2014-11-18 01:09:27 -08:00
i40e_fcoe.c i40e: Add support to firmware CEE DCBX mode 2014-11-18 01:09:02 -08:00
i40e_fcoe.h i40e: adds FCoE code to the i40e driver 2014-08-02 19:41:13 -07:00
i40e_hmc.c i40e/i40evf: Fix code to accommodate i40e_register.h changes 2014-06-08 02:01:23 -07:00
i40e_hmc.h i40e/i40evf: Force a shifted '1' to be unsigned 2014-07-02 19:02:19 -07:00
i40e_lan_hmc.c i40e: remove unnecessary break after goto 2014-07-13 23:45:24 -07:00
i40e_lan_hmc.h i40e/i40evf: Big endian fixes for handling HMC 2014-06-26 04:44:57 -07:00
i40e_main.c i40e: don't overload fields 2014-11-20 14:56:42 -08:00
i40e_nvm.c i40e: fix sparse non static symbol warning 2014-08-12 00:34:18 -07:00
i40e_osdep.h i40e: Adds FCoE related code to i40e core driver 2014-08-02 19:41:13 -07:00
i40e_prototype.h i40e: Check for LLDP AdminStatus before querying DCBX 2014-11-18 01:09:06 -08:00
i40e_ptp.c i40e: only warn once of PTP nonsupport in 100Mbit speed 2014-11-18 01:08:23 -08:00
i40e_register.h i40e/i40evf: i40e_register.h update 2014-06-19 20:22:02 -07:00
i40e_status.h i40e: Fix GPL header 2014-01-09 02:10:23 -08:00
i40e_txrx.c i40e: skb->xmit_more support 2014-10-08 16:03:32 -04:00
i40e_txrx.h i40e: clean up throttle rate code 2014-11-11 06:01:48 -08:00
i40e_type.h i40e: Check for LLDP AdminStatus before querying DCBX 2014-11-18 01:09:06 -08:00
i40e_virtchnl.h i40e/i40evf: Clean up a few things 2014-06-08 02:01:26 -07:00
i40e_virtchnl_pf.c i40e: re-enable VFLR interrupt sooner 2014-11-18 01:08:33 -08:00
i40e_virtchnl_pf.h i40e: Change wording to be more consistent 2014-09-04 01:38:29 -07:00