1
0
Fork 0
alistair23-linux/drivers/misc/sgi-xp
Arnd Bergmann 11d5ceb646 sgi-xp: open-code interruptible_sleep_on_timeout
interruptible_sleep_on_timeout is deprecated and going away soon.
The use in the sgi-xp driver leaves me puzzled, so I'd prefer not
to touch it. This patch replaces it with an open-coded prepare_to_wait
and finish_wait pair, which should be completely equivalent, so it
doesn't fix an existing race, but lets us get away with removing
the function so we can not get any new users.

In order to remove the typical sleep_on race, one would have to
replace the call with wait_event_interruptible_timeout and add
a condition to wait for. The fact that there is a one-jiffy timeout
suggests that we don't actually expect to get woken up properly
and the caller just uses this as a short sleeping function
if it doesn't wake up properly.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Cliff Whickman <cpw@sgi.com>
Acked-by: Robin Holt <robinmholt@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08 15:18:02 -08:00
..
Makefile sgi-xp: only build for ia64-sn2 when CONFIG_IA64_GENERIC specified 2008-10-30 11:38:46 -07:00
xp.h Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
xp_main.c x86: uv: xpc needs to provide an abstraction for uv_gpa 2009-12-16 07:20:13 -08:00
xp_nofault.S [IA64] run some drivers/misc/sgi-xp through scripts/Lindent 2008-04-22 15:08:29 -07:00
xp_sn2.c x86: uv: xpc needs to provide an abstraction for uv_gpa 2009-12-16 07:20:13 -08:00
xp_uv.c x86: uv: update XPC to handle updated BIOS interface 2009-12-16 07:20:14 -08:00
xpc.h sgi-xpc: clean up numerous globals 2009-04-13 15:04:33 -07:00
xpc_channel.c sgi-xp: open-code interruptible_sleep_on_timeout 2014-01-08 15:18:02 -08:00
xpc_main.c sgi: xpc: Convert use of typedef ctl_table to struct ctl_table 2013-06-14 10:19:25 +02:00
xpc_partition.c sgi-xpc: XPC fails to discover partitions with all nasids above 128 2010-11-25 06:50:40 +09:00
xpc_sn2.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
xpc_uv.c drivers/misc/sgi-xp/xpc_uv.c: SGI XPC fails to load when cpu 0 is out of IRQ resources 2012-08-21 16:45:03 -07:00
xpnet.c net: remove NETIF_F_NO_CSUM feature bit 2011-11-16 17:43:12 -05:00