f03574f2d5
This code was an optimization for 32-bit NUMA systems. It has probably been the cause of a number of subtle bugs over the years, although the conditions to excite them would have been hard to trigger. Essentially, we remap part of the kernel linear mapping area, and then sometimes part of that area gets freed back in to the bootmem allocator. If those pages get used by kernel data structures (say mem_map[] or a dentry), there's no big deal. But, if anyone ever tried to use the linear mapping for these pages _and_ cared about their physical address, bad things happen. For instance, say you passed __GFP_ZERO to the page allocator and then happened to get handed one of these pages, it zero the remapped page, but it would make a pte to the _old_ page. There are probably a hundred other ways that it could screw with things. We don't need to hang on to performance optimizations for these old boxes any more. All my 32-bit NUMA systems are long dead and buried, and I probably had access to more than most people. This code is causing real things to break today: https://lkml.org/lkml/2013/1/9/376 I looked in to actually fixing this, but it requires surgery to way too much brittle code, as well as stuff like per_cpu_ptr_to_phys(). [ hpa: Cc: this for -stable, since it is a memory corruption issue. However, an alternative is to simply mark NUMA as depends BROKEN rather than EXPERIMENTAL in the X86_32 subclause... ] Link: http://lkml.kernel.org/r/20130131005616.1C79F411@kernel.stglabs.ibm.com Signed-off-by: H. Peter Anvin <hpa@linux.intel.com> Cc: <stable@vger.kernel.org>
34 lines
726 B
C
34 lines
726 B
C
#ifndef __X86_MM_NUMA_INTERNAL_H
|
|
#define __X86_MM_NUMA_INTERNAL_H
|
|
|
|
#include <linux/types.h>
|
|
#include <asm/numa.h>
|
|
|
|
struct numa_memblk {
|
|
u64 start;
|
|
u64 end;
|
|
int nid;
|
|
};
|
|
|
|
struct numa_meminfo {
|
|
int nr_blks;
|
|
struct numa_memblk blk[NR_NODE_MEMBLKS];
|
|
};
|
|
|
|
void __init numa_remove_memblk_from(int idx, struct numa_meminfo *mi);
|
|
int __init numa_cleanup_meminfo(struct numa_meminfo *mi);
|
|
void __init numa_reset_distance(void);
|
|
|
|
void __init x86_numa_init(void);
|
|
|
|
#ifdef CONFIG_NUMA_EMU
|
|
void __init numa_emulation(struct numa_meminfo *numa_meminfo,
|
|
int numa_dist_cnt);
|
|
#else
|
|
static inline void numa_emulation(struct numa_meminfo *numa_meminfo,
|
|
int numa_dist_cnt)
|
|
{ }
|
|
#endif
|
|
|
|
#endif /* __X86_MM_NUMA_INTERNAL_H */
|