![Christoph Hellwig](/assets/img/avatar_default.png)
Currently we try to rely on the global reserved block pool for block allocations for the free inode btree, but I have customer reports (fairly complex workload, need to find an easier reproducer) where that is not enough as the AG where we free an inode that requires a new finobt block is entirely full. This causes us to cancel a dirty transaction and thus a file system shutdown. I think the right way to guard against this is to treat the finot the same way as the refcount btree and have a per-AG reservations for the possible worst case size of it, and the patch below implements that. Note that this could increase mount times with large finobt trees. In an ideal world we would have added a field for the number of finobt fields to the AGI, similar to what we did for the refcount blocks. We should do add it next time we rev the AGI or AGF format by adding new fields. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
79 lines
2.4 KiB
C
79 lines
2.4 KiB
C
/*
|
|
* Copyright (c) 2000,2005 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it would be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write the Free Software Foundation,
|
|
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
#ifndef __XFS_IALLOC_BTREE_H__
|
|
#define __XFS_IALLOC_BTREE_H__
|
|
|
|
/*
|
|
* Inode map on-disk structures
|
|
*/
|
|
|
|
struct xfs_buf;
|
|
struct xfs_btree_cur;
|
|
struct xfs_mount;
|
|
|
|
/*
|
|
* Btree block header size depends on a superblock flag.
|
|
*/
|
|
#define XFS_INOBT_BLOCK_LEN(mp) \
|
|
(xfs_sb_version_hascrc(&((mp)->m_sb)) ? \
|
|
XFS_BTREE_SBLOCK_CRC_LEN : XFS_BTREE_SBLOCK_LEN)
|
|
|
|
/*
|
|
* Record, key, and pointer address macros for btree blocks.
|
|
*
|
|
* (note that some of these may appear unused, but they are used in userspace)
|
|
*/
|
|
#define XFS_INOBT_REC_ADDR(mp, block, index) \
|
|
((xfs_inobt_rec_t *) \
|
|
((char *)(block) + \
|
|
XFS_INOBT_BLOCK_LEN(mp) + \
|
|
(((index) - 1) * sizeof(xfs_inobt_rec_t))))
|
|
|
|
#define XFS_INOBT_KEY_ADDR(mp, block, index) \
|
|
((xfs_inobt_key_t *) \
|
|
((char *)(block) + \
|
|
XFS_INOBT_BLOCK_LEN(mp) + \
|
|
((index) - 1) * sizeof(xfs_inobt_key_t)))
|
|
|
|
#define XFS_INOBT_PTR_ADDR(mp, block, index, maxrecs) \
|
|
((xfs_inobt_ptr_t *) \
|
|
((char *)(block) + \
|
|
XFS_INOBT_BLOCK_LEN(mp) + \
|
|
(maxrecs) * sizeof(xfs_inobt_key_t) + \
|
|
((index) - 1) * sizeof(xfs_inobt_ptr_t)))
|
|
|
|
extern struct xfs_btree_cur *xfs_inobt_init_cursor(struct xfs_mount *,
|
|
struct xfs_trans *, struct xfs_buf *, xfs_agnumber_t,
|
|
xfs_btnum_t);
|
|
extern int xfs_inobt_maxrecs(struct xfs_mount *, int, int);
|
|
|
|
/* ir_holemask to inode allocation bitmap conversion */
|
|
uint64_t xfs_inobt_irec_to_allocmask(struct xfs_inobt_rec_incore *);
|
|
|
|
#if defined(DEBUG) || defined(XFS_WARN)
|
|
int xfs_inobt_rec_check_count(struct xfs_mount *,
|
|
struct xfs_inobt_rec_incore *);
|
|
#else
|
|
#define xfs_inobt_rec_check_count(mp, rec) 0
|
|
#endif /* DEBUG */
|
|
|
|
int xfs_finobt_calc_reserves(struct xfs_mount *mp, xfs_agnumber_t agno,
|
|
xfs_extlen_t *ask, xfs_extlen_t *used);
|
|
|
|
#endif /* __XFS_IALLOC_BTREE_H__ */
|