Lukas Wunner a71b9dd7bf dmaengine: Fix access to uninitialized dma_slave_caps ... commit 53a256a9b9 upstream. dmaengine_desc_set_reuse() allocates a struct dma_slave_caps on the stack, populates it using dma_get_slave_caps() and then accesses one of its members. However dma_get_slave_caps() may fail and this isn't accounted for, leading to a legitimate warning of gcc-4.9 (but not newer versions): In file included from drivers/spi/spi-bcm2835.c:19:0: drivers/spi/spi-bcm2835.c: In function 'dmaengine_desc_set_reuse': >> include/linux/dmaengine.h:1370:10: warning: 'caps.descriptor_reuse' is used uninitialized in this function [-Wuninitialized] if (caps.descriptor_reuse) { Fix it, thereby also silencing the gcc-4.9 warning. The issue has been present for 4 years but surfaces only now that the first caller of dmaengine_desc_set_reuse() has been added in spi-bcm2835.c. Another user of reusable DMA descriptors has existed for a while in pxa_camera.c, but it sets the DMA_CTRL_REUSE flag directly instead of calling dmaengine_desc_set_reuse(). Nevertheless, tag this commit for stable in case there are out-of-tree users. Fixes: 272420214d ("dmaengine: Add DMA_CTRL_REUSE") Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Lukas Wunner <lukas@wunner.de> Cc: stable@vger.kernel.org # v4.3+ Link: https://lore.kernel.org/r/ca92998ccc054b4f2bfd60ef3adbab2913171eac.1575546234.git.lukas@wunner.de Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-01-09 10:19:58 +01:00
..
acpi	ACPI / utils: Move acpi_dev_get_first_match_dev() under CONFIG_ACPI	2019-12-17 19:56:29 +01:00
asm-generic	timekeeping/vsyscall: Update VDSO data unconditionally	2019-11-04 23:02:53 +01:00
clocksource	…
crypto	Merge branch 'next-integrity' of git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity	2019-09-27 19:37:27 -07:00
drm	drm: mst: Fix query_payload ack reply struct	2019-12-31 16:42:19 +01:00
dt-bindings	Main MIPS changes for v5.4:	2019-09-22 09:30:30 -07:00
keys	…
kvm	…
linux	dmaengine: Fix access to uninitialized dma_slave_caps	2020-01-09 10:19:58 +01:00
math-emu	…
media	…
misc	…
net	tcp/dccp: fix possible race __inet_lookup_established()	2020-01-04 19:19:13 +01:00
pcmcia	…
ras	…
rdma	RDMA/core: Fix ib_dma_max_seg_size()	2019-12-17 19:56:41 +01:00
scsi	scsi: target: iscsi: Wait for all commands to finish before freeing a session	2020-01-04 19:18:17 +01:00
soc	Char/Misc driver patches for 5.4-rc1	2019-09-18 11:14:31 -07:00
sound	ALSA: hda: Modify stream stripe mask only when needed	2019-12-13 08:42:39 +01:00
target	…
trace	block: Fix writeback throttling W=1 compiler warnings	2019-12-31 16:43:47 +01:00
uapi	media: cec-funcs.h: add status_req checks	2019-12-31 16:43:43 +01:00
vdso	…
video	…
xen	xen: fixes and cleanups for 5.4-rc2	2019-10-04 11:13:09 -07:00
Kbuild	- New Drivers	2019-09-23 19:37:49 -07:00