redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity
alistair23-linux/drivers/isdn/hisax
History
Nathan Chancellor a1930a9877 isdn: hfc_{pci,sx}: Avoid empty body if statements 
Clang warns:

drivers/isdn/hisax/hfc_pci.c:131:34: error: if statement has empty body
[-Werror,-Wempty-body]
        if (Read_hfc(cs, HFCPCI_INT_S1));
                                        ^
drivers/isdn/hisax/hfc_pci.c:131:34: note: put the semicolon on a
separate line to silence this warning

In my attempt to hide the warnings because I thought they didn't serve
any purpose[1], Masahiro Yamada pointed out that {Read,Write}_hfc in
hci_pci.c should be using a standard register access method; otherwise,
the compiler will just remove the if statements.

For hfc_pci, use the versions of {Read,Write}_hfc found in
drivers/isdn/hardware/mISDN/hfc_pCI.h while converting pci_io to be
'void __iomem *' (and clean up ioremap) then remove the empty if
statements.

For hfc_sx, {Read,Write}_hfc are already use a proper register accessor
(inb, outb) so just remove the unnecessary if statements.

[1]: https://lore.kernel.org/lkml/20181016021454.11953-1-natechancellor@gmail.com/

Link: https://github.com/ClangBuiltLinux/linux/issues/66
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-10-22 19:24:48 -07:00
..
amd7930_fn.c isdn/hisax: amd7930_fn: Remove unnecessary parentheses 2018-10-10 22:28:50 -07:00
amd7930_fn.h
arcofi.c isdn/hisax: Convert timers to use timer_setup() 2017-10-18 12:39:37 +01:00
arcofi.h
asuscom.c isdn: hisax: Fix pnp_irq's error checking for setup_asuscom 2017-11-16 22:31:15 +09:00
avm_a1.c
avm_a1p.c
avm_pci.c isdn: mark expected switch fall-throughs 2018-07-04 22:17:32 +09:00
avma1_cs.c drivers/isdn: use module_pcmcia_driver() in pcmcia drivers 2013-03-15 12:26:04 -07:00
bkm_a4t.c
bkm_a8.c
bkm_ax.h
callc.c isdn: hisax: callc: Replace GFP_ATOMIC with GFP_KERNEL in init_PStack() 2018-07-26 21:23:16 -07:00
config.c isdn: hisax: config: Replace GFP_ATOMIC with GFP_KERNEL 2018-07-26 21:23:47 -07:00
diva.c isdn: hisax: Fix pnp_irq's error checking for setup_diva_isapnp 2017-11-16 22:31:15 +09:00
elsa.c isdn: hisax: Fix pnp_irq's error checking for setup_elsa_isapnp 2017-11-16 22:31:15 +09:00
elsa_cs.c drivers/isdn: use module_pcmcia_driver() in pcmcia drivers 2013-03-15 12:26:04 -07:00
elsa_ser.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
enternow_pci.c
fsm.c treewide: kzalloc() -> kcalloc() 2018-06-12 16:19:22 -07:00
fsm.h
gazel.c isdn: mark expected switch fall-throughs 2018-07-04 22:17:32 +09:00
hfc4s8s_l1.c isdn/hisax: Convert timers to use timer_setup() 2017-10-18 12:39:37 +01:00
hfc4s8s_l1.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
hfc_2bds0.c treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00
hfc_2bds0.h
hfc_2bs0.c treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00
hfc_2bs0.h
hfc_pci.c isdn: hfc_{pci,sx}: Avoid empty body if statements 2018-10-22 19:24:48 -07:00
hfc_pci.h isdn: hfc_{pci,sx}: Avoid empty body if statements 2018-10-22 19:24:48 -07:00
hfc_sx.c isdn: hfc_{pci,sx}: Avoid empty body if statements 2018-10-22 19:24:48 -07:00
hfc_sx.h
hfc_usb.c isdn: hisax: hfc_usb: use usb_fill_int_urb() 2018-06-22 13:54:39 +09:00
hfc_usb.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
hfcscard.c isdn: hisax: Fix pnp_irq's error checking for setup_hfcs 2017-11-16 22:31:16 +09:00
hisax.h isdn: hfc_{pci,sx}: Avoid empty body if statements 2018-10-22 19:24:48 -07:00
hisax_cfg.h
hisax_debug.h
hisax_fcpcipnp.c isdn: hisax: Handle return value of pnp_irq and pnp_port_start 2017-11-16 22:31:16 +09:00
hisax_fcpcipnp.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
hisax_if.h
hisax_isac.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
hisax_isac.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
hscx.c
hscx.h
hscx_irq.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
icc.c isdn/hisax: Convert timers to use timer_setup() 2017-10-18 12:39:37 +01:00
icc.h
ipac.h
ipacx.c isdn/hisax: Convert timers to use timer_setup() 2017-10-18 12:39:37 +01:00
ipacx.h
isac.c isdn/hisax: Convert timers to use timer_setup() 2017-10-18 12:39:37 +01:00
isac.h
isar.c isdn: mark expected switch fall-throughs 2018-07-04 22:17:32 +09:00
isar.h
isdnl1.c isdn: fix misspelling of current function in string 2014-12-09 16:18:46 -05:00
isdnl1.h
isdnl2.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
isdnl2.h
isdnl3.c isdn/hisax: Convert timers to use timer_setup() 2017-10-18 12:39:37 +01:00
isdnl3.h
isurf.c isdn: hisax: Fix pnp_irq's error checking for setup_isurf 2017-11-16 22:31:16 +09:00
ix1_micro.c isdn: hisax: Fix pnp_irq's error checking for setup_ix1micro 2017-11-16 22:31:16 +09:00
jade.c isdn: clean up debug format string usage 2013-09-13 20:02:50 -04:00
jade.h
jade_irq.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
Kconfig treewide: simplify Kconfig dependencies for removed archs 2018-03-26 15:55:57 +02:00
l3_1tr6.c isdn: mark expected switch fall-throughs 2018-07-04 22:17:32 +09:00
l3_1tr6.h
l3dss1.c isdn: mark expected switch fall-throughs 2018-07-04 22:17:32 +09:00
l3dss1.h
l3ni1.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
l3ni1.h
lmgr.c
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mic.c
netjet.c treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00
netjet.h
niccy.c isdn: hisax: Fix pnp_irq's error checking for setup_niccy 2017-11-16 22:31:16 +09:00
nj_s.c
nj_u.c
q931.c treewide: Fix printk() message errors 2016-12-14 10:54:27 +01:00
s0box.c
saphir.c isdn/hisax: Convert timers to use timer_setup() 2017-10-18 12:39:37 +01:00
sedlbauer.c isdn: hisax: Fix pnp_irq's error checking for setup_sedlbauer_isapnp 2017-11-16 22:31:16 +09:00
sedlbauer_cs.c drivers/isdn: use module_pcmcia_driver() in pcmcia drivers 2013-03-15 12:26:04 -07:00
sportster.c
st5481.h
st5481_b.c scripts/spelling.txt: add "disble(d)" pattern and fix typo instances 2017-03-09 17:01:09 -08:00
st5481_d.c
st5481_init.c
st5481_usb.c isdn: hisax: st5481_usb: use usb_fill_int_urb() 2018-06-22 13:54:39 +09:00
tei.c
teleint.c isdn/hisax: Convert timers to use timer_setup() 2017-10-18 12:39:37 +01:00
teles0.c
teles3.c isdn: hisax: Fix pnp_irq's error checking for setup_teles3 2017-11-16 22:31:16 +09:00
teles_cs.c drivers/isdn: use module_pcmcia_driver() in pcmcia drivers 2013-03-15 12:26:04 -07:00
telespci.c isdn: Drop big endian cpp checks from telespci and hfc_pci drivers 2014-01-06 15:50:51 -05:00
w6692.c isdn/hisax: Fix fall-through annotation 2018-10-02 11:22:09 -07:00
w6692.h