Stefano Garzarella b11e9dd66e vringh: fix __vringh_iov() when riov and wiov are different ... commit 5745bcfbbf upstream. If riov and wiov are both defined and they point to different objects, only riov is initialized. If the wiov is not initialized by the caller, the function fails returning -EINVAL and printing "Readable desc 0x... after writable" error message. This issue happens when descriptors have both readable and writable buffers (eg. virtio-blk devices has virtio_blk_outhdr in the readable buffer and status as last byte of writable buffer) and we call __vringh_iov() to get both type of buffers in two different iovecs. Let's replace the 'else if' clause with 'if' to initialize both riov and wiov if they are not NULL. As checkpatch pointed out, we also avoid crashing the kernel when riov and wiov are both NULL, replacing BUG() with WARN_ON() and returning -EINVAL. Fixes: f87d0fbb57 ("vringh: host-side implementation of virtio rings.") Cc: stable@vger.kernel.org Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Link: https://lore.kernel.org/r/20201008204256.162292-1-sgarzare@redhat.com Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-11-05 11:43:35 +01:00
..
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Kconfig.vringh	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
net.c	vhost: Check docket sk_family instead of call getname	2020-03-05 16:43:44 +01:00
scsi.c	vhost/scsi: fix up req type endian-ness	2020-08-05 09:59:42 +02:00
test.c	vhost/test: stop device before reset	2019-10-13 09:38:27 -04:00
test.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
vhost.c	vhost: Use vhost_get_used_size() in vhost_vring_set_addr()	2020-10-14 10:32:58 +02:00
vhost.h	Revert "vhost: access vq metadata through kernel virtual address"	2019-09-04 07:39:48 -04:00
vringh.c	vringh: fix __vringh_iov() when riov and wiov are different	2020-11-05 11:43:35 +01:00
vsock.c	vsock/virtio: add transport parameter to the virtio_transport_reset_no_sock()	2020-10-07 08:01:24 +02:00