1317530302
Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference to the underlying tunnel device, but never released it when such device is deleted. Deleting the underlying device via the ip tool cause the kernel to hangup in the netdev_wait_allrefs() loop. This commit ensure that on device unregistration dp_detach_port_notify() is called for all vports that hold the device reference, properly releasing it. Fixes:614732eaa1("openvswitch: Use regular VXLAN net_device device") Fixes:b2acd1dc39("openvswitch: Use regular GRE net_device instead of vport") Fixes:6b001e682e("openvswitch: Use Geneve device.") Signed-off-by: Paolo Abeni <pabeni@redhat.com> Acked-by: Flavio Leitner <fbl@sysclose.org> Acked-by: Pravin B Shelar <pshelar@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net>
100 lines
2.6 KiB
C
100 lines
2.6 KiB
C
/*
|
|
* Copyright (c) 2007-2012 Nicira, Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of version 2 of the GNU General Public
|
|
* License as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
|
|
* 02110-1301, USA
|
|
*/
|
|
|
|
#include <linux/netdevice.h>
|
|
#include <net/genetlink.h>
|
|
#include <net/netns/generic.h>
|
|
|
|
#include "datapath.h"
|
|
#include "vport-internal_dev.h"
|
|
#include "vport-netdev.h"
|
|
|
|
static void dp_detach_port_notify(struct vport *vport)
|
|
{
|
|
struct sk_buff *notify;
|
|
struct datapath *dp;
|
|
|
|
dp = vport->dp;
|
|
notify = ovs_vport_cmd_build_info(vport, 0, 0,
|
|
OVS_VPORT_CMD_DEL);
|
|
ovs_dp_detach_port(vport);
|
|
if (IS_ERR(notify)) {
|
|
genl_set_err(&dp_vport_genl_family, ovs_dp_get_net(dp), 0,
|
|
0, PTR_ERR(notify));
|
|
return;
|
|
}
|
|
|
|
genlmsg_multicast_netns(&dp_vport_genl_family,
|
|
ovs_dp_get_net(dp), notify, 0,
|
|
0, GFP_KERNEL);
|
|
}
|
|
|
|
void ovs_dp_notify_wq(struct work_struct *work)
|
|
{
|
|
struct ovs_net *ovs_net = container_of(work, struct ovs_net, dp_notify_work);
|
|
struct datapath *dp;
|
|
|
|
ovs_lock();
|
|
list_for_each_entry(dp, &ovs_net->dps, list_node) {
|
|
int i;
|
|
|
|
for (i = 0; i < DP_VPORT_HASH_BUCKETS; i++) {
|
|
struct vport *vport;
|
|
struct hlist_node *n;
|
|
|
|
hlist_for_each_entry_safe(vport, n, &dp->ports[i], dp_hash_node) {
|
|
if (vport->ops->type == OVS_VPORT_TYPE_INTERNAL)
|
|
continue;
|
|
|
|
if (!(vport->dev->priv_flags & IFF_OVS_DATAPATH))
|
|
dp_detach_port_notify(vport);
|
|
}
|
|
}
|
|
}
|
|
ovs_unlock();
|
|
}
|
|
|
|
static int dp_device_event(struct notifier_block *unused, unsigned long event,
|
|
void *ptr)
|
|
{
|
|
struct ovs_net *ovs_net;
|
|
struct net_device *dev = netdev_notifier_info_to_dev(ptr);
|
|
struct vport *vport = NULL;
|
|
|
|
if (!ovs_is_internal_dev(dev))
|
|
vport = ovs_netdev_get_vport(dev);
|
|
|
|
if (!vport)
|
|
return NOTIFY_DONE;
|
|
|
|
if (event == NETDEV_UNREGISTER) {
|
|
/* upper_dev_unlink and decrement promisc immediately */
|
|
ovs_netdev_detach_dev(vport);
|
|
|
|
/* schedule vport destroy, dev_put and genl notification */
|
|
ovs_net = net_generic(dev_net(dev), ovs_net_id);
|
|
queue_work(system_wq, &ovs_net->dp_notify_work);
|
|
}
|
|
|
|
return NOTIFY_DONE;
|
|
}
|
|
|
|
struct notifier_block ovs_dp_device_notifier = {
|
|
.notifier_call = dp_device_event
|
|
};
|