1
0
Fork 0
alistair23-linux/sound/usb/usx2y
Wenwen Wang cbb88db76a ALSA: usx2y: fix a double free bug
In usX2Y_In04_init(), a new urb is firstly created through usb_alloc_urb()
and saved to 'usX2Y->In04urb'. Then, a buffer is allocated through
kmalloc() and saved to 'usX2Y->In04Buf'. If the allocation of the buffer
fails, the error code ENOMEM is returned after usb_free_urb(), which frees
the created urb. However, the urb is actually freed at card->private_free
callback, i.e., snd_usX2Y_card_private_free(). So the free operation here
leads to a double free bug.

To fix the above issue, simply remove usb_free_urb().

Signed-off-by: Wenwen Wang <wang6495@umn.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2019-04-29 19:56:41 +02:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
us122l.c ALSA: usx2y: Change return type to vm_fault_t 2018-04-25 08:15:20 +02:00
us122l.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
usX2Yhwdep.c ALSA: Replace snd_malloc_pages() and snd_free_pages() with standard helpers, take#2 2019-03-27 17:15:01 +01:00
usX2Yhwdep.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
usb_stream.c ALSA: us122l: Use alloc_pages_exact() 2019-03-27 17:15:04 +01:00
usb_stream.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
usbus428ctldefs.h [ALSA] Remove xxx_t typedefs: USB-USX2Y 2006-01-03 12:19:56 +01:00
usbusx2y.c ALSA: usx2y: fix a double free bug 2019-04-29 19:56:41 +02:00
usbusx2y.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
usbusx2yaudio.c ALSA: usb: Drop superfluous PCM preallocation error checks 2019-02-06 10:29:42 +01:00
usx2y.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
usx2yhwdeppcm.c ALSA: Replace snd_malloc_pages() and snd_free_pages() with standard helpers, take#2 2019-03-27 17:15:01 +01:00
usx2yhwdeppcm.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00