![Frank Rowand](/assets/img/avatar_default.png)
Add test case of two fragments updating the same property. After adding the test case, the system hangs at end of boot, after after slub stack dumps from kfree() in crypto modprobe code. Multiple overlay fragments adding, modifying, or deleting the same property is not supported. Add check to detect the attempt and fail the overlay apply. Before this patch, the first fragment error would terminate processing. Allow fragment checking to proceed and report all of the fragment errors before terminating the overlay apply. This is not a hot path, thus not a performance issue (the error is not transient and requires fixing the overlay before attempting to apply it again). After applying this patch, the devicetree unittest messages will include: OF: overlay: ERROR: multiple fragments add, update, and/or delete property /testcase-data-2/substation@100/motor-1/rpm_avail ... ### dt-test ### end of unittest - 212 passed, 0 failed The check to detect two fragments updating the same property is folded into the patch that created the test case to maintain bisectability. Tested-by: Alan Tull <atull@kernel.org> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
25 lines
456 B
Plaintext
25 lines
456 B
Plaintext
// SPDX-License-Identifier: GPL-2.0
|
|
/dts-v1/;
|
|
/plugin/;
|
|
|
|
/*
|
|
* &electric_1/motor-1 and &spin_ctrl_1 are the same node:
|
|
* /testcase-data-2/substation@100/motor-1
|
|
*
|
|
* Thus the property "rpm_avail" in each fragment will
|
|
* result in an attempt to update the same property twice.
|
|
* This will result in an error and the overlay apply
|
|
* will fail.
|
|
*/
|
|
|
|
&electric_1 {
|
|
|
|
motor-1 {
|
|
rpm_avail = < 100 >;
|
|
};
|
|
};
|
|
|
|
&spin_ctrl_1 {
|
|
rpm_avail = < 100 200 >;
|
|
};
|