1
0
Fork 0
alistair23-linux/sound/firewire/oxfw
Julia Lawall 5116ffc32d ALSA: firewire: constify snd_pcm_ops structures
Check for snd_pcm_ops structures that are only stored in the ops field of a
snd_soc_platform_driver structure or passed as the third argument to
snd_pcm_set_ops.  The corresponding field or parameter is declared const,
so snd_pcm_ops structures that have this property can be declared as const
also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct snd_pcm_ops i@p = { ... };

@ok1@
identifier r.i;
struct snd_soc_platform_driver e;
position p;
@@
e.ops = &i@p;

@ok2@
identifier r.i;
expression e1, e2;
position p;
@@
snd_pcm_set_ops(e1, e2, &i@p)

@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
struct snd_pcm_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct snd_pcm_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2016-09-02 11:50:11 +02:00
..
Makefile ALSA: oxfw: add scs1x layer 2015-12-22 11:51:27 +01:00
oxfw-command.c ALSA: oxfw: Add support for AV/C stream format command to get/set supported stream formation 2014-12-10 10:47:09 +01:00
oxfw-hwdep.c ALSA: oxfw: Add hwdep interface 2014-12-10 10:50:00 +01:00
oxfw-midi.c ALSA: oxfw: calculating MIDI ports in stream discover 2015-10-19 12:00:47 +02:00
oxfw-pcm.c ALSA: firewire: constify snd_pcm_ops structures 2016-09-02 11:50:11 +02:00
oxfw-proc.c ALSA: oxfw: some signedness bugs 2014-12-15 10:03:21 +01:00
oxfw-scs1x.c ALSA: oxfw: discontinue MIDI substream for scs1x at transaction failure 2016-02-24 16:32:08 +01:00
oxfw-spkr.c ALSA: oxfw: move model-specific parameters from common structure 2015-12-22 11:50:31 +01:00
oxfw-stream.c ALSA: firewire-lib: enable the same feature as CIP_SKIP_INIT_DBC_CHECK flag 2016-05-10 17:04:01 +02:00
oxfw.c ALSA: oxfw: delayed registration of sound card 2016-03-31 15:36:19 +02:00
oxfw.h ALSA: oxfw: delayed registration of sound card 2016-03-31 15:36:19 +02:00