1
0
Fork 0
alistair23-linux/drivers/parport
FUJITA Tomonori dfa7c4d869 parport_pc: set properly the dma_mask for parport_pc device
parport_pc_probe_port() creates the own 'parport_pc' device if the
device argument is NULL. Then parport_pc_probe_port() doesn't
initialize the dma_mask and coherent_dma_mask of the device and calls
dma_alloc_coherent with it. dma_alloc_coherent fails because
dma_alloc_coherent() doesn't accept the uninitialized dma_mask:

http://lkml.org/lkml/2009/6/16/150

Long ago, X86_32 and X86_64 had the own dma_alloc_coherent
implementations; X86_32 accepted a device having dma_mask that is not
initialized however X86_64 didn't. When we merged them, we chose to
prohibit a device having dma_mask that is not initialized. I think
that it's good to require drivers to set up dma_mask (and
coherent_dma_mask) properly if the drivers want DMA.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Reported-by: Malcom Blaney <malcolm.blaney@maptek.com.au>
Tested-by: Malcom Blaney <malcolm.blaney@maptek.com.au>
Cc: stable@kernel.org
Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-06-22 11:29:00 -07:00
..
BUGS-parport
ChangeLog
Kconfig
Makefile
TODO-parport
daisy.c
ieee1284.c
ieee1284_ops.c
multiface.h
parport_amiga.c
parport_atari.c m68k: atari - Rename "mfp" to "st_mfp" 2009-02-22 09:23:02 -08:00
parport_ax88796.c
parport_cs.c parport: Use the PCI IRQ if offered 2009-04-07 08:44:06 -07:00
parport_gsc.c parport: remove driver_data direct access of struct device 2009-06-15 21:30:28 -07:00
parport_gsc.h
parport_ip32.c
parport_mfc3.c
parport_pc.c parport_pc: set properly the dma_mask for parport_pc device 2009-06-22 11:29:00 -07:00
parport_serial.c parport: Use the PCI IRQ if offered 2009-04-07 08:44:06 -07:00
parport_sunbpp.c
probe.c
procfs.c
share.c parport: quickfix the proc registration bug 2009-06-02 09:53:22 -07:00