1
0
Fork 0
alistair23-linux/drivers/media/pci
Mauro Carvalho Chehab 278ba83a3a [media] cimax2: Don't use dynamic static allocation
Dynamic static allocation is evil, as Kernel stack is too low, and
compilation complains about it on some archs:
        drivers/media/pci/cx23885/cimax2.c:149:1: warning: 'netup_write_i2c' uses dynamic stack allocation [enabled by default]
Instead, let's enforce a limit for the buffer. Considering that I2C
transfers are generally limited, and that devices used on USB has a
max data length of 64 bytes for the control URBs.
So, it seem safe to use 64 bytes as the hard limit for all those devices.
On most cases, the limit is a way lower than that, but this limit
is small enough to not affect the Kernel stack, and it is a no brain
limit, as using smaller ones would require to either carefully each
driver or to take a look on each datasheet.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
2013-11-08 09:45:42 -02:00
..
b2c2 [media] pci: flexcop: Remove redundant pci_set_drvdata 2013-10-17 05:56:55 -03:00
bt8xx [media] misc drivers: remove deprecated IRQF_DISABLED 2013-10-17 06:08:31 -03:00
cx18 [media] cx18: struct i2c_client is too big for stack 2013-11-07 15:04:00 -02:00
cx88 [media] misc drivers: remove deprecated IRQF_DISABLED 2013-10-17 06:08:31 -03:00
cx23885 [media] cimax2: Don't use dynamic static allocation 2013-11-08 09:45:42 -02:00
cx25821 [media] cx25821: fix sparse warnings 2013-10-17 06:16:46 -03:00
ddbridge [media] ddbridge: Remove casting the return value which is a void pointer 2013-10-31 04:54:12 -02:00
dm1105 [media] dm1105: remove unneeded not-null test 2013-10-31 04:53:40 -02:00
ivtv [media] ivtv: remove deprecated IRQF_DISABLED 2013-10-17 06:08:52 -03:00
mantis [media] pci: mantis: Remove redundant pci_set_drvdata 2013-10-17 06:01:32 -03:00
meye [media] misc drivers: remove deprecated IRQF_DISABLED 2013-10-17 06:08:31 -03:00
ngene [media] ngene: Remove casting the return value which is a void pointer 2013-10-31 04:53:59 -02:00
pluto2 [media] pci: pluto2: Remove redundant pci_set_drvdata 2013-10-17 06:01:50 -03:00
pt1 [media] pci: pt1: Remove redundant pci_set_drvdata 2013-10-17 06:01:59 -03:00
saa7134 [media] misc drivers: remove deprecated IRQF_DISABLED 2013-10-17 06:08:31 -03:00
saa7146 [media] mxb: check register address when reading/writing a register 2013-06-17 08:53:48 -03:00
saa7164 [media] misc drivers: remove deprecated IRQF_DISABLED 2013-10-17 06:08:31 -03:00
sta2x11 [media] sta2x11_vip: fix error return code in sta2x11_vip_init_one() 2013-05-27 08:51:45 -03:00
ttpci [media] av7110_hw: Don't use dynamic static allocation 2013-11-08 09:45:41 -02:00
zoran [media] zoran: don't build it on alpha 2013-11-07 15:03:19 -02:00
Kconfig Properly handle tristate dependencies on USB/PCI menus 2013-06-17 11:40:28 -03:00
Makefile [media] Fix some Makefile rules 2012-08-16 19:55:03 -03:00