1
0
Fork 0
alistair23-linux/drivers/i2c
Daniel Ritz d6fcb3b9cf [PATCH] i2c-i801.c: don't pci_disable_device() after it was just enabled
Commit 02dd7ae289 ("[PATCH] i2c-i801:
Merge setup function") has a missing return 0 in the _probe() function.
This means the error path is always executed and pci_disable_device() is
called even when the device just got successfully enabled.

Having the SMBus device disabled makes some systems (eg.
Fujitsu-Siemens Lifebook E8010) hang hard during power-off.

Intead of reverting the whole commit this patch fixes it up:
- don't ever call pci_disable_device(), also not in the _remove() function
  to avoid hangs
- fix missing pci_release_region() in error path

Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-06-27 18:36:39 -07:00
..
algos [PATCH] i2c: Use module_param in i2c-algo-sibyte 2006-02-06 12:02:15 -08:00
busses [PATCH] i2c-i801.c: don't pci_disable_device() after it was just enabled 2006-06-27 18:36:39 -07:00
chips [PATCH] i2c: Suggest N for rare devices in Kconfig 2006-06-22 11:10:33 -07:00
Kconfig Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Makefile [PATCH] hwmon: hwmon vs i2c, second round (07/11) 2005-09-05 09:14:22 -07:00
i2c-core.c [PATCH] i2c: Mark block write buffers as const 2006-06-22 11:10:34 -07:00
i2c-dev.c [PATCH] I2C: I2C controllers go into right place on sysfs 2006-06-22 11:10:36 -07:00