1
0
Fork 0
alistair23-linux/drivers/staging/iio/trigger
Alison Schofield 10e840dfb0 iio: trigger: free trigger resource correctly
These stand-alone trigger drivers were using iio_trigger_put()
where they should have been using iio_trigger_free().  The
iio_trigger_put() adds a module_put which is bad since they
never did a module_get.

In the sysfs driver, module_get/put's are used as triggers are
added & removed. This extra module_put() occurs on an error path
in the probe routine (probably rare).

In the bfin-timer & interrupt trigger drivers, the module resources
are not explicitly managed, so it's doing a put on something that
was never get'd.  It occurs on the probe error path and on the
remove path (not so rare).

Tested with the sysfs trigger driver.
The bfin & interrupt drivers were build tested & inspected only.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2017-01-22 16:14:21 +00:00
..
Kconfig staging:iio: Remove periodic RTC trigger driver 2016-02-27 17:18:38 +00:00
Makefile staging:iio: Remove periodic RTC trigger driver 2016-02-27 17:18:38 +00:00
iio-trig-bfin-timer.c iio: trigger: free trigger resource correctly 2017-01-22 16:14:21 +00:00
iio-trig-bfin-timer.h staging:iio:trigger:bfintmr Add output support 2012-09-17 22:10:00 +01:00