![Daniel Vetter](/assets/img/avatar_default.png)
Having the probe helper stuff (which pretty much everyone needs) in the drm_crtc_helper.h file (which atomic drivers should never need) is confusing. Split them out. To make sure I actually achieved the goal here I went through all drivers. And indeed, all atomic drivers are now free of drm_crtc_helper.h includes. v2: Make it compile. There was so much compile fail on arm drivers that I figured I'll better not include any of the acks on v1. v3: Massive rebase because i915 has lost a lot of drmP.h includes, but not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h there was still one, which this patch largely removes. Which means rolling out lots more includes all over. This will also conflict with ongoing drmP.h cleanup by others I expect. v3: Rebase on top of atomic bochs. v4: Review from Laurent for bridge/rcar/omap/shmob/core bits: - (re)move some of the added includes, use the better include files in other places (all suggested from Laurent adopted unchanged). - sort alphabetically v5: Actually try to sort them, and while at it, sort all the ones I touch. v6: Rebase onto i915 changes. v7: Rebase once more. Acked-by: Harry Wentland <harry.wentland@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> Acked-by: Jani Nikula <jani.nikula@intel.com> Acked-by: Neil Armstrong <narmstrong@baylibre.com> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Acked-by: CK Hu <ck.hu@mediatek.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: linux-arm-kernel@lists.infradead.org Cc: virtualization@lists.linux-foundation.org Cc: etnaviv@lists.freedesktop.org Cc: linux-samsung-soc@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org Cc: linux-mediatek@lists.infradead.org Cc: linux-amlogic@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: spice-devel@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-tegra@vger.kernel.org Cc: xen-devel@lists.xen.org Link: https://patchwork.freedesktop.org/patch/msgid/20190117210334.13234-1-daniel.vetter@ffwll.ch
185 lines
4.4 KiB
C
185 lines
4.4 KiB
C
/* exynos_drm_fb.c
|
|
*
|
|
* Copyright (c) 2011 Samsung Electronics Co., Ltd.
|
|
* Authors:
|
|
* Inki Dae <inki.dae@samsung.com>
|
|
* Joonyoung Shim <jy0922.shim@samsung.com>
|
|
* Seung-Woo Kim <sw0312.kim@samsung.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_crtc.h>
|
|
#include <drm/drm_fb_helper.h>
|
|
#include <drm/drm_gem_framebuffer_helper.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
#include <uapi/drm/exynos_drm.h>
|
|
|
|
#include "exynos_drm_drv.h"
|
|
#include "exynos_drm_fb.h"
|
|
#include "exynos_drm_fbdev.h"
|
|
#include "exynos_drm_crtc.h"
|
|
|
|
static int check_fb_gem_memory_type(struct drm_device *drm_dev,
|
|
struct exynos_drm_gem *exynos_gem)
|
|
{
|
|
unsigned int flags;
|
|
|
|
/*
|
|
* if exynos drm driver supports iommu then framebuffer can use
|
|
* all the buffer types.
|
|
*/
|
|
if (is_drm_iommu_supported(drm_dev))
|
|
return 0;
|
|
|
|
flags = exynos_gem->flags;
|
|
|
|
/*
|
|
* Physically non-contiguous memory type for framebuffer is not
|
|
* supported without IOMMU.
|
|
*/
|
|
if (IS_NONCONTIG_BUFFER(flags)) {
|
|
DRM_ERROR("Non-contiguous GEM memory is not supported.\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct drm_framebuffer_funcs exynos_drm_fb_funcs = {
|
|
.destroy = drm_gem_fb_destroy,
|
|
.create_handle = drm_gem_fb_create_handle,
|
|
};
|
|
|
|
struct drm_framebuffer *
|
|
exynos_drm_framebuffer_init(struct drm_device *dev,
|
|
const struct drm_mode_fb_cmd2 *mode_cmd,
|
|
struct exynos_drm_gem **exynos_gem,
|
|
int count)
|
|
{
|
|
struct drm_framebuffer *fb;
|
|
int i;
|
|
int ret;
|
|
|
|
fb = kzalloc(sizeof(*fb), GFP_KERNEL);
|
|
if (!fb)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
for (i = 0; i < count; i++) {
|
|
ret = check_fb_gem_memory_type(dev, exynos_gem[i]);
|
|
if (ret < 0)
|
|
goto err;
|
|
|
|
fb->obj[i] = &exynos_gem[i]->base;
|
|
}
|
|
|
|
drm_helper_mode_fill_fb_struct(dev, fb, mode_cmd);
|
|
|
|
ret = drm_framebuffer_init(dev, fb, &exynos_drm_fb_funcs);
|
|
if (ret < 0) {
|
|
DRM_ERROR("failed to initialize framebuffer\n");
|
|
goto err;
|
|
}
|
|
|
|
return fb;
|
|
|
|
err:
|
|
kfree(fb);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
static struct drm_framebuffer *
|
|
exynos_user_fb_create(struct drm_device *dev, struct drm_file *file_priv,
|
|
const struct drm_mode_fb_cmd2 *mode_cmd)
|
|
{
|
|
const struct drm_format_info *info = drm_get_format_info(dev, mode_cmd);
|
|
struct exynos_drm_gem *exynos_gem[MAX_FB_BUFFER];
|
|
struct drm_framebuffer *fb;
|
|
int i;
|
|
int ret;
|
|
|
|
for (i = 0; i < info->num_planes; i++) {
|
|
unsigned int height = (i == 0) ? mode_cmd->height :
|
|
DIV_ROUND_UP(mode_cmd->height, info->vsub);
|
|
unsigned long size = height * mode_cmd->pitches[i] +
|
|
mode_cmd->offsets[i];
|
|
|
|
exynos_gem[i] = exynos_drm_gem_get(file_priv,
|
|
mode_cmd->handles[i]);
|
|
if (!exynos_gem[i]) {
|
|
DRM_ERROR("failed to lookup gem object\n");
|
|
ret = -ENOENT;
|
|
goto err;
|
|
}
|
|
|
|
if (size > exynos_gem[i]->size) {
|
|
i++;
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
fb = exynos_drm_framebuffer_init(dev, mode_cmd, exynos_gem, i);
|
|
if (IS_ERR(fb)) {
|
|
ret = PTR_ERR(fb);
|
|
goto err;
|
|
}
|
|
|
|
return fb;
|
|
|
|
err:
|
|
while (i--)
|
|
exynos_drm_gem_put(exynos_gem[i]);
|
|
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
dma_addr_t exynos_drm_fb_dma_addr(struct drm_framebuffer *fb, int index)
|
|
{
|
|
struct exynos_drm_gem *exynos_gem;
|
|
|
|
if (WARN_ON_ONCE(index >= MAX_FB_BUFFER))
|
|
return 0;
|
|
|
|
exynos_gem = to_exynos_gem(fb->obj[index]);
|
|
return exynos_gem->dma_addr + fb->offsets[index];
|
|
}
|
|
|
|
static struct drm_mode_config_helper_funcs exynos_drm_mode_config_helpers = {
|
|
.atomic_commit_tail = drm_atomic_helper_commit_tail_rpm,
|
|
};
|
|
|
|
static const struct drm_mode_config_funcs exynos_drm_mode_config_funcs = {
|
|
.fb_create = exynos_user_fb_create,
|
|
.output_poll_changed = drm_fb_helper_output_poll_changed,
|
|
.atomic_check = drm_atomic_helper_check,
|
|
.atomic_commit = drm_atomic_helper_commit,
|
|
};
|
|
|
|
void exynos_drm_mode_config_init(struct drm_device *dev)
|
|
{
|
|
dev->mode_config.min_width = 0;
|
|
dev->mode_config.min_height = 0;
|
|
|
|
/*
|
|
* set max width and height as default value(4096x4096).
|
|
* this value would be used to check framebuffer size limitation
|
|
* at drm_mode_addfb().
|
|
*/
|
|
dev->mode_config.max_width = 4096;
|
|
dev->mode_config.max_height = 4096;
|
|
|
|
dev->mode_config.funcs = &exynos_drm_mode_config_funcs;
|
|
dev->mode_config.helper_private = &exynos_drm_mode_config_helpers;
|
|
|
|
dev->mode_config.allow_fb_modifiers = true;
|
|
|
|
dev->mode_config.normalize_zpos = true;
|
|
}
|