![Daniel Vetter](/assets/img/avatar_default.png)
Having the probe helper stuff (which pretty much everyone needs) in the drm_crtc_helper.h file (which atomic drivers should never need) is confusing. Split them out. To make sure I actually achieved the goal here I went through all drivers. And indeed, all atomic drivers are now free of drm_crtc_helper.h includes. v2: Make it compile. There was so much compile fail on arm drivers that I figured I'll better not include any of the acks on v1. v3: Massive rebase because i915 has lost a lot of drmP.h includes, but not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h there was still one, which this patch largely removes. Which means rolling out lots more includes all over. This will also conflict with ongoing drmP.h cleanup by others I expect. v3: Rebase on top of atomic bochs. v4: Review from Laurent for bridge/rcar/omap/shmob/core bits: - (re)move some of the added includes, use the better include files in other places (all suggested from Laurent adopted unchanged). - sort alphabetically v5: Actually try to sort them, and while at it, sort all the ones I touch. v6: Rebase onto i915 changes. v7: Rebase once more. Acked-by: Harry Wentland <harry.wentland@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> Acked-by: Jani Nikula <jani.nikula@intel.com> Acked-by: Neil Armstrong <narmstrong@baylibre.com> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Acked-by: CK Hu <ck.hu@mediatek.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: linux-arm-kernel@lists.infradead.org Cc: virtualization@lists.linux-foundation.org Cc: etnaviv@lists.freedesktop.org Cc: linux-samsung-soc@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org Cc: linux-mediatek@lists.infradead.org Cc: linux-amlogic@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: spice-devel@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-tegra@vger.kernel.org Cc: xen-devel@lists.xen.org Link: https://patchwork.freedesktop.org/patch/msgid/20190117210334.13234-1-daniel.vetter@ffwll.ch
148 lines
3.4 KiB
C
148 lines
3.4 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* shmob_drm_kms.c -- SH Mobile DRM Mode Setting
|
|
*
|
|
* Copyright (C) 2012 Renesas Electronics Corporation
|
|
*
|
|
* Laurent Pinchart (laurent.pinchart@ideasonboard.com)
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_crtc.h>
|
|
#include <drm/drm_crtc_helper.h>
|
|
#include <drm/drm_fb_cma_helper.h>
|
|
#include <drm/drm_gem_cma_helper.h>
|
|
#include <drm/drm_gem_framebuffer_helper.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
|
|
#include "shmob_drm_crtc.h"
|
|
#include "shmob_drm_drv.h"
|
|
#include "shmob_drm_kms.h"
|
|
#include "shmob_drm_regs.h"
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
* Format helpers
|
|
*/
|
|
|
|
static const struct shmob_drm_format_info shmob_drm_format_infos[] = {
|
|
{
|
|
.fourcc = DRM_FORMAT_RGB565,
|
|
.bpp = 16,
|
|
.yuv = false,
|
|
.lddfr = LDDFR_PKF_RGB16,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_RGB888,
|
|
.bpp = 24,
|
|
.yuv = false,
|
|
.lddfr = LDDFR_PKF_RGB24,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_ARGB8888,
|
|
.bpp = 32,
|
|
.yuv = false,
|
|
.lddfr = LDDFR_PKF_ARGB32,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV12,
|
|
.bpp = 12,
|
|
.yuv = true,
|
|
.lddfr = LDDFR_CC | LDDFR_YF_420,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV21,
|
|
.bpp = 12,
|
|
.yuv = true,
|
|
.lddfr = LDDFR_CC | LDDFR_YF_420,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV16,
|
|
.bpp = 16,
|
|
.yuv = true,
|
|
.lddfr = LDDFR_CC | LDDFR_YF_422,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV61,
|
|
.bpp = 16,
|
|
.yuv = true,
|
|
.lddfr = LDDFR_CC | LDDFR_YF_422,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV24,
|
|
.bpp = 24,
|
|
.yuv = true,
|
|
.lddfr = LDDFR_CC | LDDFR_YF_444,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV42,
|
|
.bpp = 24,
|
|
.yuv = true,
|
|
.lddfr = LDDFR_CC | LDDFR_YF_444,
|
|
},
|
|
};
|
|
|
|
const struct shmob_drm_format_info *shmob_drm_format_info(u32 fourcc)
|
|
{
|
|
unsigned int i;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(shmob_drm_format_infos); ++i) {
|
|
if (shmob_drm_format_infos[i].fourcc == fourcc)
|
|
return &shmob_drm_format_infos[i];
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
* Frame buffer
|
|
*/
|
|
|
|
static struct drm_framebuffer *
|
|
shmob_drm_fb_create(struct drm_device *dev, struct drm_file *file_priv,
|
|
const struct drm_mode_fb_cmd2 *mode_cmd)
|
|
{
|
|
const struct shmob_drm_format_info *format;
|
|
|
|
format = shmob_drm_format_info(mode_cmd->pixel_format);
|
|
if (format == NULL) {
|
|
dev_dbg(dev->dev, "unsupported pixel format %08x\n",
|
|
mode_cmd->pixel_format);
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
|
|
if (mode_cmd->pitches[0] & 7 || mode_cmd->pitches[0] >= 65536) {
|
|
dev_dbg(dev->dev, "invalid pitch value %u\n",
|
|
mode_cmd->pitches[0]);
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
|
|
if (format->yuv) {
|
|
unsigned int chroma_cpp = format->bpp == 24 ? 2 : 1;
|
|
|
|
if (mode_cmd->pitches[1] != mode_cmd->pitches[0] * chroma_cpp) {
|
|
dev_dbg(dev->dev,
|
|
"luma and chroma pitches do not match\n");
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
}
|
|
|
|
return drm_gem_fb_create(dev, file_priv, mode_cmd);
|
|
}
|
|
|
|
static const struct drm_mode_config_funcs shmob_drm_mode_config_funcs = {
|
|
.fb_create = shmob_drm_fb_create,
|
|
};
|
|
|
|
int shmob_drm_modeset_init(struct shmob_drm_device *sdev)
|
|
{
|
|
drm_mode_config_init(sdev->ddev);
|
|
|
|
shmob_drm_crtc_create(sdev);
|
|
shmob_drm_encoder_create(sdev);
|
|
shmob_drm_connector_create(sdev, &sdev->encoder.encoder);
|
|
|
|
drm_kms_helper_poll_init(sdev->ddev);
|
|
|
|
sdev->ddev->mode_config.min_width = 0;
|
|
sdev->ddev->mode_config.min_height = 0;
|
|
sdev->ddev->mode_config.max_width = 4095;
|
|
sdev->ddev->mode_config.max_height = 4095;
|
|
sdev->ddev->mode_config.funcs = &shmob_drm_mode_config_funcs;
|
|
|
|
drm_helper_disable_unused_functions(sdev->ddev);
|
|
|
|
return 0;
|
|
}
|