7b4eb53d95
The tests at tools/testing/selftests/bpf can run in patch mode, e.g.,
make -C tools/testing/selftests/bpf run_tests
With the batch mode, I experimented intermittent test failure of
test_xdp_redirect.sh.
....
selftests: test_xdp_redirect [PASS]
selftests: test_xdp_redirect.sh [PASS]
RTNETLINK answers: File exists
selftests: test_xdp_meta [FAILED]
selftests: test_xdp_meta.sh [FAIL]
....
The following illustrates what caused the failure:
(1). test_xdp_redirect creates veth pairs (veth1,veth11) and
(veth2,veth22), and assign veth11 and veth22 to namespace
ns1 and ns2 respectively.
(2). at the end of test_xdp_redirect test, ns1 and ns2 are
deleted. During this process, the deletion of actual
namespace resources, including deletion of veth1{1} and veth2{2},
is put into a workqueue to be processed asynchronously.
(3). test_xdp_meta tries to create veth pair (veth1, veth2).
The previous veth deletions in step (2) have not finished yet,
and veth1 or veth2 may be still valid in the kernel, thus
causing the failure.
The fix is to explicitly delete the veth pair before test_xdp_redirect
exits. Only one end of veth needs deletion as the kernel will delete
the other end automatically. Also test_xdp_meta is also fixed in
similar manner to avoid future potential issues.
Fixes: 996139e801 ("selftests: bpf: add a test for XDP redirect")
Fixes: 22c8852624 ("bpf: improve selftests and add tests for meta pointer")
Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
53 lines
1.2 KiB
Bash
Executable file
53 lines
1.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
cleanup()
|
|
{
|
|
if [ "$?" = "0" ]; then
|
|
echo "selftests: test_xdp_meta [PASS]";
|
|
else
|
|
echo "selftests: test_xdp_meta [FAILED]";
|
|
fi
|
|
|
|
set +e
|
|
ip link del veth1 2> /dev/null
|
|
ip netns del ns1 2> /dev/null
|
|
ip netns del ns2 2> /dev/null
|
|
}
|
|
|
|
ip link set dev lo xdp off 2>/dev/null > /dev/null
|
|
if [ $? -ne 0 ];then
|
|
echo "selftests: [SKIP] Could not run test without the ip xdp support"
|
|
exit 0
|
|
fi
|
|
set -e
|
|
|
|
ip netns add ns1
|
|
ip netns add ns2
|
|
|
|
trap cleanup 0 2 3 6 9
|
|
|
|
ip link add veth1 type veth peer name veth2
|
|
|
|
ip link set veth1 netns ns1
|
|
ip link set veth2 netns ns2
|
|
|
|
ip netns exec ns1 ip addr add 10.1.1.11/24 dev veth1
|
|
ip netns exec ns2 ip addr add 10.1.1.22/24 dev veth2
|
|
|
|
ip netns exec ns1 tc qdisc add dev veth1 clsact
|
|
ip netns exec ns2 tc qdisc add dev veth2 clsact
|
|
|
|
ip netns exec ns1 tc filter add dev veth1 ingress bpf da obj test_xdp_meta.o sec t
|
|
ip netns exec ns2 tc filter add dev veth2 ingress bpf da obj test_xdp_meta.o sec t
|
|
|
|
ip netns exec ns1 ip link set dev veth1 xdp obj test_xdp_meta.o sec x
|
|
ip netns exec ns2 ip link set dev veth2 xdp obj test_xdp_meta.o sec x
|
|
|
|
ip netns exec ns1 ip link set dev veth1 up
|
|
ip netns exec ns2 ip link set dev veth2 up
|
|
|
|
ip netns exec ns1 ping -c 1 10.1.1.22
|
|
ip netns exec ns2 ping -c 1 10.1.1.11
|
|
|
|
exit 0
|