![Sergei Trofimovich](/assets/img/avatar_default.png)
The bug was accidentally found by the following program:
#include <asm/sysinfo.h>
#include <asm/unistd.h>
#include <sys/syscall.h>
static int setsysinfo(unsigned long op, void *buffer, unsigned long size,
int *start, void *arg, unsigned long flag) {
return syscall(__NR_osf_setsysinfo, op, buffer, size, start, arg, flag);
}
int main(int argc, char **argv) {
short x[10];
unsigned int buf[2] = { SSIN_UACPROC, UAC_SIGBUS, };
setsysinfo(SSI_NVPAIRS, buf, 1, 0, 0, 0);
int *y = (int*) (x+1);
*y = 0;
return 0;
}
The program shoud fail on SIGBUS, but didn't.
The patch is a second part of userspace flag fix (commit 745dd2405e
"Alpha: Rearrange thread info flags fixing two regressions").
Deleted outdated out-of-sync 'UAC_SHIFT' (the cause of bug) in favour of
'ALPHA_UAC_SHIFT'.
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Acked-by: Michael Cree <mcree@orcon.net.nz>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Matt Turner <mattst88@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
31 lines
691 B
C
31 lines
691 B
C
/*
|
|
* include/asm-alpha/sysinfo.h
|
|
*/
|
|
|
|
#ifndef __ASM_ALPHA_SYSINFO_H
|
|
#define __ASM_ALPHA_SYSINFO_H
|
|
|
|
/* This defines the subset of the OSF/1 getsysinfo/setsysinfo calls
|
|
that we support. */
|
|
|
|
#define GSI_UACPROC 8
|
|
#define GSI_IEEE_FP_CONTROL 45
|
|
#define GSI_IEEE_STATE_AT_SIGNAL 46
|
|
#define GSI_PROC_TYPE 60
|
|
#define GSI_GET_HWRPB 101
|
|
|
|
#define SSI_NVPAIRS 1
|
|
#define SSI_IEEE_FP_CONTROL 14
|
|
#define SSI_IEEE_STATE_AT_SIGNAL 15
|
|
#define SSI_IEEE_IGNORE_STATE_AT_SIGNAL 16
|
|
#define SSI_IEEE_RAISE_EXCEPTION 1001 /* linux specific */
|
|
|
|
#define SSIN_UACPROC 6
|
|
|
|
#define UAC_BITMASK 7
|
|
#define UAC_NOPRINT 1
|
|
#define UAC_NOFIX 2
|
|
#define UAC_SIGBUS 4
|
|
|
|
#endif /* __ASM_ALPHA_SYSINFO_H */
|