1
0
Fork 0
alistair23-linux/drivers/virtio
Dan Carpenter e01dfcc08b virtio_ring: Fix two use after free bugs
[ Upstream commit e152d8af42 ]

The "vq" struct is added to the "vdev->vqs" list prematurely.  If we
encounter an error later in the function then the "vq" is freed, but
since it is still on the list that could lead to a use after free bug.

Fixes: cbeedb72b9 ("virtio_ring: allocate desc state for split ring separately")
Reported-by: Robert Buhren <robert.buhren@sect.tu-berlin.de>
Reported-by: Felicitas Hetzelt <file@sect.tu-berlin.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X8pGaG/zkI3jk8mk@mwanda
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-12-30 11:51:29 +01:00
..
Kconfig virtio-pmem: Add virtio pmem driver 2019-07-05 15:19:10 -07:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
virtio.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
virtio_balloon.c virtio_balloon: fix up endian-ness for free cmd id 2020-08-05 09:59:43 +02:00
virtio_input.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
virtio_mmio.c virtio-mmio: add error check for platform_get_irq 2019-07-11 16:22:29 -04:00
virtio_pci_common.c virtio-pci: check name when counting MSI-X vectors 2020-02-11 04:35:43 -08:00
virtio_pci_common.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 78 2019-05-24 17:37:51 +02:00
virtio_pci_legacy.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 78 2019-05-24 17:37:51 +02:00
virtio_pci_modern.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 78 2019-05-24 17:37:51 +02:00
virtio_ring.c virtio_ring: Fix two use after free bugs 2020-12-30 11:51:29 +01:00