![Ido Schimmel](/assets/img/avatar_default.png)
switchdev_port_fwd_mark_set() is used to set the 'offload_fwd_mark' of port netdevs so that packets being flooded by the device won't be flooded twice. It works by assigning a unique identifier (the ifindex of the first bridge port) to bridge ports sharing the same parent ID. This prevents packets from being flooded twice by the same switch, but will flood packets through bridge ports belonging to a different switch. This method is problematic when stacked devices are taken into account, such as VLANs. In such cases, a physical port netdev can have upper devices being members in two different bridges, thus requiring two different 'offload_fwd_mark's to be configured on the port netdev, which is impossible. The main problem is that packet and netdev marking is performed at the physical netdev level, whereas flooding occurs between bridge ports, which are not necessarily port netdevs. Instead, packet and netdev marking should really be done in the bridge driver with the switch driver only telling it which packets it already forwarded. The bridge driver will mark such packets using the mark assigned to the ingress bridge port and will prevent the packet from being forwarded through any bridge port sharing the same mark (i.e. having the same parent ID). Remove the current switchdev 'offload_fwd_mark' implementation and instead implement the proposed method. In addition, make rocker - the sole user of the mark - use the proposed method. Signed-off-by: Ido Schimmel <idosch@mellanox.com> Signed-off-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
26 lines
729 B
Makefile
26 lines
729 B
Makefile
#
|
|
# Makefile for the IEEE 802.1d ethernet bridging layer.
|
|
#
|
|
|
|
obj-$(CONFIG_BRIDGE) += bridge.o
|
|
|
|
bridge-y := br.o br_device.o br_fdb.o br_forward.o br_if.o br_input.o \
|
|
br_ioctl.o br_stp.o br_stp_bpdu.o \
|
|
br_stp_if.o br_stp_timer.o br_netlink.o
|
|
|
|
bridge-$(CONFIG_SYSFS) += br_sysfs_if.o br_sysfs_br.o
|
|
|
|
bridge-$(subst m,y,$(CONFIG_BRIDGE_NETFILTER)) += br_nf_core.o
|
|
|
|
br_netfilter-y := br_netfilter_hooks.o
|
|
br_netfilter-$(subst m,y,$(CONFIG_IPV6)) += br_netfilter_ipv6.o
|
|
obj-$(CONFIG_BRIDGE_NETFILTER) += br_netfilter.o
|
|
|
|
bridge-$(CONFIG_BRIDGE_IGMP_SNOOPING) += br_multicast.o br_mdb.o
|
|
|
|
bridge-$(CONFIG_BRIDGE_VLAN_FILTERING) += br_vlan.o
|
|
|
|
bridge-$(CONFIG_NET_SWITCHDEV) += br_switchdev.o
|
|
|
|
obj-$(CONFIG_NETFILTER) += netfilter/
|