1
0
Fork 0
alistair23-linux/sound/soc/fsl
Stephan Gerhold 2a0435df96
ASoC: hdmi-codec: Fix return value in hdmi_codec_set_jack()
Sound is broken on the DragonBoard 410c (apq8016_sbc) since 5.10:

  hdmi-audio-codec hdmi-audio-codec.1.auto: ASoC: error at snd_soc_component_set_jack on hdmi-audio-codec.1.auto: -95
  qcom-apq8016-sbc 7702000.sound: Failed to set jack: -95
  ADV7533: ASoC: error at snd_soc_link_init on ADV7533: -95
  hdmi-audio-codec hdmi-audio-codec.1.auto: ASoC: error at snd_soc_component_set_jack on hdmi-audio-codec.1.auto: -95
  qcom-apq8016-sbc: probe of 7702000.sound failed with error -95

This happens because apq8016_sbc calls snd_soc_component_set_jack() on
all codec DAIs and attempts to ignore failures with return code -ENOTSUPP.
-ENOTSUPP is also excluded from error logging in soc_component_ret().

However, hdmi_codec_set_jack() returns -E*OP*NOTSUPP if jack detection
is not supported, which is not handled in apq8016_sbc and soc_component_ret().
Make it return -ENOTSUPP instead to fix sound and silence the errors.

Cc: Cheng-Yi Chiang <cychiang@chromium.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Fixes: 55c5cc63ab ("ASoC: hdmi-codec: Use set_jack ops to set jack")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Link: https://lore.kernel.org/r/20210107165131.2535-1-stephan@gerhold.net
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-08 14:00:42 +00:00
..
Kconfig ASoC: fsl: Add imx-hdmi machine driver 2020-12-08 14:20:35 +00:00
Makefile ASoC: fsl: Add imx-hdmi machine driver 2020-12-08 14:20:35 +00:00
efika-audio-fabric.c ASoC: fsl: efika-audio-fabric: use modern dai_link style 2019-06-06 21:41:08 +01:00
eukrea-tlv320.c ASoC: fsl: use asoc_substream_to_rtd() 2020-07-23 19:07:31 +01:00
fsl-asoc-card.c ASoC: fsl-asoc-card: Add support for si476x codec 2020-12-03 13:13:24 +00:00
fsl_asrc.c ASoC: fsl: fsl_asrc: fix kernel-doc 2020-07-03 16:09:27 +01:00
fsl_asrc.h ASoC: fsl_asrc: Move common definition to fsl_asrc_common 2020-04-21 16:34:09 +01:00
fsl_asrc_common.h ASoC: fsl_asrc_dma: Fix data copying speed issue with EDMA 2020-06-12 14:18:04 +01:00
fsl_asrc_dma.c ASoC: fsl: use asoc_substream_to_rtd() 2020-07-23 19:07:31 +01:00
fsl_aud2htx.c ASoC: fsl_aud2htx: mark PM functions as __maybe_unused 2020-12-04 23:26:36 +00:00
fsl_aud2htx.h ASoC: fsl_aud2htx: Add aud2htx module driver 2020-11-05 17:06:16 +00:00
fsl_audmix.c ASoC: fsl_audmix: Remove unneeded data field 2020-12-03 13:13:23 +00:00
fsl_audmix.h ASoC: fsl_audmix: Add spin lock to protect tdms 2019-11-11 13:01:37 +00:00
fsl_dma.c ASoC: various vendors: delete repeated words in comments 2020-08-18 14:52:32 +01:00
fsl_dma.h ASoC: fsl-dma: Switch to SPDX identifier 2019-04-08 13:51:01 +07:00
fsl_easrc.c ASoC: fsl_easrc: Fix uninitialized scalar variable in fsl_easrc_set_ctx_format 2020-06-23 12:54:09 +01:00
fsl_easrc.h ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers 2020-04-21 16:34:11 +01:00
fsl_esai.c ASoC: fsl: Replace tasklet with work 2020-09-09 15:42:08 +01:00
fsl_esai.h ASoC: fsl_esai: Switch to SPDX identifier 2018-05-03 10:29:05 +09:00
fsl_micfil.c ASoC: fsl_micfil: Do not pass irq numbers in comments 2020-05-19 14:18:52 +01:00
fsl_micfil.h ASoC: Add MICFIL SoC Digital Audio Interface driver. 2019-01-07 17:00:55 +00:00
fsl_mqs.c ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable 2020-06-23 11:14:22 +01:00
fsl_sai.c ASoC: fsl_sai: Correct the clock source for mclk0 2020-11-19 13:00:01 +00:00
fsl_sai.h ASoC: fsl_sai: Correct the clock source for mclk0 2020-11-19 13:00:01 +00:00
fsl_spdif.c ASoC: fsl_spdif: Add support for higher sample rates 2020-10-26 18:37:09 +00:00
fsl_spdif.h ASoC: fsl_spdif: Add support for higher sample rates 2020-10-26 18:37:09 +00:00
fsl_ssi.c treewide: Use fallthrough pseudo-keyword 2020-08-23 17:36:59 -05:00
fsl_ssi.h ASoC: fsl: no need to check return value of debugfs_create functions 2019-06-14 16:37:48 +01:00
fsl_ssi_dbg.c ASoC: fsl: fsl_ssi_dbg: remove spurious kernel-doc comment start 2020-07-03 16:09:24 +01:00
fsl_utils.c ASoC: fsl: mpc8610_hpcd/p1022_ds/p1022_rdk: use modern dai_link style 2019-06-06 21:42:35 +01:00
fsl_utils.h ASoC: fsl_utils: Switch to SPDX identifier 2018-07-24 16:59:03 +01:00
fsl_xcvr.c ASoC: fsl_xcvr: fix potential resource leak 2020-11-25 12:54:43 +00:00
fsl_xcvr.h ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver 2020-10-26 15:45:31 +00:00
imx-audmix.c ASoC: fsl: imx-audmix: Use devm_kcalloc() instead of devm_kzalloc() 2020-09-25 20:50:39 +01:00
imx-audmux.c ASoC: imx-audmux: Remove unused .id_table 2020-11-23 20:39:50 +00:00
imx-audmux.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
imx-es8328.c ASoC: fsl: imx-es8328: add missing put_device() call in imx_es8328_probe() 2020-09-08 15:50:12 +01:00
imx-hdmi.c ASoC: hdmi-codec: Fix return value in hdmi_codec_set_jack() 2021-01-08 14:00:42 +00:00
imx-pcm-dma.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
imx-pcm-fiq.c ASoC: fsl: Drop superfluous ioctl PCM ops 2019-12-11 15:56:42 +00:00
imx-pcm.h ASoC: imx-pcm: Switch to SPDX identifier 2019-04-08 13:47:44 +07:00
imx-sgtl5000.c ASoC: fsl: use asoc_rtd_to_cpu() / asoc_rtd_to_codec() macro for DAI pointer 2020-03-27 14:44:36 +00:00
imx-spdif.c ASoC: fsl: imx-spdif: consider CPU-Platform possibility 2019-06-28 15:12:19 +01:00
imx-ssi.h ASoC: imx-ssi: Switch to SPDX identifier 2019-04-08 13:53:35 +07:00
mpc5200_dma.c ASoC: fsl: Fix unused variable warning 2020-08-03 16:25:48 +01:00
mpc5200_dma.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mpc5200_psc_ac97.c ASoC: soc-core: remove bus_control 2020-01-21 17:07:08 +00:00
mpc5200_psc_i2s.c ASoC: fsl: use asoc_substream_to_rtd() 2020-07-23 19:07:31 +01:00
mpc8610_hpcd.c ASoC: fsl: use asoc_substream_to_rtd() 2020-07-23 19:07:31 +01:00
p1022_ds.c ASoC: fsl: use asoc_substream_to_rtd() 2020-07-23 19:07:31 +01:00
p1022_rdk.c ASoC: fsl: use asoc_substream_to_rtd() 2020-07-23 19:07:31 +01:00
pcm030-audio-fabric.c ASoC: fsl: pcm030-audio-fabric: use modern dai_link style 2019-06-06 21:43:43 +01:00