1
0
Fork 0
alistair23-linux/sound/core/seq/oss
Takashi Iwai 197b958c1e ALSA: seq: oss: Don't drain at closing a client
The OSS sequencer client tries to drain the pending events at
releasing.  Unfortunately, as spotted by syzkaller fuzzer, this may
lead to an unkillable process state when the event has been queued at
the far future.  Since the process being released can't be signaled
any longer, it remains and waits for the echo-back event in that far
future.

Back to history, the draining feature was implemented at the time we
misinterpreted POSIX definition for blocking file operation.
Actually, such a behavior is superfluous at release, and we should
just release the device as is instead of keeping it up forever.

This patch just removes the draining call that may block the release
for too long time unexpectedly.

BugLink: http://lkml.kernel.org/r/CACT4Y+Y4kD-aBGj37rf-xBw9bH3GMU6P+MYg4W1e-s-paVD2pg@mail.gmail.com
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2016-03-01 20:26:40 +01:00
..
Makefile [ALSA] Changed Jaroslav Kysela's e-mail from perex@suse.cz to perex@perex.cz 2007-10-16 16:51:18 +02:00
seq_oss.c ALSA: seq: oss: Don't drain at closing a client 2016-03-01 20:26:40 +01:00
seq_oss_device.h ALSA: seq: oss: Don't drain at closing a client 2016-03-01 20:26:40 +01:00
seq_oss_event.c ALSA: seq: seq_oss_event: missing range checks 2013-03-04 16:39:50 +01:00
seq_oss_event.h [ALSA] Remove xxx_t typedefs: Sequencer OSS-emulation 2006-01-03 12:17:57 +01:00
seq_oss_init.c ALSA: seq: oss: Don't drain at closing a client 2016-03-01 20:26:40 +01:00
seq_oss_ioctl.c ALSA: seq_oss: Drop debug prints 2014-02-14 08:14:13 +01:00
seq_oss_midi.c ALSA: replace CONFIG_PROC_FS with CONFIG_SND_PROC_FS 2015-05-27 21:25:19 +02:00
seq_oss_midi.h [ALSA] Remove xxx_t typedefs: Sequencer OSS-emulation 2006-01-03 12:17:57 +01:00
seq_oss_readq.c ALSA: seq_oss: fix waitqueue_active without memory barrier in snd-seq-oss 2015-10-09 09:45:52 +02:00
seq_oss_readq.h [ALSA] Remove xxx_t typedefs: Sequencer OSS-emulation 2006-01-03 12:17:57 +01:00
seq_oss_rw.c [ALSA] Remove xxx_t typedefs: Sequencer OSS-emulation 2006-01-03 12:17:57 +01:00
seq_oss_synth.c ALSA: seq: Fix incorrect sanity check at snd_seq_oss_synth_cleanup() 2016-01-25 11:49:10 +01:00
seq_oss_synth.h ALSA: seq: Define driver object in each driver 2015-02-12 14:15:54 +01:00
seq_oss_timer.c ALSA: seq_oss: Drop debug prints 2014-02-14 08:14:13 +01:00
seq_oss_timer.h [ALSA] Remove xxx_t typedefs: Sequencer OSS-emulation 2006-01-03 12:17:57 +01:00
seq_oss_writeq.c ALSA: seq_oss: fix waitqueue_active without memory barrier in snd-seq-oss 2015-10-09 09:45:52 +02:00
seq_oss_writeq.h [ALSA] Remove xxx_t typedefs: Sequencer OSS-emulation 2006-01-03 12:17:57 +01:00