Kinglong Mee 38a33101dd NFS: fix the fault nrequests decreasing for nfs_inode COPY ... The nfs_commit_file for NFSv4.2's COPY operation goes through the commit path for normal WRITE, but without increase nrequests, so, the nrequests decreased in nfs_commit_release_pages is fault. After that, the nrequests will be wrong. [ 5670.299881] ------------[ cut here ]------------ [ 5670.300295] WARNING: CPU: 0 PID: 27656 at fs/nfs/inode.c:127 nfs_clear_inode+0x66/0x90 [nfs] [ 5670.300558] Modules linked in: nfsv4(E) nfs(E) fscache(E) tun bridge stp llc fuse ip_set nfnetlink vmw_vsock_vmci_transport vsock snd_seq_midi snd_seq_midi_event ppdev f2fs coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_ens1371 intel_rapl_perf gameport snd_ac97_codec vmw_balloon ac97_bus snd_seq snd_pcm joydev snd_rawmidi snd_timer snd_seq_device snd soundcore nfit parport_pc parport acpi_cpufreq tpm_tis tpm_tis_core tpm i2c_piix4 vmw_vmci shpchp nfsd auth_rpcgss nfs_acl lockd grace sunrpc xfs libcrc32c vmwgfx drm_kms_helper ttm drm e1000 crc32c_intel mptspi scsi_transport_spi serio_raw mptscsih mptbase ata_generic pata_acpi fjes [last unloaded: fscache] [ 5670.302925] CPU: 0 PID: 27656 Comm: umount.nfs4 Tainted: G W E 4.11.0-rc1+ #519 [ 5670.303292] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/02/2015 [ 5670.304094] Call Trace: [ 5670.304510] dump_stack+0x63/0x86 [ 5670.304917] __warn+0xcb/0xf0 [ 5670.305276] warn_slowpath_null+0x1d/0x20 [ 5670.305661] nfs_clear_inode+0x66/0x90 [nfs] [ 5670.306093] nfs4_evict_inode+0x61/0x70 [nfsv4] [ 5670.306480] evict+0xbb/0x1c0 [ 5670.306888] dispose_list+0x4d/0x70 [ 5670.307233] evict_inodes+0x178/0x1a0 [ 5670.307579] generic_shutdown_super+0x44/0xf0 [ 5670.307985] nfs_kill_super+0x21/0x40 [nfs] [ 5670.308325] deactivate_locked_super+0x43/0x70 [ 5670.308698] deactivate_super+0x5a/0x60 [ 5670.309036] cleanup_mnt+0x3f/0x90 [ 5670.309407] __cleanup_mnt+0x12/0x20 [ 5670.309837] task_work_run+0x80/0xa0 [ 5670.310162] exit_to_usermode_loop+0x89/0x90 [ 5670.310497] syscall_return_slowpath+0xaa/0xb0 [ 5670.310875] entry_SYSCALL_64_fastpath+0xa7/0xa9 [ 5670.311197] RIP: 0033:0x7f1bb3617fe7 [ 5670.311545] RSP: 002b:00007ffecbabb828 EFLAGS: 00000206 ORIG_RAX: 00000000000000a6 [ 5670.311906] RAX: 0000000000000000 RBX: 0000000001dca1f0 RCX: 00007f1bb3617fe7 [ 5670.312239] RDX: 000000000000000c RSI: 0000000000000001 RDI: 0000000001dc83c0 [ 5670.312653] RBP: 0000000001dc83c0 R08: 0000000000000001 R09: 0000000000000000 [ 5670.312998] R10: 0000000000000755 R11: 0000000000000206 R12: 00007ffecbabc66a [ 5670.313335] R13: 0000000001dc83a0 R14: 0000000000000000 R15: 0000000000000000 [ 5670.313758] ---[ end trace bf4bfe7764e4eb40 ]--- Cc: linux-kernel@vger.kernel.org Fixes: 67911c8f18 ("NFS: Add nfs_commit_file()") Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> Cc: stable@vger.kernel.org # 4.7+ Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>		2017-03-17 16:03:51 -04:00
..
blocklayout	pnfs/blocklayout: fix last_write_offset incorrectly set to page boundary	2016-10-13 16:42:53 -04:00
filelayout	NFS: Use nfs4_setup_sequence() everywhere	2017-01-30 13:14:50 -05:00
flexfilelayout	pNFS/flexfiles: If the layout is invalid, it must be updated before retrying	2017-02-22 10:49:37 -05:00
objlayout	pNFS: Get rid of unnecessary layout parameter in encode_layoutreturn callback	2016-12-01 17:21:44 -05:00
cache_lib.c	sunrpc/nfs: cleanup procfs/pipefs entry in cache_detail	2017-02-08 17:02:45 -05:00
cache_lib.h
callback.c	NFSv4.x: hide array-bounds warning	2016-11-22 16:11:44 -05:00
callback.h	nfs: add handling for CB_NOTIFY_LOCK in client	2016-09-22 13:56:04 -04:00
callback_proc.c	pNFS: Delay getting the layout header in CB_LAYOUTRECALL handlers	2016-12-01 17:21:42 -05:00
callback_xdr.c	NFSv4: Replace callback string decode function with a generic	2017-02-21 16:56:16 -05:00
client.c	NFS: Remove unused authflavour parameter from nfs_get_client()	2016-12-01 17:46:32 -05:00
delegation.c	NFSv4: Optimise away forced revalidation when we know the attributes are OK	2016-12-01 17:21:37 -05:00
delegation.h	NFSv4: nfs_inode_find_state_and_recover() should check all stateids	2016-09-27 14:34:35 -04:00
dir.c	NFS: nfs_rename() handle -ERESTARTSYS dentry left behind	2017-02-08 17:02:44 -05:00
direct.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
dns_resolve.c
dns_resolve.h
file.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
fscache-index.c
fscache.c
fscache.h
getroot.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
inode.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
internal.h	NFS: Clean up cache validity checking	2016-12-19 17:29:35 -05:00
io.c
iostat.h
Kconfig
Makefile
mount_clnt.c
namespace.c	NFS: Trim extra slash in v4 nfs_path	2016-10-24 12:06:01 -04:00
netns.h	netns: make struct pernet_operations::id unsigned int	2016-11-18 10:59:15 -05:00
nfs.h
nfs2super.c
nfs2xdr.c
nfs3_fs.h
nfs3acl.c
nfs3client.c	NFS: Remove unused authflavour parameter from nfs_get_client()	2016-12-01 17:46:32 -05:00
nfs3proc.c	vfs: Remove {get,set,remove}xattr inode operations	2016-10-07 21:48:36 -04:00
nfs3super.c
nfs3xdr.c
nfs4_fs.h	NFS: Use nfs4_setup_sequence() everywhere	2017-01-30 13:14:50 -05:00
nfs4client.c	NFS: Remove unused authflavour parameter from nfs_get_client()	2016-12-01 17:46:32 -05:00
nfs4file.c	NFSv4: add flock_owner to open context	2016-12-01 17:57:27 -05:00
nfs4getroot.c
nfs4idmap.c
nfs4idmap.h
nfs4namespace.c
nfs4proc.c	NFSv4: fix a reference leak caused WARNING messages	2017-03-13 10:55:45 -04:00
nfs4renewd.c	NFSv4: Set the connection timeout to match the lease period	2017-02-09 14:15:16 -05:00
nfs4session.c	NFSv4.1: Fix regression in callback retry handling	2016-12-01 17:21:38 -05:00
nfs4session.h	NFS: Make trace_nfs4_setup_sequence() available to NFS v4.0	2017-01-30 13:14:50 -05:00
nfs4state.c	NFSv4: Fix warning for using 0 as NULL	2017-01-30 13:14:51 -05:00
nfs4super.c
nfs4sysctl.c
nfs4trace.c
nfs4trace.h	NFS: Make trace_nfs4_setup_sequence() available to NFS v4.0	2017-01-30 13:14:50 -05:00
nfs4xdr.c	nfs4: fix a typo of NFS_ATTR_FATTR_GROUP_NAME	2017-03-13 10:39:10 -04:00
nfs42.h
nfs42proc.c	NFSv4: Fix reboot recovery in copy offload	2017-02-22 13:49:11 -05:00
nfs42xdr.c	pNFS/flexfiles: Minor refactoring before adding iostats to layoutreturn	2016-12-03 15:37:45 -05:00
nfsroot.c
nfstrace.c
nfstrace.h
pagelist.c	NFS: discard nfs_lockowner structure.	2016-12-01 17:58:13 -05:00
pnfs.c	pNFS: Fix a reference leak in _pnfs_return_layout	2017-01-26 15:50:41 -05:00
pnfs.h	pNFS/flexfiles: Minor refactoring before adding iostats to layoutreturn	2016-12-03 15:37:45 -05:00
pnfs_dev.c
pnfs_nfs.c	NFS: Remove unused authflavour parameter from nfs_get_client()	2016-12-01 17:46:32 -05:00
proc.c	fs: rename "rename2" i_op to "rename"	2016-09-27 11:03:58 +02:00
read.c	mm: remove page_file_index	2016-10-07 18:46:28 -07:00
super.c	NFS: tidy up nfs_show_mountd_netid	2017-01-30 13:14:50 -05:00
symlink.c	vfs: remove ".readlink = generic_readlink" assignments	2016-12-09 16:45:04 +01:00
sysctl.c
unlink.c
write.c	NFS: fix the fault nrequests decreasing for nfs_inode COPY	2017-03-17 16:03:51 -04:00