399426cadf
Usually, I don't like fixing coding style issues on non-staging drivers, as it could be a mess pretty easy, and could become like a snow ball. That's the case of recent changes on two changesets: they disalign some statements. Yet, a care a lot with cx88 driver, as it was the first driver I touched at the Kernel, and I've been maintaining it since 2005. So, several of the coding style issues were due to my code. Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with fixed several other issues, did some function alinments, but broke other alinments. So, I had to manually apply another round of manual fixes to make sure that everything is ok, and to make checkpatch happy with this patch. With this patch, checkpatch.pl is now happy when called with: ./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL Also, the 80-cols violations that made sense were fixed. Checkpatch would be happier if we convert it to use dev_foo(), but this is a more complex change. NOTE: there are some places with msleep(1). As this driver was written at the time that the default was to sleep at least 10ms on such calls (e. g. CONFIG_HZ=100), I replaced those calls by usleep_range(10000, 20000), with should be safe to avoid breakages. Fixes:65bc2fe86e("[media] cx88: convert it to use pr_foo() macros") Fixes:7b61ba8ff8("[media] cx88: make checkpatch happier") Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
36 lines
1.3 KiB
C
36 lines
1.3 KiB
C
/*
|
|
* cx88-vp3054-i2c.h -- support for the secondary I2C bus of the
|
|
* DNTV Live! DVB-T Pro (VP-3054), wired as:
|
|
* GPIO[0] -> SCL, GPIO[1] -> SDA
|
|
*
|
|
* (c) 2005 Chris Pascoe <c.pascoe@itee.uq.edu.au>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
/* ----------------------------------------------------------------------- */
|
|
struct vp3054_i2c_state {
|
|
struct i2c_adapter adap;
|
|
struct i2c_algo_bit_data algo;
|
|
u32 state;
|
|
};
|
|
|
|
/* ----------------------------------------------------------------------- */
|
|
#if IS_ENABLED(CONFIG_VIDEO_CX88_VP3054)
|
|
int vp3054_i2c_probe(struct cx8802_dev *dev);
|
|
void vp3054_i2c_remove(struct cx8802_dev *dev);
|
|
#else
|
|
static inline int vp3054_i2c_probe(struct cx8802_dev *dev)
|
|
{ return 0; }
|
|
static inline void vp3054_i2c_remove(struct cx8802_dev *dev)
|
|
{ }
|
|
#endif
|