1
0
Fork 0
alistair23-linux/drivers/media/pci/ddbridge
Nathan Chancellor bbb55cd708 media: ddbridge: Move asm includes after linux ones
Without this, cpumask_t and bool are not defined:

In file included from drivers/media/pci/ddbridge/ddbridge-ci.c:19:
In file included from drivers/media/pci/ddbridge/ddbridge.h:22:
./arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
extern void arch_trigger_cpumask_backtrace(const cpumask_t *mask,
                                                 ^
./arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'
                                           bool exclude_self);
                                           ^

Doing a survey of the kernel tree, this appears to be expected because
'#include <asm/irq.h>' is always after the linux includes.

This also fixes warnings of this variety (with Clang):

In file included from drivers/media/pci/ddbridge/ddbridge-ci.c:19:
In file included from drivers/media/pci/ddbridge/ddbridge.h:56:
In file included from ./include/media/dvb_net.h:22:
In file included from ./include/linux/netdevice.h:50:
In file included from ./include/uapi/linux/neighbour.h:6:
In file included from ./include/linux/netlink.h:9:
In file included from ./include/net/scm.h:11:
In file included from ./include/linux/sched/signal.h:6:
./include/linux/signal.h:87:11: warning: array index 3 is past the end
of the array (which contains 2 elements) [-Warray-bounds]
                return (set->sig[3] | set->sig[2] |
                        ^        ~
./arch/arm/include/asm/signal.h:17:2: note: array 'sig' declared here
        unsigned long sig[_NSIG_WORDS];
        ^

Fixes: b6973637c4 ("media: ddbridge: remove another duplicate of io.h and sort includes")

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
2018-12-20 06:42:14 -05:00
..
Kconfig media: ddbridge: support dummy tuners with 125MByte/s dummy data stream 2018-05-04 10:43:48 -04:00
Makefile media: ddbridge/mci: split MaxSX8 specific code off to ddbridge-sx8.c 2018-07-30 16:23:12 -04:00
ddbridge-ci.c media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-ci.h media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-core.c media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-hw.c media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-hw.h media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-i2c.c media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-i2c.h media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-io.h media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-main.c media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-max.c media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-max.h media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-mci.c media: ddbridge/mci: split MaxSX8 specific code off to ddbridge-sx8.c 2018-07-30 16:23:12 -04:00
ddbridge-mci.h media: ddbridge/mci: add SX8 I/Q mode remark and remove DIAG CMD defines 2018-07-30 16:23:12 -04:00
ddbridge-regs.h media: ddbridge: header/boilerplate cleanups and cosmetics 2018-09-12 07:18:44 -04:00
ddbridge-sx8.c media: ddbridge/sx8: remove redundant check of iq_mode == 2 2018-09-12 09:14:05 -04:00
ddbridge.h media: ddbridge: Move asm includes after linux ones 2018-12-20 06:42:14 -05:00