1
0
Fork 0
alistair23-linux/arch/hexagon/mm
Guenter Roeck cb84c2b401 hexagon: Fix build failures in linux-next
hexagon:defconfig fails to build in linux-next since commit 332fd7c4fe
("genirq: Generic chip: Change irq_reg_{readl,writel} arguments").

The primary build failure is

arch/hexagon/include/asm/cacheflush.h: In function 'copy_to_user_page':
arch/hexagon/include/asm/cacheflush.h:89:22: error: 'VM_EXEC' undeclared

This is the result of including of <linux/io.h> from <linux/irq.h>,
which is now necessary due to the use of readl and writel from irq.h.
This causes recursive inclusions in hexagon code; cacheflush.h is included
from mm.h prior to the definition of VM_EXEC.

Fix the problem by moving copy_to_user_page from the hexagon include file to
arch/hexagon/mm/cache.c, similar to other architectures. After this change,
several redefinitions of readl and writel are reported. Those are caused
by recursive inclusions of io.h and asm/cacheflush.h. Fix those problems by
reducing the number of files included from those files. Also, it was necessary
to stop including asm-generic/cacheflush.h from asm/cacheflush.h. Instead,
functionality originally provided by asm-generic/cacheflush.h is now coded
in asm/cacheflush.h directly.

Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
signed-off-by: Richard Kuo <rkuo@codeaurora.org>
2014-12-16 13:27:12 -06:00
..
Makefile Hexagon: Add configuration and makefiles for the Hexagon architecture. 2011-11-01 07:34:21 -07:00
cache.c hexagon: Fix build failures in linux-next 2014-12-16 13:27:12 -06:00
copy_from_user.S Hexagon: Copyright marking changes 2012-10-18 17:07:21 -05:00
copy_to_user.S Hexagon: Copyright marking changes 2012-10-18 17:07:21 -05:00
copy_user_template.S Hexagon: Copyright marking changes 2012-10-18 17:07:21 -05:00
init.c mm/hexagon: prepare for removing num_physpages and simplify mem_init() 2013-07-03 16:07:36 -07:00
ioremap.c hexagon: Fix build failures in linux-next 2014-12-16 13:27:12 -06:00
pgalloc.c Hexagon: Copyright marking changes 2012-10-18 17:07:21 -05:00
strnlen_user.S Hexagon: Copyright marking changes 2012-10-18 17:07:21 -05:00
uaccess.c Hexagon: Copyright marking changes 2012-10-18 17:07:21 -05:00
vm_fault.c arch: mm: pass userspace fault flag to generic fault handler 2013-09-12 15:38:01 -07:00
vm_tlb.c Hexagon: Copyright marking changes 2012-10-18 17:07:21 -05:00