1
0
Fork 0
alistair23-linux/drivers/net/ethernet/via
Timo Teräs 6c606fa32c via-velocity: unconditionally drop frames with bad l2 length
By default the driver allowed incorrect frames to be received. What is
worse the code does not handle very short frames correctly. The FCS
length is unconditionally subtracted, and the underflow can cause
skb_put to be called with large number after implicit cast to unsigned.
And indeed, an skb_over_panic() was observed with via-velocity.

This removes the module parameter as it does not work in it's
current state, and should be implemented via NETIF_F_RXALL if needed.

Suggested-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-11-17 14:37:16 -05:00
..
Kconfig net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected 2015-09-25 12:36:58 -07:00
Makefile
via-rhine.c via-rhine: fix VLAN receive handling regression. 2015-10-16 00:55:30 -07:00
via-velocity.c via-velocity: unconditionally drop frames with bad l2 length 2015-11-17 14:37:16 -05:00
via-velocity.h net: velocity: Add platform device support to VIA velocity driver 2013-05-20 13:40:39 -07:00