1
0
Fork 0
alistair23-linux/drivers/rpmsg
Colin Ian King ed43d098f9 rpmsg: glink: initialize ret to zero to ensure error status check is correct
The new switch cases for RPM_CMD_RX_DONE, RPM_CMD_RX_DONE_W_REUSE,
RPM_CMD_RX_INTENT_REQ_ACK, RPM_CMD_INTENT and RPM_CMD_RX_INTENT_REQ from
4 recent commits are not setting ret and so a later non-zero check on ret
is testing on a garbage value in ret. Fix this by initializing ret to zero.

Detected by CoverityScan CID#1455249 ("Uninitialized scalar variable")

Fixes: 933b45da5d ("rpmsg: glink: Add support for TX intents)
Fixes: dacbb35e93 ("glink: Receive and store the remote intent buffers")
Fixes: 27b9c5b66b ("rpmsg: glink: Request for intents when unavailable")
Fixes: 88c6060f5a ("rpmsg: glink: Handle remote rx done command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
2017-09-04 10:52:30 -07:00
..
Kconfig rpmsg: glink: Introduce glink smem based transport 2017-08-29 20:33:57 -07:00
Makefile rpmsg: glink: Introduce glink smem based transport 2017-08-29 20:33:57 -07:00
qcom_glink_native.c rpmsg: glink: initialize ret to zero to ensure error status check is correct 2017-09-04 10:52:30 -07:00
qcom_glink_native.h rpmsg: glink: Make RX FIFO peak accessor to take an offset 2017-08-29 20:34:13 -07:00
qcom_glink_rpm.c rpmsg: glink: Make RX FIFO peak accessor to take an offset 2017-08-29 20:34:13 -07:00
qcom_glink_smem.c rpmsg: glink: Make RX FIFO peak accessor to take an offset 2017-08-29 20:34:13 -07:00
qcom_smd.c rpmsg: qcom_smd: add of_node node to edge device 2017-07-26 09:59:27 -07:00
rpmsg_char.c rpmsg updates for v4.13 2017-07-06 15:38:31 -07:00
rpmsg_core.c rpmsg updates for v4.13 2017-07-06 15:38:31 -07:00
rpmsg_internal.h rpmsg: Driver for user space endpoint interface 2017-01-18 10:43:15 -08:00
virtio_rpmsg_bus.c rpmsg: virtio_rpmsg_bus: fix sg_set_buf() when addr is not a valid kernel address 2017-08-24 15:37:28 -07:00