1
0
Fork 0
alistair23-linux/tools/usb
Colin Ian King e325808c00 usbip: tools: fix atoi() on non-null terminated string
Currently the call to atoi is being passed a single char string
that is not null terminated, so there is a potential read overrun
along the stack when parsing for an integer value.  Fix this by
instead using a 2 char string that is initialized to all zeros
to ensure that a 1 char read into the string is always terminated
with a \0.

Detected by cppcheck:
"Invalid atoi() argument nr 1. A nul-terminated string is required."

Fixes: 3391ba0e27 ("usbip: tools: Extract generic code to be shared with vudc backend")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-10-18 19:44:39 +02:00
..
ffs-aio-example License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
usbip usbip: tools: fix atoi() on non-null terminated string 2018-10-18 19:44:39 +02:00
.gitignore tools/usb: Add .gitignore file 2017-03-16 18:01:01 +09:00
Makefile tools: fix cross-compile var clobbering 2018-02-21 15:35:42 -08:00
ffs-test.c tools: usb: ffs-test: Fix build on big endian systems 2018-07-17 10:12:51 +03:00
hcd-tests.sh License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
testusb.c tools: usb: testusb: update default vary for superspeed 2017-06-02 11:22:27 +03:00