1
0
Fork 0
alistair23-linux/drivers/xen/events
Roger Pau Monne 910f8befdf xen/pirq: fix error path cleanup when binding MSIs
Current cleanup in the error path of xen_bind_pirq_msi_to_irq is
wrong. First of all there's an off-by-one in the cleanup loop, which
can lead to unbinding wrong IRQs.

Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.

Note that there's no need to differentiate between bound and unbound
IRQs when freeing them, __unbind_from_irq will deal with both of them
correctly.

Fixes: 4892c9b4ad ("xen: add support for MSI message groups")
Reported-by: Hooman Mirhadi <mirhadih@amazon.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Amit Shah <aams@amazon.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
2018-02-28 20:20:01 +01:00
..
Makefile xen/events: use the FIFO-based ABI if available 2014-01-06 10:07:57 -05:00
events_2l.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
events_base.c xen/pirq: fix error path cleanup when binding MSIs 2018-02-28 20:20:01 +01:00
events_fifo.c xen/events: events_fifo: Don't use {get,put}_cpu() in xen_evtchn_fifo_init() 2017-08-31 09:45:55 -04:00
events_internal.h Revert "xen/events/fifo: Handle linked events when closing a port" 2015-08-11 11:05:42 +01:00