0f4630f372
The separate struct bgpio_chip has been a pain to handle, both by being confusingly similar in name to struct gpio_chip and for being contained inside a struct so that struct gpio_chip is contained in a struct contained in a struct, making several steps of dereferencing necessary. Make things simpler: include the fields directly into <linux/gpio/driver.h>, #ifdef:ed for CONFIG_GENERIC_GPIO, and get rid of the <linux/basic_mmio_gpio.h> altogether. Prefix some of the member variables with bgpio_* and add proper kerneldoc while we're at it. Modify all users to handle the change and use a struct gpio_chip directly. And while we're at it: replace all container_of() dereferencing by gpiochip_get_data() and registering the gpio_chip with gpiochip_add_data(). Cc: arm@kernel.org Cc: Alexander Shiyan <shc_work@mail.ru> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Kukjin Kim <kgene@kernel.org> Cc: Alexandre Courbot <gnurou@gmail.com> Cc: Brian Norris <computersforpeace@gmail.com> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Nicolas Pitre <nicolas.pitre@linaro.org> Cc: Olof Johansson <olof@lixom.net> Cc: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> Cc: Rabin Vincent <rabin@rab.in> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-omap@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: bcm-kernel-feedback-list@broadcom.com Acked-by: Gregory Fong <gregory.0xf0@gmail.com> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> Acked-by: Tony Lindgren <tony@atomide.com> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Acked-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
115 lines
2.7 KiB
C
115 lines
2.7 KiB
C
/*
|
|
* Driver for GE FPGA based GPIO
|
|
*
|
|
* Author: Martyn Welch <martyn.welch@ge.com>
|
|
*
|
|
* 2008 (c) GE Intelligent Platforms Embedded Systems, Inc.
|
|
*
|
|
* This file is licensed under the terms of the GNU General Public License
|
|
* version 2. This program is licensed "as is" without any warranty of any
|
|
* kind, whether express or implied.
|
|
*/
|
|
|
|
/* TODO
|
|
*
|
|
* Configuration of output modes (totem-pole/open-drain)
|
|
* Interrupt configuration - interrupts are always generated the FPGA relies on
|
|
* the I/O interrupt controllers mask to stop them propergating
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/io.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/of_device.h>
|
|
#include <linux/of_gpio.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/module.h>
|
|
#include <linux/gpio/driver.h>
|
|
|
|
#define GEF_GPIO_DIRECT 0x00
|
|
#define GEF_GPIO_IN 0x04
|
|
#define GEF_GPIO_OUT 0x08
|
|
#define GEF_GPIO_TRIG 0x0C
|
|
#define GEF_GPIO_POLAR_A 0x10
|
|
#define GEF_GPIO_POLAR_B 0x14
|
|
#define GEF_GPIO_INT_STAT 0x18
|
|
#define GEF_GPIO_OVERRUN 0x1C
|
|
#define GEF_GPIO_MODE 0x20
|
|
|
|
static const struct of_device_id gef_gpio_ids[] = {
|
|
{
|
|
.compatible = "gef,sbc610-gpio",
|
|
.data = (void *)19,
|
|
}, {
|
|
.compatible = "gef,sbc310-gpio",
|
|
.data = (void *)6,
|
|
}, {
|
|
.compatible = "ge,imp3a-gpio",
|
|
.data = (void *)16,
|
|
},
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, gef_gpio_ids);
|
|
|
|
static int __init gef_gpio_probe(struct platform_device *pdev)
|
|
{
|
|
const struct of_device_id *of_id =
|
|
of_match_device(gef_gpio_ids, &pdev->dev);
|
|
struct gpio_chip *gc;
|
|
void __iomem *regs;
|
|
int ret;
|
|
|
|
gc = devm_kzalloc(&pdev->dev, sizeof(*gc), GFP_KERNEL);
|
|
if (!gc)
|
|
return -ENOMEM;
|
|
|
|
regs = of_iomap(pdev->dev.of_node, 0);
|
|
if (!regs)
|
|
return -ENOMEM;
|
|
|
|
ret = bgpio_init(gc, &pdev->dev, 4, regs + GEF_GPIO_IN,
|
|
regs + GEF_GPIO_OUT, NULL, NULL,
|
|
regs + GEF_GPIO_DIRECT, BGPIOF_BIG_ENDIAN_BYTE_ORDER);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "bgpio_init failed\n");
|
|
goto err0;
|
|
}
|
|
|
|
/* Setup pointers to chip functions */
|
|
gc->label = devm_kstrdup(&pdev->dev, pdev->dev.of_node->full_name,
|
|
GFP_KERNEL);
|
|
if (!gc->label) {
|
|
ret = -ENOMEM;
|
|
goto err0;
|
|
}
|
|
|
|
gc->base = -1;
|
|
gc->ngpio = (u16)(uintptr_t)of_id->data;
|
|
gc->of_gpio_n_cells = 2;
|
|
gc->of_node = pdev->dev.of_node;
|
|
|
|
/* This function adds a memory mapped GPIO chip */
|
|
ret = gpiochip_add_data(gc, NULL);
|
|
if (ret)
|
|
goto err0;
|
|
|
|
return 0;
|
|
err0:
|
|
iounmap(regs);
|
|
pr_err("%s: GPIO chip registration failed\n",
|
|
pdev->dev.of_node->full_name);
|
|
return ret;
|
|
};
|
|
|
|
static struct platform_driver gef_gpio_driver = {
|
|
.driver = {
|
|
.name = "gef-gpio",
|
|
.of_match_table = gef_gpio_ids,
|
|
},
|
|
};
|
|
module_platform_driver_probe(gef_gpio_driver, gef_gpio_probe);
|
|
|
|
MODULE_DESCRIPTION("GE I/O FPGA GPIO driver");
|
|
MODULE_AUTHOR("Martyn Welch <martyn.welch@ge.com");
|
|
MODULE_LICENSE("GPL");
|