1
0
Fork 0
alistair23-linux/drivers/parport
FUJITA Tomonori dfa7c4d869 parport_pc: set properly the dma_mask for parport_pc device
parport_pc_probe_port() creates the own 'parport_pc' device if the
device argument is NULL. Then parport_pc_probe_port() doesn't
initialize the dma_mask and coherent_dma_mask of the device and calls
dma_alloc_coherent with it. dma_alloc_coherent fails because
dma_alloc_coherent() doesn't accept the uninitialized dma_mask:

http://lkml.org/lkml/2009/6/16/150

Long ago, X86_32 and X86_64 had the own dma_alloc_coherent
implementations; X86_32 accepted a device having dma_mask that is not
initialized however X86_64 didn't. When we merged them, we chose to
prohibit a device having dma_mask that is not initialized. I think
that it's good to require drivers to set up dma_mask (and
coherent_dma_mask) properly if the drivers want DMA.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Reported-by: Malcom Blaney <malcolm.blaney@maptek.com.au>
Tested-by: Malcom Blaney <malcolm.blaney@maptek.com.au>
Cc: stable@kernel.org
Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-06-22 11:29:00 -07:00
..
BUGS-parport Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ChangeLog Remove Andrew Morton's old email accounts 2008-10-16 11:21:32 -07:00
Kconfig Parport driver: disable pc-style parport on Blackfin systems 2008-11-18 08:10:08 -08:00
Makefile [PATCH] AX88796 parallel port driver 2006-06-25 10:01:09 -07:00
TODO-parport Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
daisy.c [PARPORT] Remove unused 'irq' argument from parport irq functions 2007-10-23 19:53:16 -04:00
ieee1284.c parport: ieee1284: use del_timer_sync() in parport_wait_event() 2009-01-06 15:59:31 -08:00
ieee1284_ops.c parport: fix ieee1284_epp_read_addr 2008-02-08 09:22:36 -08:00
multiface.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
parport_amiga.c [PARPORT] Consolidate code copies into a single generic irq handler 2007-10-23 19:53:15 -04:00
parport_atari.c m68k: atari - Rename "mfp" to "st_mfp" 2009-02-22 09:23:02 -08:00
parport_ax88796.c parport: fix platform driver hotplug/coldplug 2008-07-25 10:53:28 -07:00
parport_cs.c parport: Use the PCI IRQ if offered 2009-04-07 08:44:06 -07:00
parport_gsc.c parport: remove driver_data direct access of struct device 2009-06-15 21:30:28 -07:00
parport_gsc.h remove the bouncing email address of David Campbell 2006-06-26 18:19:23 +02:00
parport_ip32.c [PARPORT] Consolidate code copies into a single generic irq handler 2007-10-23 19:53:15 -04:00
parport_mfc3.c [PARPORT] Kill useful 'irq' arg from parport_{generic_irq,ieee1284_interrupt} 2007-10-23 19:53:15 -04:00
parport_pc.c parport_pc: set properly the dma_mask for parport_pc device 2009-06-22 11:29:00 -07:00
parport_serial.c parport: Use the PCI IRQ if offered 2009-04-07 08:44:06 -07:00
parport_sunbpp.c sparc: Annotate of_device_id arrays with const or __initdata. 2008-08-31 01:23:17 -07:00
probe.c parport: remove CVS keywords 2008-10-16 11:21:49 -07:00
procfs.c parport/share.c: proper externs 2008-07-26 12:00:03 -07:00
share.c parport: quickfix the proc registration bug 2009-06-02 09:53:22 -07:00