alistair23-linux/fs/jbd2
Jan Kara 5559b2d81b jbd2: Drop pointless wakeup from jbd2_journal_stop()
When we drop last handle from a transaction and journal->j_barrier_count
> 0, jbd2_journal_stop() wakes up journal->j_wait_transaction_locked
wait queue. This looks pointless - wait for outstanding handles always
happens on journal->j_wait_updates waitqueue.
journal->j_wait_transaction_locked is used to wait for transaction state
changes and by start_this_handle() for waiting until
journal->j_barrier_count drops to 0. The first case is clearly
irrelevant here since only jbd2 thread changes transaction state. The
second case looks related but jbd2_journal_unlock_updates() is
responsible for the wakeup in this case. So just drop the wakeup.

Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20191105164437.32602-16-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2019-11-05 16:00:48 -05:00
..
checkpoint.c jbd2: remove repeated assignments in __jbd2_log_wait_for_space() 2019-04-06 18:14:17 -04:00
commit.c jbd2: Fix statistics for the number of logged blocks 2019-11-05 16:00:48 -05:00
journal.c jbd2: Completely fill journal descriptor blocks 2019-11-05 12:13:25 -05:00
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
recovery.c jbd2: clarify bad journal block checksum message 2018-02-18 21:33:13 -05:00
revoke.c jbd2: flush_descriptor(): Do not decrease buffer head's ref count 2019-08-11 16:29:41 -04:00
transaction.c jbd2: Drop pointless wakeup from jbd2_journal_stop() 2019-11-05 16:00:48 -05:00