![Lars-Peter Clausen](/assets/img/avatar_default.png)
All devices using a triggered buffer need to attach and detach the trigger to the device in order to properly work. Instead of doing this in each and every driver by hand move this into the core. At this point in time, all drivers should have been resolved to attach/detach the poll-function in the same order. This patch removes all explicit calls of iio_triggered_buffer_postenable() & iio_triggered_buffer_predisable() in all drivers, since the core handles now the pollfunc attach/detach. The more peculiar change is for the 'at91-sama5d2_adc' driver, since it's not immediately obvious that removing the hooks doesn't break anything. Eugen was able to test on at91-sama5d2-adc driver, sama5d2-xplained board. All seems to be fine. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Tested-by: Eugen Hristev <eugen.hristev@microchip.com> #for at91-sama5d2-adc Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
124 lines
3.3 KiB
C
124 lines
3.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2012 Analog Devices, Inc.
|
|
* Author: Lars-Peter Clausen <lars@metafoo.de>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/export.h>
|
|
#include <linux/module.h>
|
|
#include <linux/iio/iio.h>
|
|
#include <linux/iio/buffer.h>
|
|
#include <linux/iio/kfifo_buf.h>
|
|
#include <linux/iio/triggered_buffer.h>
|
|
#include <linux/iio/trigger_consumer.h>
|
|
|
|
/**
|
|
* iio_triggered_buffer_setup() - Setup triggered buffer and pollfunc
|
|
* @indio_dev: IIO device structure
|
|
* @h: Function which will be used as pollfunc top half
|
|
* @thread: Function which will be used as pollfunc bottom half
|
|
* @setup_ops: Buffer setup functions to use for this device.
|
|
* If NULL the default setup functions for triggered
|
|
* buffers will be used.
|
|
*
|
|
* This function combines some common tasks which will normally be performed
|
|
* when setting up a triggered buffer. It will allocate the buffer and the
|
|
* pollfunc.
|
|
*
|
|
* Before calling this function the indio_dev structure should already be
|
|
* completely initialized, but not yet registered. In practice this means that
|
|
* this function should be called right before iio_device_register().
|
|
*
|
|
* To free the resources allocated by this function call
|
|
* iio_triggered_buffer_cleanup().
|
|
*/
|
|
int iio_triggered_buffer_setup(struct iio_dev *indio_dev,
|
|
irqreturn_t (*h)(int irq, void *p),
|
|
irqreturn_t (*thread)(int irq, void *p),
|
|
const struct iio_buffer_setup_ops *setup_ops)
|
|
{
|
|
struct iio_buffer *buffer;
|
|
int ret;
|
|
|
|
buffer = iio_kfifo_allocate();
|
|
if (!buffer) {
|
|
ret = -ENOMEM;
|
|
goto error_ret;
|
|
}
|
|
|
|
iio_device_attach_buffer(indio_dev, buffer);
|
|
|
|
indio_dev->pollfunc = iio_alloc_pollfunc(h,
|
|
thread,
|
|
IRQF_ONESHOT,
|
|
indio_dev,
|
|
"%s_consumer%d",
|
|
indio_dev->name,
|
|
indio_dev->id);
|
|
if (indio_dev->pollfunc == NULL) {
|
|
ret = -ENOMEM;
|
|
goto error_kfifo_free;
|
|
}
|
|
|
|
/* Ring buffer functions - here trigger setup related */
|
|
indio_dev->setup_ops = setup_ops;
|
|
|
|
/* Flag that polled ring buffering is possible */
|
|
indio_dev->modes |= INDIO_BUFFER_TRIGGERED;
|
|
|
|
return 0;
|
|
|
|
error_kfifo_free:
|
|
iio_kfifo_free(indio_dev->buffer);
|
|
error_ret:
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(iio_triggered_buffer_setup);
|
|
|
|
/**
|
|
* iio_triggered_buffer_cleanup() - Free resources allocated by iio_triggered_buffer_setup()
|
|
* @indio_dev: IIO device structure
|
|
*/
|
|
void iio_triggered_buffer_cleanup(struct iio_dev *indio_dev)
|
|
{
|
|
iio_dealloc_pollfunc(indio_dev->pollfunc);
|
|
iio_kfifo_free(indio_dev->buffer);
|
|
}
|
|
EXPORT_SYMBOL(iio_triggered_buffer_cleanup);
|
|
|
|
static void devm_iio_triggered_buffer_clean(struct device *dev, void *res)
|
|
{
|
|
iio_triggered_buffer_cleanup(*(struct iio_dev **)res);
|
|
}
|
|
|
|
int devm_iio_triggered_buffer_setup(struct device *dev,
|
|
struct iio_dev *indio_dev,
|
|
irqreturn_t (*h)(int irq, void *p),
|
|
irqreturn_t (*thread)(int irq, void *p),
|
|
const struct iio_buffer_setup_ops *ops)
|
|
{
|
|
struct iio_dev **ptr;
|
|
int ret;
|
|
|
|
ptr = devres_alloc(devm_iio_triggered_buffer_clean, sizeof(*ptr),
|
|
GFP_KERNEL);
|
|
if (!ptr)
|
|
return -ENOMEM;
|
|
|
|
*ptr = indio_dev;
|
|
|
|
ret = iio_triggered_buffer_setup(indio_dev, h, thread, ops);
|
|
if (!ret)
|
|
devres_add(dev, ptr);
|
|
else
|
|
devres_free(ptr);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_setup);
|
|
|
|
MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
|
|
MODULE_DESCRIPTION("IIO helper functions for setting up triggered buffers");
|
|
MODULE_LICENSE("GPL");
|