![Jongsung Kim](/assets/img/avatar_default.png)
Using phy_drivers_register/_unregister functions is proper way to handle multiple PHY drivers registration. For Realtek PHY drivers module, it fixes incomplete current error-handlings up and adds missed unregistration for the RTL8201CP driver. Signed-off-by: Jongsung Kim <neidhard.kim@lge.com> Signed-off-by: David S. Miller <davem@davemloft.net>
124 lines
3 KiB
C
124 lines
3 KiB
C
/*
|
|
* drivers/net/phy/realtek.c
|
|
*
|
|
* Driver for Realtek PHYs
|
|
*
|
|
* Author: Johnson Leung <r58129@freescale.com>
|
|
*
|
|
* Copyright (c) 2004 Freescale Semiconductor, Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
*/
|
|
#include <linux/phy.h>
|
|
#include <linux/module.h>
|
|
|
|
#define RTL821x_PHYSR 0x11
|
|
#define RTL821x_PHYSR_DUPLEX 0x2000
|
|
#define RTL821x_PHYSR_SPEED 0xc000
|
|
#define RTL821x_INER 0x12
|
|
#define RTL821x_INER_INIT 0x6400
|
|
#define RTL821x_INSR 0x13
|
|
|
|
#define RTL8211E_INER_LINK_STATUS 0x400
|
|
|
|
MODULE_DESCRIPTION("Realtek PHY driver");
|
|
MODULE_AUTHOR("Johnson Leung");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
static int rtl821x_ack_interrupt(struct phy_device *phydev)
|
|
{
|
|
int err;
|
|
|
|
err = phy_read(phydev, RTL821x_INSR);
|
|
|
|
return (err < 0) ? err : 0;
|
|
}
|
|
|
|
static int rtl8211b_config_intr(struct phy_device *phydev)
|
|
{
|
|
int err;
|
|
|
|
if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
|
|
err = phy_write(phydev, RTL821x_INER,
|
|
RTL821x_INER_INIT);
|
|
else
|
|
err = phy_write(phydev, RTL821x_INER, 0);
|
|
|
|
return err;
|
|
}
|
|
|
|
static int rtl8211e_config_intr(struct phy_device *phydev)
|
|
{
|
|
int err;
|
|
|
|
if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
|
|
err = phy_write(phydev, RTL821x_INER,
|
|
RTL8211E_INER_LINK_STATUS);
|
|
else
|
|
err = phy_write(phydev, RTL821x_INER, 0);
|
|
|
|
return err;
|
|
}
|
|
|
|
static struct phy_driver realtek_drvs[] = {
|
|
{
|
|
.phy_id = 0x00008201,
|
|
.name = "RTL8201CP Ethernet",
|
|
.phy_id_mask = 0x0000ffff,
|
|
.features = PHY_BASIC_FEATURES,
|
|
.flags = PHY_HAS_INTERRUPT,
|
|
.config_aneg = &genphy_config_aneg,
|
|
.read_status = &genphy_read_status,
|
|
.driver = { .owner = THIS_MODULE,},
|
|
}, {
|
|
.phy_id = 0x001cc912,
|
|
.name = "RTL8211B Gigabit Ethernet",
|
|
.phy_id_mask = 0x001fffff,
|
|
.features = PHY_GBIT_FEATURES,
|
|
.flags = PHY_HAS_INTERRUPT,
|
|
.config_aneg = &genphy_config_aneg,
|
|
.read_status = &genphy_read_status,
|
|
.ack_interrupt = &rtl821x_ack_interrupt,
|
|
.config_intr = &rtl8211b_config_intr,
|
|
.driver = { .owner = THIS_MODULE,},
|
|
}, {
|
|
.phy_id = 0x001cc915,
|
|
.name = "RTL8211E Gigabit Ethernet",
|
|
.phy_id_mask = 0x001fffff,
|
|
.features = PHY_GBIT_FEATURES,
|
|
.flags = PHY_HAS_INTERRUPT,
|
|
.config_aneg = &genphy_config_aneg,
|
|
.read_status = &genphy_read_status,
|
|
.ack_interrupt = &rtl821x_ack_interrupt,
|
|
.config_intr = &rtl8211e_config_intr,
|
|
.suspend = genphy_suspend,
|
|
.resume = genphy_resume,
|
|
.driver = { .owner = THIS_MODULE,},
|
|
},
|
|
};
|
|
|
|
static int __init realtek_init(void)
|
|
{
|
|
return phy_drivers_register(realtek_drvs, ARRAY_SIZE(realtek_drvs));
|
|
}
|
|
|
|
static void __exit realtek_exit(void)
|
|
{
|
|
phy_drivers_unregister(realtek_drvs, ARRAY_SIZE(realtek_drvs));
|
|
}
|
|
|
|
module_init(realtek_init);
|
|
module_exit(realtek_exit);
|
|
|
|
static struct mdio_device_id __maybe_unused realtek_tbl[] = {
|
|
{ 0x001cc912, 0x001fffff },
|
|
{ 0x001cc915, 0x001fffff },
|
|
{ }
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(mdio, realtek_tbl);
|