![Takashi Iwai](/assets/img/avatar_default.png)
The calls of snd_info_register() are superfluous and should be avoided at the procfs creation time. They are called at the end of the whole initialization via snd_card_register(). This patch drops such superfluous calls. Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de>
111 lines
3.3 KiB
C
111 lines
3.3 KiB
C
/*
|
|
* motu-proc.c - a part of driver for MOTU FireWire series
|
|
*
|
|
* Copyright (c) 2015-2017 Takashi Sakamoto <o-takashi@sakamocchi.jp>
|
|
*
|
|
* Licensed under the terms of the GNU General Public License, version 2.
|
|
*/
|
|
|
|
#include "./motu.h"
|
|
|
|
static const char *const clock_names[] = {
|
|
[SND_MOTU_CLOCK_SOURCE_INTERNAL] = "Internal",
|
|
[SND_MOTU_CLOCK_SOURCE_ADAT_ON_DSUB] = "ADAT on Dsub-9pin interface",
|
|
[SND_MOTU_CLOCK_SOURCE_ADAT_ON_OPT] = "ADAT on optical interface",
|
|
[SND_MOTU_CLOCK_SOURCE_ADAT_ON_OPT_A] = "ADAT on optical interface A",
|
|
[SND_MOTU_CLOCK_SOURCE_ADAT_ON_OPT_B] = "ADAT on optical interface B",
|
|
[SND_MOTU_CLOCK_SOURCE_SPDIF_ON_OPT] = "S/PDIF on optical interface",
|
|
[SND_MOTU_CLOCK_SOURCE_SPDIF_ON_OPT_A] = "S/PDIF on optical interface A",
|
|
[SND_MOTU_CLOCK_SOURCE_SPDIF_ON_OPT_B] = "S/PDIF on optical interface B",
|
|
[SND_MOTU_CLOCK_SOURCE_SPDIF_ON_COAX] = "S/PCIF on coaxial interface",
|
|
[SND_MOTU_CLOCK_SOURCE_AESEBU_ON_XLR] = "AESEBU on XLR interface",
|
|
[SND_MOTU_CLOCK_SOURCE_WORD_ON_BNC] = "Word clock on BNC interface",
|
|
};
|
|
|
|
static void proc_read_clock(struct snd_info_entry *entry,
|
|
struct snd_info_buffer *buffer)
|
|
{
|
|
|
|
struct snd_motu *motu = entry->private_data;
|
|
const struct snd_motu_protocol *const protocol = motu->spec->protocol;
|
|
unsigned int rate;
|
|
enum snd_motu_clock_source source;
|
|
|
|
if (protocol->get_clock_rate(motu, &rate) < 0)
|
|
return;
|
|
if (protocol->get_clock_source(motu, &source) < 0)
|
|
return;
|
|
|
|
snd_iprintf(buffer, "Rate:\t%d\n", rate);
|
|
snd_iprintf(buffer, "Source:\t%s\n", clock_names[source]);
|
|
}
|
|
|
|
static void proc_read_format(struct snd_info_entry *entry,
|
|
struct snd_info_buffer *buffer)
|
|
{
|
|
struct snd_motu *motu = entry->private_data;
|
|
const struct snd_motu_protocol *const protocol = motu->spec->protocol;
|
|
unsigned int mode;
|
|
struct snd_motu_packet_format *formats;
|
|
int i;
|
|
|
|
if (protocol->cache_packet_formats(motu) < 0)
|
|
return;
|
|
|
|
snd_iprintf(buffer, "tx:\tmsg\tfixed\tdiffered\n");
|
|
for (i = 0; i < SND_MOTU_CLOCK_RATE_COUNT; ++i) {
|
|
mode = i >> 1;
|
|
|
|
formats = &motu->tx_packet_formats;
|
|
snd_iprintf(buffer,
|
|
"%u:\t%u\t%u\t%u\n",
|
|
snd_motu_clock_rates[i],
|
|
formats->msg_chunks,
|
|
formats->fixed_part_pcm_chunks[mode],
|
|
formats->differed_part_pcm_chunks[mode]);
|
|
}
|
|
|
|
snd_iprintf(buffer, "rx:\tmsg\tfixed\tdiffered\n");
|
|
for (i = 0; i < SND_MOTU_CLOCK_RATE_COUNT; ++i) {
|
|
mode = i >> 1;
|
|
|
|
formats = &motu->rx_packet_formats;
|
|
snd_iprintf(buffer,
|
|
"%u:\t%u\t%u\t%u\n",
|
|
snd_motu_clock_rates[i],
|
|
formats->msg_chunks,
|
|
formats->fixed_part_pcm_chunks[mode],
|
|
formats->differed_part_pcm_chunks[mode]);
|
|
}
|
|
}
|
|
|
|
static void add_node(struct snd_motu *motu, struct snd_info_entry *root,
|
|
const char *name,
|
|
void (*op)(struct snd_info_entry *e,
|
|
struct snd_info_buffer *b))
|
|
{
|
|
struct snd_info_entry *entry;
|
|
|
|
entry = snd_info_create_card_entry(motu->card, name, root);
|
|
if (entry)
|
|
snd_info_set_text_ops(entry, motu, op);
|
|
}
|
|
|
|
void snd_motu_proc_init(struct snd_motu *motu)
|
|
{
|
|
struct snd_info_entry *root;
|
|
|
|
/*
|
|
* All nodes are automatically removed at snd_card_disconnect(),
|
|
* by following to link list.
|
|
*/
|
|
root = snd_info_create_card_entry(motu->card, "firewire",
|
|
motu->card->proc_root);
|
|
if (root == NULL)
|
|
return;
|
|
root->mode = S_IFDIR | 0555;
|
|
|
|
add_node(motu, root, "clock", proc_read_clock);
|
|
add_node(motu, root, "format", proc_read_format);
|
|
}
|