Zenghui Yu 6276d38cce KVM: arm64: vgic-v3: Drop the reporting of GICR_TYPER.Last for userspace ... commit 23bde34771 upstream. It was recently reported that if GICR_TYPER is accessed before the RD base address is set, we'll suffer from the unset @rdreg dereferencing. Oops... gpa_t last_rdist_typer = rdreg->base + GICR_TYPER + (rdreg->free_index - 1) * KVM_VGIC_V3_REDIST_SIZE; It's "expected" that users will access registers in the redistributor if the RD has been properly configured (e.g., the RD base address is set). But it hasn't yet been covered by the existing documentation. Per discussion on the list [1], the reporting of the GICR_TYPER.Last bit for userspace never actually worked. And it's difficult for us to emulate it correctly given that userspace has the flexibility to access it any time. Let's just drop the reporting of the Last bit for userspace for now (userspace should have full knowledge about it anyway) and it at least prevents kernel from panic ;-) [1] https://lore.kernel.org/kvmarm/c20865a267e44d1e2c0d52ce4e012263@kernel.org/ Fixes: ba7b3f1275 ("KVM: arm/arm64: Revisit Redistributor TYPER last bit computation") Reported-by: Keqian Zhu <zhukeqian1@huawei.com> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Reviewed-by: Eric Auger <eric.auger@redhat.com> Link: https://lore.kernel.org/r/20201117151629.1738-1-yuzenghui@huawei.com Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-12-02 08:49:46 +01:00
..
trace.h	KVM: arm/arm64: vgic: Use the appropriate TRACE_INCLUDE_PATH	2019-09-11 16:36:19 +01:00
vgic-debug.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234	2019-06-19 17:09:07 +02:00
vgic-init.c	KVM: arm64: vgic-v3: Retire all pending LPIs on vcpu destroy	2020-10-01 13:17:56 +02:00
vgic-irqfd.c	KVM: arm/arm64: vgic-irqfd: Implement kvm_arch_set_irq_inatomic	2019-08-18 18:38:54 +01:00
vgic-its.c	KVM: arm64: vgic-its: Fix memory leak on the error path of vgic_add_lpi()	2020-10-01 13:17:56 +02:00
vgic-kvm-device.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
vgic-mmio-v2.c	KVM: arm: vgic: Synchronize the whole guest on GIC{D,R}_I{S,C}ACTIVER read	2020-05-20 08:20:04 +02:00
vgic-mmio-v3.c	KVM: arm64: vgic-v3: Drop the reporting of GICR_TYPER.Last for userspace	2020-12-02 08:49:46 +01:00
vgic-mmio.c	KVM: arm: vgic: Synchronize the whole guest on GIC{D,R}_I{S,C}ACTIVER read	2020-05-20 08:20:04 +02:00
vgic-mmio.h	KVM: arm: vgic: Synchronize the whole guest on GIC{D,R}_I{S,C}ACTIVER read	2020-05-20 08:20:04 +02:00
vgic-v2.c	* s390: ioctl hardening, selftests	2019-09-18 09:49:13 -07:00
vgic-v3.c	KVM: arm/arm64: vgic: Don't rely on the wrong pending table	2019-12-13 08:43:00 +01:00
vgic-v4.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234	2019-06-19 17:09:07 +02:00
vgic.c	* s390: ioctl hardening, selftests	2019-09-18 09:49:13 -07:00
vgic.h	KVM: arm/arm64: vgic-its: Check the LPI translation cache on MSI injection	2019-08-18 18:38:53 +01:00