1
0
Fork 0
alistair23-linux/drivers/video/fbdev/sis
Nathan Chancellor 864eb1afc6 video: fbdev: sis: Remove unnecessary parentheses and commented code
Clang warns when multiple pairs of parentheses are used for a single
conditional statement.

drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparison
with extraneous parentheses [-Wparentheses-equality]
      } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
                 ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/video/fbdev/sis/init301.c:851:42: note: remove extraneous
parentheses around the comparison to silence this warning
      } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
                ~                        ^   ~
drivers/video/fbdev/sis/init301.c:851:42: note: use '=' to turn this
equality comparison into an assignment
      } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
                                         ^~
                                         =
1 warning generated.

Remove the parentheses and while we're at it, clean up the commented
code, which has been here since the beginning of git history.

Link: https://github.com/ClangBuiltLinux/linux/issues/118
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
2018-10-08 12:57:36 +02:00
..
300vtbl.h
310vtbl.h
Makefile
init.c drivers/video/fbdev/sis: Add missing else 2014-07-01 13:32:31 +03:00
init.h video: fbdev: sis: avoid mismatched prototypes 2018-03-12 17:06:52 +01:00
init301.c video: fbdev: sis: Remove unnecessary parentheses and commented code 2018-10-08 12:57:36 +02:00
init301.h video: fbdev: sis: avoid mismatched prototypes 2018-03-12 17:06:52 +01:00
initdef.h
initextlfb.c
oem300.h
oem310.h
sis.h video: fbdev: sis: avoid mismatched prototypes 2018-03-12 17:06:52 +01:00
sis_accel.c
sis_accel.h
sis_main.c video: fbdev: sis: avoid mismatched prototypes 2018-03-12 17:06:52 +01:00
sis_main.h video: fbdev: sis: avoid mismatched prototypes 2018-03-12 17:06:52 +01:00
vgatypes.h
vstruct.h