1
0
Fork 0
alistair23-linux/drivers/net/appletalk
Colin Ian King bd437c99cf drivers/net: appletalk/cops: remove redundant if statement and mask
The two different assignments for pkt_len are actually the same and
so the if statement is redundant and can be removed.  Masking a u8
return value from inb() with 0xFF is also redundant and can also be
emoved.

Similarly, the two different outb calls are identical as the mask
of 0xff on the second outb is redundant since a u8 is being written,
so the if statement is also redundant and can be also removed.

Detected by CoverityScan, CID#1475639 ("Identical code for different
branches")

V2: Remove the if statement for the outb calls, thanks to David
Miller for spotting this.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-12-24 14:48:26 -08:00
..
Kconfig net/appletalk: LTPC needs virt_to_bus 2015-02-20 16:28:46 -05:00
Makefile
cops.c drivers/net: appletalk/cops: remove redundant if statement and mask 2018-12-24 14:48:26 -08:00
cops.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
cops_ffdrv.h
cops_ltdrv.h
ipddp.c net/appletalk: fix minor pointer leak to userspace in SIOCFINDIPDDPRT 2018-09-13 10:35:57 -07:00
ipddp.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ltpc.c drivers/net/appletalk: Convert timers to use timer_setup() 2017-10-18 12:39:55 +01:00
ltpc.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00