457c005aaf
Update the driver's HCI structs and associated endian-converter functions with new driver-specific bitwise types. The new types encourage correct endian-handling within the driver by triggering sparse warnings when mixing with other types. The driver's endian-converters provide correct and warning-free conversions. Driver-specific bitwise types are used instead of the standard endian-specific types because the attached device can be of either endian. This is also why the driver has its own endian-conversion functions, which consider endianness of both the cpu and the attached device. Introducing the new types to the converters fixes the sparse warnings: CHECK drivers/staging/gdm724x/gdm_endian.c drivers/staging/gdm724x/gdm_endian.c:28:24: warning: incorrect type in return expression (different base types) drivers/staging/gdm724x/gdm_endian.c:28:24: expected unsigned short drivers/staging/gdm724x/gdm_endian.c:28:24: got restricted __le16 [usertype] <noident> drivers/staging/gdm724x/gdm_endian.c:30:24: warning: incorrect type in return expression (different base types) drivers/staging/gdm724x/gdm_endian.c:30:24: expected unsigned short drivers/staging/gdm724x/gdm_endian.c:30:24: got restricted __be16 [usertype] <noident> drivers/staging/gdm724x/gdm_endian.c:36:24: warning: cast to restricted __le16 drivers/staging/gdm724x/gdm_endian.c:38:24: warning: cast to restricted __be16 drivers/staging/gdm724x/gdm_endian.c:44:24: warning: incorrect type in return expression (different base types) drivers/staging/gdm724x/gdm_endian.c:44:24: expected unsigned int drivers/staging/gdm724x/gdm_endian.c:44:24: got restricted __le32 [usertype] <noident> drivers/staging/gdm724x/gdm_endian.c:46:24: warning: incorrect type in return expression (different base types) drivers/staging/gdm724x/gdm_endian.c:46:24: expected unsigned int drivers/staging/gdm724x/gdm_endian.c:46:24: got restricted __be32 [usertype] <noident> drivers/staging/gdm724x/gdm_endian.c:52:24: warning: cast to restricted __le32 drivers/staging/gdm724x/gdm_endian.c:54:24: warning: cast to restricted __be32 Signed-off-by: Eric S. Stone <esstone@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
56 lines
1.5 KiB
C
56 lines
1.5 KiB
C
/*
|
|
* Copyright (c) 2012 GCT Semiconductor, Inc. All rights reserved.
|
|
*
|
|
* This software is licensed under the terms of the GNU General Public
|
|
* License version 2, as published by the Free Software Foundation, and
|
|
* may be copied, distributed, and modified under those terms.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include "gdm_endian.h"
|
|
|
|
void gdm_set_endian(struct gdm_endian *ed, u8 dev_endian)
|
|
{
|
|
if (dev_endian == ENDIANNESS_BIG)
|
|
ed->dev_ed = ENDIANNESS_BIG;
|
|
else
|
|
ed->dev_ed = ENDIANNESS_LITTLE;
|
|
}
|
|
|
|
__dev16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
|
|
{
|
|
if (ed->dev_ed == ENDIANNESS_LITTLE)
|
|
return (__force __dev16)cpu_to_le16(x);
|
|
else
|
|
return (__force __dev16)cpu_to_be16(x);
|
|
}
|
|
|
|
u16 gdm_dev16_to_cpu(struct gdm_endian *ed, __dev16 x)
|
|
{
|
|
if (ed->dev_ed == ENDIANNESS_LITTLE)
|
|
return le16_to_cpu((__force __le16)x);
|
|
else
|
|
return be16_to_cpu((__force __be16)x);
|
|
}
|
|
|
|
__dev32 gdm_cpu_to_dev32(struct gdm_endian *ed, u32 x)
|
|
{
|
|
if (ed->dev_ed == ENDIANNESS_LITTLE)
|
|
return (__force __dev32)cpu_to_le32(x);
|
|
else
|
|
return (__force __dev32)cpu_to_be32(x);
|
|
}
|
|
|
|
u32 gdm_dev32_to_cpu(struct gdm_endian *ed, __dev32 x)
|
|
{
|
|
if (ed->dev_ed == ENDIANNESS_LITTLE)
|
|
return le32_to_cpu((__force __le32)x);
|
|
else
|
|
return be32_to_cpu((__force __be32)x);
|
|
}
|