Sricharan R 685983f4de i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled ... With CONFIG_DEBUG_SG is enabled and when dma mode is used, below dump is seen, ------------[ cut here ]------------ kernel BUG at include/linux/scatterlist.h:140! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.4.0-00459-g9f087b9-dirty #7 Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) task: ffffffc036868000 ti: ffffffc036870000 task.ti: ffffffc036870000 PC is at qup_sg_set_buf.isra.13+0x138/0x154 LR is at qup_sg_set_buf.isra.13+0x50/0x154 pc : [<ffffffc0005a0ed8>] lr : [<ffffffc0005a0df0>] pstate: 60000145 sp : ffffffc0368735c0 x29: ffffffc0368735c0 x28: ffffffc036873752 x27: ffffffc035233018 x26: ffffffc000c4e000 x25: 0000000000000000 x24: 0000000000000004 x23: 0000000000000000 x22: ffffffc035233668 x21: ffffff80004e3000 x20: ffffffc0352e0018 x19: 0000004000000000 x18: 0000000000000028 x17: 0000000000000004 x16: ffffffc0017a39c8 x15: 0000000000001cdf x14: ffffffc0019929d8 x13: ffffffc0352e0018 x12: 0000000000000000 x11: 0000000000000001 x10: 0000000000000001 x9 : ffffffc0012b2d70 x8 : ffffff80004e3000 x7 : 0000000000000018 x6 : 0000000030000000 x5 : ffffffc00199f018 x4 : ffffffc035233018 x3 : 0000000000000004 x2 : 00000000c0000000 x1 : 0000000000000003 x0 : 0000000000000000 Process swapper/0 (pid: 1, stack limit = 0xffffffc036870020) Stack: (0xffffffc0368735c0 to 0xffffffc036874000) sg_set_bug expects that the buf parameter passed in should be from lowmem and a valid pageframe. This is not true for pages from dma_alloc_coherent which can be carveouts, hence the check fails. Change allocation of sg buffers from dma_coherent memory to kzalloc to fix the issue. Note that now dma_map/unmap is used to make the kzalloc'ed buffers coherent before passing it to the dmaengine. Signed-off-by: Sricharan R <sricharan@codeaurora.org> Reviewed-by: Andy Gross <andy.gross@linaro.org> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>		2016-06-18 18:15:52 +02:00
..
algos	i2c: algo-bit: declare i2c_bit_quirk_no_clk_stretch as static	2016-05-11 17:16:30 +02:00
busses	i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled	2016-06-18 18:15:52 +02:00
muxes	i2c: mux: reg: Provide of_match_table	2016-06-09 22:38:16 +02:00
i2c-boardinfo.c	i2c: i2c-boardinfo: sort includes	2016-02-20 23:33:38 +01:00
i2c-core.c	i2c: Add generic support passing secondary devices addresses	2016-06-13 22:32:09 +02:00
i2c-core.h
i2c-dev.c	i2c: dev: use after free in detach	2016-05-28 17:37:42 +02:00
i2c-mux.c	i2c: mux: relax locking of the top i2c adapter during mux-locked muxing	2016-05-04 22:39:17 +02:00
i2c-slave-eeprom.c	i2c: Drop owner assignment from i2c_driver	2015-08-10 08:37:35 +02:00
i2c-smbus.c	i2c: smbus: add SMBus Host Notify support	2016-06-17 13:24:05 +02:00
i2c-stub.c	i2c: i2c-stub: sort includes	2016-02-20 23:33:39 +01:00
Kconfig	kconfig: use bool instead of boolean for type definition attributes	2015-01-07 13:08:04 +01:00
Makefile