alistair23-linux/drivers/net/netxen
Stanislaw Gruszka 673e63c688 net: fix ethtool->set_flags not intended -EINVAL return value
After commit d5dbda2380 "ethtool: Add
support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
acceleration via ethtool set_flags, always return -EINVAL from that
function. Fix by returning -EINVAL only if requested features do not
match current settings and can not be changed by driver.

Change any driver that define ethtool->set_flags to use
ethtool_invalid_flags() to avoid similar problems in the future
(also on drivers that do not have the problem).

Tested with modified (to reproduce this bug) myri10ge driver.

Cc: stable@kernel.org # 2.6.37+
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2011-03-27 23:35:24 -07:00
..
Makefile netxen: fix license header 2010-01-15 01:37:25 -08:00
netxen_nic.h netxen: support for GbE port settings 2011-03-15 14:54:55 -07:00
netxen_nic_ctx.c netxen: support for GbE port settings 2011-03-15 14:54:55 -07:00
netxen_nic_ethtool.c net: fix ethtool->set_flags not intended -EINVAL return value 2011-03-27 23:35:24 -07:00
netxen_nic_hdr.h netxen: remove unnecessary size checks 2010-05-12 23:02:30 -07:00
netxen_nic_hw.c netxen: enable LRO based on NETIF_F_LRO 2011-01-03 11:56:18 -08:00
netxen_nic_hw.h netxen: fix license header 2010-01-15 01:37:25 -08:00
netxen_nic_init.c netxen: remove unnecessary [kv][mcz]alloc casts 2010-11-28 17:26:22 -08:00
netxen_nic_main.c netxen: Notify firmware of Flex-10 interface down 2011-03-14 15:12:19 -07:00