redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity
alistair23-linux/drivers/media/tuners
History
Gustavo A. R. Silva 6ad33dec83 media: tuners: remove unnecessary static in simple_dvb_configure() 
Remove unnecessary static on local variable t_params.
Such variable is initialized before being used,
on every execution path throughout the function.
The static has no benefit and, removing it reduces
the code size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;

In the following log you can see the difference in the code size. Also,
there is a significant difference in the bss segment. This log is the
output of the size command, before and after the code change:

before:
   text    data     bss     dec     hex filename
  23314    3640     832   27786    6c8a drivers/media/tuners/tuner-simple.o

after:
   text    data     bss     dec     hex filename
  23257    3552     768   27577    6bb9 drivers/media/tuners/tuner-simple.o

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2017-07-19 15:02:27 -04:00
..
e4000.c
e4000.h
e4000_priv.h
fc001x-common.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0011.c media: tw5864, fc0011: better handle WARN_ON() 2017-06-24 16:19:27 -03:00
fc0011.h
fc0012-priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0012.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0012.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0013-priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0013.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0013.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc2580.c
fc2580.h
fc2580_priv.h
it913x.c [media] it913x: add chip device ids for binding 2017-01-31 10:50:34 -02:00
it913x.h [media] it913x: add chip device ids for binding 2017-01-31 10:50:34 -02:00
Kconfig
m88rs6000t.c
m88rs6000t.h
Makefile
max2165.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
max2165.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
max2165_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mc44s803.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mc44s803.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mc44s803_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
msi001.c
mt20xx.c Revert "[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations" 2016-11-18 20:44:33 -02:00
mt20xx.h
mt2060.c [media] mt2060: implement sleep 2017-02-03 06:55:46 -02:00
mt2060.h [media] mt2060: add param to split long i2c writes 2017-02-03 06:44:03 -02:00
mt2060_priv.h [media] mt2060: implement sleep 2017-02-03 06:55:46 -02:00
mt2063.c [media] dvb_frontend: tuner_ops.release returns void 2016-11-18 15:07:26 -02:00
mt2063.h
mt2131.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mt2131.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mt2131_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mt2266.c Revert "[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations" 2016-11-18 20:44:33 -02:00
mt2266.h
mxl301rf.c
mxl301rf.h
mxl5005s.c media: tuners: mxl5005s: remove useless variable assignments 2017-06-24 15:29:33 -03:00
mxl5005s.h
mxl5007t.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mxl5007t.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
qm1d1c0042.c
qm1d1c0042.h
qt1010.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
qt1010.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
qt1010_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
r820t.c [media] dvb_frontend: tuner_ops.release returns void 2016-11-18 15:07:26 -02:00
r820t.h
si2157.c [media] si2157: Add support for Si2141-A10 2017-04-14 22:27:47 -03:00
si2157.h
si2157_priv.h [media] si2157: Add support for Si2141-A10 2017-04-14 22:27:47 -03:00
tda827x.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tda827x.h
tda8290.c
tda8290.h
tda9887.c
tda9887.h
tda18212.c
tda18212.h
tda18218.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tda18218.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tda18218_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tda18271-common.c
tda18271-fe.c [media] media drivers: annotate fall-through 2017-05-19 07:10:03 -03:00
tda18271-maps.c
tda18271-priv.h
tda18271.h
tea5761.c Revert "[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations" 2016-11-18 20:44:33 -02:00
tea5761.h
tea5767.c Revert "[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations" 2016-11-18 20:44:33 -02:00
tea5767.h
tua9001.c
tua9001.h
tua9001_priv.h
tuner-i2c.h
tuner-simple.c media: tuners: remove unnecessary static in simple_dvb_configure() 2017-07-19 15:02:27 -04:00
tuner-simple.h
tuner-types.c
tuner-xc2028-types.h
tuner-xc2028.c Merge branch 'patchwork' into v4l_for_linus 2016-12-15 08:38:35 -02:00
tuner-xc2028.h
xc4000.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
xc4000.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
xc5000.c [media] xc5000: Don't spin waiting for analog lock 2017-06-06 07:51:05 -03:00
xc5000.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00