![Kirill Smelkov](/assets/img/avatar_default.png)
Using scripts/coccinelle/api/stream_open.cocci added in10dce8af34
("fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock"), search and convert to stream_open all in-kernel nonseekable_open users for which read and write actually do not depend on ppos and where there is no other methods in file_operations which assume @offset access. I've verified each generated change manually - that it is correct to convert - and each other nonseekable_open instance left - that it is either not correct to convert there, or that it is not converted due to current stream_open.cocci limitations. The script also does not convert files that should be valid to convert, but that currently have .llseek = noop_llseek or generic_file_llseek for unknown reason despite file being opened with nonseekable_open (e.g. drivers/input/mousedev.c) Among cases converted 14 were potentially vulnerable to read vs write deadlock (see details in10dce8af34
): drivers/char/pcmcia/cm4000_cs.c:1685:7-23: ERROR: cm4000_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/gnss/core.c:45:1-17: ERROR: gnss_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/hid/uhid.c:635:1-17: ERROR: uhid_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/infiniband/core/user_mad.c:988:1-17: ERROR: umad_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/evdev.c:527:1-17: ERROR: evdev_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/misc/uinput.c:401:1-17: ERROR: uinput_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/isdn/capi/capi.c:963:8-24: ERROR: capi_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/leds/uleds.c:77:1-17: ERROR: uleds_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/media/rc/lirc_dev.c:198:1-17: ERROR: lirc_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/s390/char/fs3270.c:488:1-17: ERROR: fs3270_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/usb/misc/ldusb.c:310:1-17: ERROR: ld_usb_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/xen/evtchn.c:667:8-24: ERROR: evtchn_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/batman-adv/icmp_socket.c:80:1-17: ERROR: batadv_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/rfkill/core.c:1146:8-24: ERROR: rfkill_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. and the rest were just safe to convert to stream_open because their read and write do not use ppos at all and corresponding file_operations do not have methods that assume @offset file access(*): arch/powerpc/platforms/52xx/mpc52xx_gpt.c:631:8-24: WARNING: mpc52xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/um/drivers/harddog_kern.c:88:8-24: WARNING: harddog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/x86/kernel/cpu/microcode/core.c:430:33-49: WARNING: microcode_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ds1620.c:215:8-24: WARNING: ds1620_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/dtlk.c:301:1-17: WARNING: dtlk_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ipmi/ipmi_watchdog.c:840:9-25: WARNING: ipmi_wdog_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/pcmcia/scr24x_cs.c:95:8-24: WARNING: scr24x_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/tb0219.c:246:9-25: WARNING: tb0219_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/firewire/nosy.c:306:8-24: WARNING: nosy_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/fschmd.c:840:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/w83793.c:1344:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucma.c:1747:8-24: WARNING: ucma_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucm.c:1178:8-24: WARNING: ucm_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/uverbs_main.c:1086:8-24: WARNING: uverbs_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/input/joydev.c:282:1-17: WARNING: joydev_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/pci/switch/switchtec.c:393:1-17: WARNING: switchtec_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/platform/chrome/cros_ec_debugfs.c:135:8-24: WARNING: cros_ec_console_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-ds1374.c:470:9-25: WARNING: ds1374_wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-m41t80.c:805:9-25: WARNING: wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/tape_char.c:293:2-18: WARNING: tape_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/zcore.c:194:8-24: WARNING: zcore_reipl_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/crypto/zcrypt_api.c:528:8-24: WARNING: zcrypt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/spi/spidev.c:594:1-17: WARNING: spidev_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/staging/pi433/pi433_if.c:974:1-17: WARNING: pi433_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/acquirewdt.c:203:8-24: WARNING: acq_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/advantechwdt.c:202:8-24: WARNING: advwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim1535_wdt.c:252:8-24: WARNING: ali_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim7101_wdt.c:217:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ar7_wdt.c:166:8-24: WARNING: ar7_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/at91rm9200_wdt.c:113:8-24: WARNING: at91wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ath79_wdt.c:135:8-24: WARNING: ath79_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/bcm63xx_wdt.c:119:8-24: WARNING: bcm63xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpu5wdt.c:143:8-24: WARNING: cpu5wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpwd.c:397:8-24: WARNING: cpwd_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/eurotechwdt.c:319:8-24: WARNING: eurwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/f71808e_wdt.c:528:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/gef_wdt.c:232:8-24: WARNING: gef_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/geodewdt.c:95:8-24: WARNING: geodewdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ib700wdt.c:241:8-24: WARNING: ibwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ibmasr.c:326:8-24: WARNING: asr_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/indydog.c:80:8-24: WARNING: indydog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/intel_scu_watchdog.c:307:8-24: WARNING: intel_scu_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/iop_wdt.c:104:8-24: WARNING: iop_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/it8712f_wdt.c:330:8-24: WARNING: it8712f_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ixp4xx_wdt.c:68:8-24: WARNING: ixp4xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ks8695_wdt.c:145:8-24: WARNING: ks8695wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/m54xx_wdt.c:88:8-24: WARNING: m54xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/machzwd.c:336:8-24: WARNING: zf_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mixcomwd.c:153:8-24: WARNING: mixcomwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mtx-1_wdt.c:121:8-24: WARNING: mtx1_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mv64x60_wdt.c:136:8-24: WARNING: mv64x60_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nuc900_wdt.c:134:8-24: WARNING: nuc900wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nv_tco.c:164:8-24: WARNING: nv_tco_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pc87413_wdt.c:289:8-24: WARNING: pc87413_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:698:8-24: WARNING: pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:737:8-24: WARNING: pcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:581:8-24: WARNING: pcipcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:623:8-24: WARNING: pcipcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:488:8-24: WARNING: usb_pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:527:8-24: WARNING: usb_pcwd_temperature_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pika_wdt.c:121:8-24: WARNING: pikawdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pnx833x_wdt.c:119:8-24: WARNING: pnx833x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rc32434_wdt.c:153:8-24: WARNING: rc32434_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rdc321x_wdt.c:145:8-24: WARNING: rdc321x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/riowd.c:79:1-17: WARNING: riowd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sa1100_wdt.c:62:8-24: WARNING: sa1100dog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc60xxwdt.c:211:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc7240_wdt.c:139:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc8360.c:274:8-24: WARNING: sbc8360_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_epx_c3.c:81:8-24: WARNING: epx_c3_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_fitpc2_wdt.c:78:8-24: WARNING: fitpc2_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sb_wdog.c:108:1-17: WARNING: sbwdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc1200wdt.c:181:8-24: WARNING: sc1200wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc520_wdt.c:261:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sch311x_wdt.c:319:8-24: WARNING: sch311x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/scx200_wdt.c:105:8-24: WARNING: scx200_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/smsc37b787_wdt.c:369:8-24: WARNING: wb_smsc_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83877f_wdt.c:227:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83977f_wdt.c:301:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wafer5823wdt.c:200:8-24: WARNING: wafwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/watchdog_dev.c:828:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:379:8-24: WARNING: wdrtas_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:445:8-24: WARNING: wdrtas_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt285.c:104:1-17: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt977.c:276:8-24: WARNING: wdt977_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:424:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:484:8-24: WARNING: wdt_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:464:8-24: WARNING: wdtpci_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:527:8-24: WARNING: wdtpci_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. net/batman-adv/log.c:105:1-17: WARNING: batadv_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/control.c:57:7-23: WARNING: snd_ctl_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/rawmidi.c:385:7-23: WARNING: snd_rawmidi_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/seq/seq_clientmgr.c:310:7-23: WARNING: snd_seq_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/timer.c:1428:7-23: WARNING: snd_timer_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. One can also recheck/review the patch via generating it with explanation comments included via $ make coccicheck MODE=patch COCCI=scripts/coccinelle/api/stream_open.cocci SPFLAGS="-D explain" (*) This second group also contains cases with read/write deadlocks that stream_open.cocci don't yet detect, but which are still valid to convert to stream_open since ppos is not used. For example drivers/pci/switch/switchtec.c calls wait_for_completion_interruptible() in its .read, but stream_open.cocci currently detects only "wait_event*" as blocking. Cc: Michael Kerrisk <mtk.manpages@gmail.com> Cc: Yongzhi Pan <panyongzhi@gmail.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: David Vrabel <david.vrabel@citrix.com> Cc: Juergen Gross <jgross@suse.com> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: Tejun Heo <tj@kernel.org> Cc: Kirill Tkhai <ktkhai@virtuozzo.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Christoph Hellwig <hch@lst.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Nikolaus Rath <Nikolaus@rath.org> Cc: Han-Wen Nienhuys <hanwen@google.com> Cc: Anatolij Gustschin <agust@denx.de> Cc: Jeff Dike <jdike@addtoit.com> Cc: Richard Weinberger <richard@nod.at> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "James R. Van Zandt" <jrv@vanzandt.mv.com> Cc: Corey Minyard <minyard@acm.org> Cc: Harald Welte <laforge@gnumonks.org> Acked-by: Lubomir Rintel <lkundrak@v3.sk> [scr24x_cs] Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> Cc: Johan Hovold <johan@kernel.org> Cc: David Herrmann <dh.herrmann@googlemail.com> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: Jean Delvare <jdelvare@suse.com> Acked-by: Guenter Roeck <linux@roeck-us.net> [watchdog/* hwmon/*] Cc: Rudolf Marek <r.marek@assembler.cz> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Karsten Keil <isdn@linux-pingi.de> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Kurt Schwemmer <kurt.schwemmer@microsemi.com> Acked-by: Logan Gunthorpe <logang@deltatee.com> [drivers/pci/switch/switchtec] Acked-by: Bjorn Helgaas <bhelgaas@google.com> [drivers/pci/switch/switchtec] Cc: Benson Leung <bleung@chromium.org> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> [platform/chrome] Cc: Alessandro Zummo <a.zummo@towertech.it> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> [rtc/*] Cc: Mark Brown <broonie@kernel.org> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: Wan ZongShun <mcuos.com@gmail.com> Cc: Zwane Mwaikambo <zwanem@gmail.com> Cc: Marek Lindner <mareklindner@neomailbox.ch> Cc: Simon Wunderlich <sw@simonwunderlich.de> Cc: Antonio Quartulli <a@unstable.cc> Cc: "David S. Miller" <davem@davemloft.net> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Signed-off-by: Kirill Smelkov <kirr@nexedi.com>
519 lines
12 KiB
C
519 lines
12 KiB
C
/*
|
|
* nv_tco 0.01: TCO timer driver for NV chipsets
|
|
*
|
|
* (c) Copyright 2005 Google Inc., All Rights Reserved.
|
|
*
|
|
* Based off i8xx_tco.c:
|
|
* (c) Copyright 2000 kernel concepts <nils@kernelconcepts.de>, All Rights
|
|
* Reserved.
|
|
* http://www.kernelconcepts.de
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*
|
|
* TCO timer driver for NV chipsets
|
|
* based on softdog.c by Alan Cox <alan@redhat.com>
|
|
*/
|
|
|
|
/*
|
|
* Includes, defines, variables, module parameters, ...
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/moduleparam.h>
|
|
#include <linux/types.h>
|
|
#include <linux/miscdevice.h>
|
|
#include <linux/watchdog.h>
|
|
#include <linux/init.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/jiffies.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/uaccess.h>
|
|
#include <linux/io.h>
|
|
|
|
#include "nv_tco.h"
|
|
|
|
/* Module and version information */
|
|
#define TCO_VERSION "0.01"
|
|
#define TCO_MODULE_NAME "NV_TCO"
|
|
#define TCO_DRIVER_NAME TCO_MODULE_NAME ", v" TCO_VERSION
|
|
|
|
/* internal variables */
|
|
static unsigned int tcobase;
|
|
static DEFINE_SPINLOCK(tco_lock); /* Guards the hardware */
|
|
static unsigned long timer_alive;
|
|
static char tco_expect_close;
|
|
static struct pci_dev *tco_pci;
|
|
|
|
/* the watchdog platform device */
|
|
static struct platform_device *nv_tco_platform_device;
|
|
|
|
/* module parameters */
|
|
#define WATCHDOG_HEARTBEAT 30 /* 30 sec default heartbeat (2<heartbeat<39) */
|
|
static int heartbeat = WATCHDOG_HEARTBEAT; /* in seconds */
|
|
module_param(heartbeat, int, 0);
|
|
MODULE_PARM_DESC(heartbeat, "Watchdog heartbeat in seconds. (2<heartbeat<39, "
|
|
"default=" __MODULE_STRING(WATCHDOG_HEARTBEAT) ")");
|
|
|
|
static bool nowayout = WATCHDOG_NOWAYOUT;
|
|
module_param(nowayout, bool, 0);
|
|
MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started"
|
|
" (default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
|
|
|
|
/*
|
|
* Some TCO specific functions
|
|
*/
|
|
static inline unsigned char seconds_to_ticks(int seconds)
|
|
{
|
|
/* the internal timer is stored as ticks which decrement
|
|
* every 0.6 seconds */
|
|
return (seconds * 10) / 6;
|
|
}
|
|
|
|
static void tco_timer_start(void)
|
|
{
|
|
u32 val;
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&tco_lock, flags);
|
|
val = inl(TCO_CNT(tcobase));
|
|
val &= ~TCO_CNT_TCOHALT;
|
|
outl(val, TCO_CNT(tcobase));
|
|
spin_unlock_irqrestore(&tco_lock, flags);
|
|
}
|
|
|
|
static void tco_timer_stop(void)
|
|
{
|
|
u32 val;
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&tco_lock, flags);
|
|
val = inl(TCO_CNT(tcobase));
|
|
val |= TCO_CNT_TCOHALT;
|
|
outl(val, TCO_CNT(tcobase));
|
|
spin_unlock_irqrestore(&tco_lock, flags);
|
|
}
|
|
|
|
static void tco_timer_keepalive(void)
|
|
{
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&tco_lock, flags);
|
|
outb(0x01, TCO_RLD(tcobase));
|
|
spin_unlock_irqrestore(&tco_lock, flags);
|
|
}
|
|
|
|
static int tco_timer_set_heartbeat(int t)
|
|
{
|
|
int ret = 0;
|
|
unsigned char tmrval;
|
|
unsigned long flags;
|
|
u8 val;
|
|
|
|
/*
|
|
* note seconds_to_ticks(t) > t, so if t > 0x3f, so is
|
|
* tmrval=seconds_to_ticks(t). Check that the count in seconds isn't
|
|
* out of range on it's own (to avoid overflow in tmrval).
|
|
*/
|
|
if (t < 0 || t > 0x3f)
|
|
return -EINVAL;
|
|
tmrval = seconds_to_ticks(t);
|
|
|
|
/* "Values of 0h-3h are ignored and should not be attempted" */
|
|
if (tmrval > 0x3f || tmrval < 0x04)
|
|
return -EINVAL;
|
|
|
|
/* Write new heartbeat to watchdog */
|
|
spin_lock_irqsave(&tco_lock, flags);
|
|
val = inb(TCO_TMR(tcobase));
|
|
val &= 0xc0;
|
|
val |= tmrval;
|
|
outb(val, TCO_TMR(tcobase));
|
|
val = inb(TCO_TMR(tcobase));
|
|
|
|
if ((val & 0x3f) != tmrval)
|
|
ret = -EINVAL;
|
|
spin_unlock_irqrestore(&tco_lock, flags);
|
|
|
|
if (ret)
|
|
return ret;
|
|
|
|
heartbeat = t;
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* /dev/watchdog handling
|
|
*/
|
|
|
|
static int nv_tco_open(struct inode *inode, struct file *file)
|
|
{
|
|
/* /dev/watchdog can only be opened once */
|
|
if (test_and_set_bit(0, &timer_alive))
|
|
return -EBUSY;
|
|
|
|
/* Reload and activate timer */
|
|
tco_timer_keepalive();
|
|
tco_timer_start();
|
|
return stream_open(inode, file);
|
|
}
|
|
|
|
static int nv_tco_release(struct inode *inode, struct file *file)
|
|
{
|
|
/* Shut off the timer */
|
|
if (tco_expect_close == 42) {
|
|
tco_timer_stop();
|
|
} else {
|
|
pr_crit("Unexpected close, not stopping watchdog!\n");
|
|
tco_timer_keepalive();
|
|
}
|
|
clear_bit(0, &timer_alive);
|
|
tco_expect_close = 0;
|
|
return 0;
|
|
}
|
|
|
|
static ssize_t nv_tco_write(struct file *file, const char __user *data,
|
|
size_t len, loff_t *ppos)
|
|
{
|
|
/* See if we got the magic character 'V' and reload the timer */
|
|
if (len) {
|
|
if (!nowayout) {
|
|
size_t i;
|
|
|
|
/*
|
|
* note: just in case someone wrote the magic character
|
|
* five months ago...
|
|
*/
|
|
tco_expect_close = 0;
|
|
|
|
/*
|
|
* scan to see whether or not we got the magic
|
|
* character
|
|
*/
|
|
for (i = 0; i != len; i++) {
|
|
char c;
|
|
if (get_user(c, data + i))
|
|
return -EFAULT;
|
|
if (c == 'V')
|
|
tco_expect_close = 42;
|
|
}
|
|
}
|
|
|
|
/* someone wrote to us, we should reload the timer */
|
|
tco_timer_keepalive();
|
|
}
|
|
return len;
|
|
}
|
|
|
|
static long nv_tco_ioctl(struct file *file, unsigned int cmd,
|
|
unsigned long arg)
|
|
{
|
|
int new_options, retval = -EINVAL;
|
|
int new_heartbeat;
|
|
void __user *argp = (void __user *)arg;
|
|
int __user *p = argp;
|
|
static const struct watchdog_info ident = {
|
|
.options = WDIOF_SETTIMEOUT |
|
|
WDIOF_KEEPALIVEPING |
|
|
WDIOF_MAGICCLOSE,
|
|
.firmware_version = 0,
|
|
.identity = TCO_MODULE_NAME,
|
|
};
|
|
|
|
switch (cmd) {
|
|
case WDIOC_GETSUPPORT:
|
|
return copy_to_user(argp, &ident, sizeof(ident)) ? -EFAULT : 0;
|
|
case WDIOC_GETSTATUS:
|
|
case WDIOC_GETBOOTSTATUS:
|
|
return put_user(0, p);
|
|
case WDIOC_SETOPTIONS:
|
|
if (get_user(new_options, p))
|
|
return -EFAULT;
|
|
if (new_options & WDIOS_DISABLECARD) {
|
|
tco_timer_stop();
|
|
retval = 0;
|
|
}
|
|
if (new_options & WDIOS_ENABLECARD) {
|
|
tco_timer_keepalive();
|
|
tco_timer_start();
|
|
retval = 0;
|
|
}
|
|
return retval;
|
|
case WDIOC_KEEPALIVE:
|
|
tco_timer_keepalive();
|
|
return 0;
|
|
case WDIOC_SETTIMEOUT:
|
|
if (get_user(new_heartbeat, p))
|
|
return -EFAULT;
|
|
if (tco_timer_set_heartbeat(new_heartbeat))
|
|
return -EINVAL;
|
|
tco_timer_keepalive();
|
|
/* Fall through */
|
|
case WDIOC_GETTIMEOUT:
|
|
return put_user(heartbeat, p);
|
|
default:
|
|
return -ENOTTY;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Kernel Interfaces
|
|
*/
|
|
|
|
static const struct file_operations nv_tco_fops = {
|
|
.owner = THIS_MODULE,
|
|
.llseek = no_llseek,
|
|
.write = nv_tco_write,
|
|
.unlocked_ioctl = nv_tco_ioctl,
|
|
.open = nv_tco_open,
|
|
.release = nv_tco_release,
|
|
};
|
|
|
|
static struct miscdevice nv_tco_miscdev = {
|
|
.minor = WATCHDOG_MINOR,
|
|
.name = "watchdog",
|
|
.fops = &nv_tco_fops,
|
|
};
|
|
|
|
/*
|
|
* Data for PCI driver interface
|
|
*
|
|
* This data only exists for exporting the supported
|
|
* PCI ids via MODULE_DEVICE_TABLE. We do not actually
|
|
* register a pci_driver, because someone else might one day
|
|
* want to register another driver on the same PCI id.
|
|
*/
|
|
static const struct pci_device_id tco_pci_tbl[] = {
|
|
{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SMBUS,
|
|
PCI_ANY_ID, PCI_ANY_ID, },
|
|
{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SMBUS,
|
|
PCI_ANY_ID, PCI_ANY_ID, },
|
|
{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP78S_SMBUS,
|
|
PCI_ANY_ID, PCI_ANY_ID, },
|
|
{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP79_SMBUS,
|
|
PCI_ANY_ID, PCI_ANY_ID, },
|
|
{ 0, }, /* End of list */
|
|
};
|
|
MODULE_DEVICE_TABLE(pci, tco_pci_tbl);
|
|
|
|
/*
|
|
* Init & exit routines
|
|
*/
|
|
|
|
static unsigned char nv_tco_getdevice(void)
|
|
{
|
|
struct pci_dev *dev = NULL;
|
|
u32 val;
|
|
|
|
/* Find the PCI device */
|
|
for_each_pci_dev(dev) {
|
|
if (pci_match_id(tco_pci_tbl, dev) != NULL) {
|
|
tco_pci = dev;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (!tco_pci)
|
|
return 0;
|
|
|
|
/* Find the base io port */
|
|
pci_read_config_dword(tco_pci, 0x64, &val);
|
|
val &= 0xffff;
|
|
if (val == 0x0001 || val == 0x0000) {
|
|
/* Something is wrong here, bar isn't setup */
|
|
pr_err("failed to get tcobase address\n");
|
|
return 0;
|
|
}
|
|
val &= 0xff00;
|
|
tcobase = val + 0x40;
|
|
|
|
if (!request_region(tcobase, 0x10, "NV TCO")) {
|
|
pr_err("I/O address 0x%04x already in use\n", tcobase);
|
|
return 0;
|
|
}
|
|
|
|
/* Set a reasonable heartbeat before we stop the timer */
|
|
tco_timer_set_heartbeat(30);
|
|
|
|
/*
|
|
* Stop the TCO before we change anything so we don't race with
|
|
* a zeroed timer.
|
|
*/
|
|
tco_timer_keepalive();
|
|
tco_timer_stop();
|
|
|
|
/* Disable SMI caused by TCO */
|
|
if (!request_region(MCP51_SMI_EN(tcobase), 4, "NV TCO")) {
|
|
pr_err("I/O address 0x%04x already in use\n",
|
|
MCP51_SMI_EN(tcobase));
|
|
goto out;
|
|
}
|
|
val = inl(MCP51_SMI_EN(tcobase));
|
|
val &= ~MCP51_SMI_EN_TCO;
|
|
outl(val, MCP51_SMI_EN(tcobase));
|
|
val = inl(MCP51_SMI_EN(tcobase));
|
|
release_region(MCP51_SMI_EN(tcobase), 4);
|
|
if (val & MCP51_SMI_EN_TCO) {
|
|
pr_err("Could not disable SMI caused by TCO\n");
|
|
goto out;
|
|
}
|
|
|
|
/* Check chipset's NO_REBOOT bit */
|
|
pci_read_config_dword(tco_pci, MCP51_SMBUS_SETUP_B, &val);
|
|
val |= MCP51_SMBUS_SETUP_B_TCO_REBOOT;
|
|
pci_write_config_dword(tco_pci, MCP51_SMBUS_SETUP_B, val);
|
|
pci_read_config_dword(tco_pci, MCP51_SMBUS_SETUP_B, &val);
|
|
if (!(val & MCP51_SMBUS_SETUP_B_TCO_REBOOT)) {
|
|
pr_err("failed to reset NO_REBOOT flag, reboot disabled by hardware\n");
|
|
goto out;
|
|
}
|
|
|
|
return 1;
|
|
out:
|
|
release_region(tcobase, 0x10);
|
|
return 0;
|
|
}
|
|
|
|
static int nv_tco_init(struct platform_device *dev)
|
|
{
|
|
int ret;
|
|
|
|
/* Check whether or not the hardware watchdog is there */
|
|
if (!nv_tco_getdevice())
|
|
return -ENODEV;
|
|
|
|
/* Check to see if last reboot was due to watchdog timeout */
|
|
pr_info("Watchdog reboot %sdetected\n",
|
|
inl(TCO_STS(tcobase)) & TCO_STS_TCO2TO_STS ? "" : "not ");
|
|
|
|
/* Clear out the old status */
|
|
outl(TCO_STS_RESET, TCO_STS(tcobase));
|
|
|
|
/*
|
|
* Check that the heartbeat value is within it's range.
|
|
* If not, reset to the default.
|
|
*/
|
|
if (tco_timer_set_heartbeat(heartbeat)) {
|
|
heartbeat = WATCHDOG_HEARTBEAT;
|
|
tco_timer_set_heartbeat(heartbeat);
|
|
pr_info("heartbeat value must be 2<heartbeat<39, using %d\n",
|
|
heartbeat);
|
|
}
|
|
|
|
ret = misc_register(&nv_tco_miscdev);
|
|
if (ret != 0) {
|
|
pr_err("cannot register miscdev on minor=%d (err=%d)\n",
|
|
WATCHDOG_MINOR, ret);
|
|
goto unreg_region;
|
|
}
|
|
|
|
clear_bit(0, &timer_alive);
|
|
|
|
tco_timer_stop();
|
|
|
|
pr_info("initialized (0x%04x). heartbeat=%d sec (nowayout=%d)\n",
|
|
tcobase, heartbeat, nowayout);
|
|
|
|
return 0;
|
|
|
|
unreg_region:
|
|
release_region(tcobase, 0x10);
|
|
return ret;
|
|
}
|
|
|
|
static void nv_tco_cleanup(void)
|
|
{
|
|
u32 val;
|
|
|
|
/* Stop the timer before we leave */
|
|
if (!nowayout)
|
|
tco_timer_stop();
|
|
|
|
/* Set the NO_REBOOT bit to prevent later reboots, just for sure */
|
|
pci_read_config_dword(tco_pci, MCP51_SMBUS_SETUP_B, &val);
|
|
val &= ~MCP51_SMBUS_SETUP_B_TCO_REBOOT;
|
|
pci_write_config_dword(tco_pci, MCP51_SMBUS_SETUP_B, val);
|
|
pci_read_config_dword(tco_pci, MCP51_SMBUS_SETUP_B, &val);
|
|
if (val & MCP51_SMBUS_SETUP_B_TCO_REBOOT) {
|
|
pr_crit("Couldn't unset REBOOT bit. Machine may soon reset\n");
|
|
}
|
|
|
|
/* Deregister */
|
|
misc_deregister(&nv_tco_miscdev);
|
|
release_region(tcobase, 0x10);
|
|
}
|
|
|
|
static int nv_tco_remove(struct platform_device *dev)
|
|
{
|
|
if (tcobase)
|
|
nv_tco_cleanup();
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void nv_tco_shutdown(struct platform_device *dev)
|
|
{
|
|
u32 val;
|
|
|
|
tco_timer_stop();
|
|
|
|
/* Some BIOSes fail the POST (once) if the NO_REBOOT flag is not
|
|
* unset during shutdown. */
|
|
pci_read_config_dword(tco_pci, MCP51_SMBUS_SETUP_B, &val);
|
|
val &= ~MCP51_SMBUS_SETUP_B_TCO_REBOOT;
|
|
pci_write_config_dword(tco_pci, MCP51_SMBUS_SETUP_B, val);
|
|
}
|
|
|
|
static struct platform_driver nv_tco_driver = {
|
|
.probe = nv_tco_init,
|
|
.remove = nv_tco_remove,
|
|
.shutdown = nv_tco_shutdown,
|
|
.driver = {
|
|
.name = TCO_MODULE_NAME,
|
|
},
|
|
};
|
|
|
|
static int __init nv_tco_init_module(void)
|
|
{
|
|
int err;
|
|
|
|
pr_info("NV TCO WatchDog Timer Driver v%s\n", TCO_VERSION);
|
|
|
|
err = platform_driver_register(&nv_tco_driver);
|
|
if (err)
|
|
return err;
|
|
|
|
nv_tco_platform_device = platform_device_register_simple(
|
|
TCO_MODULE_NAME, -1, NULL, 0);
|
|
if (IS_ERR(nv_tco_platform_device)) {
|
|
err = PTR_ERR(nv_tco_platform_device);
|
|
goto unreg_platform_driver;
|
|
}
|
|
|
|
return 0;
|
|
|
|
unreg_platform_driver:
|
|
platform_driver_unregister(&nv_tco_driver);
|
|
return err;
|
|
}
|
|
|
|
static void __exit nv_tco_cleanup_module(void)
|
|
{
|
|
platform_device_unregister(nv_tco_platform_device);
|
|
platform_driver_unregister(&nv_tco_driver);
|
|
pr_info("NV TCO Watchdog Module Unloaded\n");
|
|
}
|
|
|
|
module_init(nv_tco_init_module);
|
|
module_exit(nv_tco_cleanup_module);
|
|
|
|
MODULE_AUTHOR("Mike Waychison");
|
|
MODULE_DESCRIPTION("TCO timer driver for NV chipsets");
|
|
MODULE_LICENSE("GPL");
|