![Kirill Smelkov](/assets/img/avatar_default.png)
Using scripts/coccinelle/api/stream_open.cocci added in10dce8af34
("fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock"), search and convert to stream_open all in-kernel nonseekable_open users for which read and write actually do not depend on ppos and where there is no other methods in file_operations which assume @offset access. I've verified each generated change manually - that it is correct to convert - and each other nonseekable_open instance left - that it is either not correct to convert there, or that it is not converted due to current stream_open.cocci limitations. The script also does not convert files that should be valid to convert, but that currently have .llseek = noop_llseek or generic_file_llseek for unknown reason despite file being opened with nonseekable_open (e.g. drivers/input/mousedev.c) Among cases converted 14 were potentially vulnerable to read vs write deadlock (see details in10dce8af34
): drivers/char/pcmcia/cm4000_cs.c:1685:7-23: ERROR: cm4000_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/gnss/core.c:45:1-17: ERROR: gnss_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/hid/uhid.c:635:1-17: ERROR: uhid_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/infiniband/core/user_mad.c:988:1-17: ERROR: umad_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/evdev.c:527:1-17: ERROR: evdev_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/misc/uinput.c:401:1-17: ERROR: uinput_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/isdn/capi/capi.c:963:8-24: ERROR: capi_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/leds/uleds.c:77:1-17: ERROR: uleds_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/media/rc/lirc_dev.c:198:1-17: ERROR: lirc_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/s390/char/fs3270.c:488:1-17: ERROR: fs3270_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/usb/misc/ldusb.c:310:1-17: ERROR: ld_usb_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/xen/evtchn.c:667:8-24: ERROR: evtchn_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/batman-adv/icmp_socket.c:80:1-17: ERROR: batadv_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/rfkill/core.c:1146:8-24: ERROR: rfkill_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. and the rest were just safe to convert to stream_open because their read and write do not use ppos at all and corresponding file_operations do not have methods that assume @offset file access(*): arch/powerpc/platforms/52xx/mpc52xx_gpt.c:631:8-24: WARNING: mpc52xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/um/drivers/harddog_kern.c:88:8-24: WARNING: harddog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/x86/kernel/cpu/microcode/core.c:430:33-49: WARNING: microcode_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ds1620.c:215:8-24: WARNING: ds1620_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/dtlk.c:301:1-17: WARNING: dtlk_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ipmi/ipmi_watchdog.c:840:9-25: WARNING: ipmi_wdog_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/pcmcia/scr24x_cs.c:95:8-24: WARNING: scr24x_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/tb0219.c:246:9-25: WARNING: tb0219_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/firewire/nosy.c:306:8-24: WARNING: nosy_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/fschmd.c:840:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/w83793.c:1344:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucma.c:1747:8-24: WARNING: ucma_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucm.c:1178:8-24: WARNING: ucm_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/uverbs_main.c:1086:8-24: WARNING: uverbs_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/input/joydev.c:282:1-17: WARNING: joydev_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/pci/switch/switchtec.c:393:1-17: WARNING: switchtec_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/platform/chrome/cros_ec_debugfs.c:135:8-24: WARNING: cros_ec_console_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-ds1374.c:470:9-25: WARNING: ds1374_wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-m41t80.c:805:9-25: WARNING: wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/tape_char.c:293:2-18: WARNING: tape_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/zcore.c:194:8-24: WARNING: zcore_reipl_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/crypto/zcrypt_api.c:528:8-24: WARNING: zcrypt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/spi/spidev.c:594:1-17: WARNING: spidev_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/staging/pi433/pi433_if.c:974:1-17: WARNING: pi433_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/acquirewdt.c:203:8-24: WARNING: acq_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/advantechwdt.c:202:8-24: WARNING: advwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim1535_wdt.c:252:8-24: WARNING: ali_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim7101_wdt.c:217:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ar7_wdt.c:166:8-24: WARNING: ar7_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/at91rm9200_wdt.c:113:8-24: WARNING: at91wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ath79_wdt.c:135:8-24: WARNING: ath79_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/bcm63xx_wdt.c:119:8-24: WARNING: bcm63xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpu5wdt.c:143:8-24: WARNING: cpu5wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpwd.c:397:8-24: WARNING: cpwd_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/eurotechwdt.c:319:8-24: WARNING: eurwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/f71808e_wdt.c:528:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/gef_wdt.c:232:8-24: WARNING: gef_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/geodewdt.c:95:8-24: WARNING: geodewdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ib700wdt.c:241:8-24: WARNING: ibwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ibmasr.c:326:8-24: WARNING: asr_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/indydog.c:80:8-24: WARNING: indydog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/intel_scu_watchdog.c:307:8-24: WARNING: intel_scu_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/iop_wdt.c:104:8-24: WARNING: iop_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/it8712f_wdt.c:330:8-24: WARNING: it8712f_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ixp4xx_wdt.c:68:8-24: WARNING: ixp4xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ks8695_wdt.c:145:8-24: WARNING: ks8695wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/m54xx_wdt.c:88:8-24: WARNING: m54xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/machzwd.c:336:8-24: WARNING: zf_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mixcomwd.c:153:8-24: WARNING: mixcomwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mtx-1_wdt.c:121:8-24: WARNING: mtx1_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mv64x60_wdt.c:136:8-24: WARNING: mv64x60_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nuc900_wdt.c:134:8-24: WARNING: nuc900wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nv_tco.c:164:8-24: WARNING: nv_tco_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pc87413_wdt.c:289:8-24: WARNING: pc87413_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:698:8-24: WARNING: pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:737:8-24: WARNING: pcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:581:8-24: WARNING: pcipcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:623:8-24: WARNING: pcipcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:488:8-24: WARNING: usb_pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:527:8-24: WARNING: usb_pcwd_temperature_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pika_wdt.c:121:8-24: WARNING: pikawdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pnx833x_wdt.c:119:8-24: WARNING: pnx833x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rc32434_wdt.c:153:8-24: WARNING: rc32434_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rdc321x_wdt.c:145:8-24: WARNING: rdc321x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/riowd.c:79:1-17: WARNING: riowd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sa1100_wdt.c:62:8-24: WARNING: sa1100dog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc60xxwdt.c:211:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc7240_wdt.c:139:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc8360.c:274:8-24: WARNING: sbc8360_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_epx_c3.c:81:8-24: WARNING: epx_c3_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_fitpc2_wdt.c:78:8-24: WARNING: fitpc2_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sb_wdog.c:108:1-17: WARNING: sbwdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc1200wdt.c:181:8-24: WARNING: sc1200wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc520_wdt.c:261:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sch311x_wdt.c:319:8-24: WARNING: sch311x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/scx200_wdt.c:105:8-24: WARNING: scx200_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/smsc37b787_wdt.c:369:8-24: WARNING: wb_smsc_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83877f_wdt.c:227:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83977f_wdt.c:301:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wafer5823wdt.c:200:8-24: WARNING: wafwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/watchdog_dev.c:828:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:379:8-24: WARNING: wdrtas_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:445:8-24: WARNING: wdrtas_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt285.c:104:1-17: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt977.c:276:8-24: WARNING: wdt977_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:424:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:484:8-24: WARNING: wdt_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:464:8-24: WARNING: wdtpci_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:527:8-24: WARNING: wdtpci_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. net/batman-adv/log.c:105:1-17: WARNING: batadv_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/control.c:57:7-23: WARNING: snd_ctl_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/rawmidi.c:385:7-23: WARNING: snd_rawmidi_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/seq/seq_clientmgr.c:310:7-23: WARNING: snd_seq_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/timer.c:1428:7-23: WARNING: snd_timer_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. One can also recheck/review the patch via generating it with explanation comments included via $ make coccicheck MODE=patch COCCI=scripts/coccinelle/api/stream_open.cocci SPFLAGS="-D explain" (*) This second group also contains cases with read/write deadlocks that stream_open.cocci don't yet detect, but which are still valid to convert to stream_open since ppos is not used. For example drivers/pci/switch/switchtec.c calls wait_for_completion_interruptible() in its .read, but stream_open.cocci currently detects only "wait_event*" as blocking. Cc: Michael Kerrisk <mtk.manpages@gmail.com> Cc: Yongzhi Pan <panyongzhi@gmail.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: David Vrabel <david.vrabel@citrix.com> Cc: Juergen Gross <jgross@suse.com> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: Tejun Heo <tj@kernel.org> Cc: Kirill Tkhai <ktkhai@virtuozzo.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Christoph Hellwig <hch@lst.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Nikolaus Rath <Nikolaus@rath.org> Cc: Han-Wen Nienhuys <hanwen@google.com> Cc: Anatolij Gustschin <agust@denx.de> Cc: Jeff Dike <jdike@addtoit.com> Cc: Richard Weinberger <richard@nod.at> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "James R. Van Zandt" <jrv@vanzandt.mv.com> Cc: Corey Minyard <minyard@acm.org> Cc: Harald Welte <laforge@gnumonks.org> Acked-by: Lubomir Rintel <lkundrak@v3.sk> [scr24x_cs] Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> Cc: Johan Hovold <johan@kernel.org> Cc: David Herrmann <dh.herrmann@googlemail.com> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: Jean Delvare <jdelvare@suse.com> Acked-by: Guenter Roeck <linux@roeck-us.net> [watchdog/* hwmon/*] Cc: Rudolf Marek <r.marek@assembler.cz> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Karsten Keil <isdn@linux-pingi.de> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Kurt Schwemmer <kurt.schwemmer@microsemi.com> Acked-by: Logan Gunthorpe <logang@deltatee.com> [drivers/pci/switch/switchtec] Acked-by: Bjorn Helgaas <bhelgaas@google.com> [drivers/pci/switch/switchtec] Cc: Benson Leung <bleung@chromium.org> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> [platform/chrome] Cc: Alessandro Zummo <a.zummo@towertech.it> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> [rtc/*] Cc: Mark Brown <broonie@kernel.org> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: Wan ZongShun <mcuos.com@gmail.com> Cc: Zwane Mwaikambo <zwanem@gmail.com> Cc: Marek Lindner <mareklindner@neomailbox.ch> Cc: Simon Wunderlich <sw@simonwunderlich.de> Cc: Antonio Quartulli <a@unstable.cc> Cc: "David S. Miller" <davem@davemloft.net> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Signed-off-by: Kirill Smelkov <kirr@nexedi.com>
546 lines
14 KiB
C
546 lines
14 KiB
C
/*
|
|
* sch311x_wdt.c - Driver for the SCH311x Super-I/O chips
|
|
* integrated watchdog.
|
|
*
|
|
* (c) Copyright 2008 Wim Van Sebroeck <wim@iguana.be>.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*
|
|
* Neither Wim Van Sebroeck nor Iguana vzw. admit liability nor
|
|
* provide warranty for any of this software. This material is
|
|
* provided "AS-IS" and at no charge.
|
|
*/
|
|
|
|
/*
|
|
* Includes, defines, variables, module parameters, ...
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
/* Includes */
|
|
#include <linux/module.h> /* For module specific items */
|
|
#include <linux/moduleparam.h> /* For new moduleparam's */
|
|
#include <linux/types.h> /* For standard types (like size_t) */
|
|
#include <linux/errno.h> /* For the -ENODEV/... values */
|
|
#include <linux/kernel.h> /* For printk/... */
|
|
#include <linux/miscdevice.h> /* For struct miscdevice */
|
|
#include <linux/watchdog.h> /* For the watchdog specific items */
|
|
#include <linux/init.h> /* For __init/__exit/... */
|
|
#include <linux/fs.h> /* For file operations */
|
|
#include <linux/platform_device.h> /* For platform_driver framework */
|
|
#include <linux/ioport.h> /* For io-port access */
|
|
#include <linux/spinlock.h> /* For spin_lock/spin_unlock/... */
|
|
#include <linux/uaccess.h> /* For copy_to_user/put_user/... */
|
|
#include <linux/io.h> /* For inb/outb/... */
|
|
|
|
/* Module and version information */
|
|
#define DRV_NAME "sch311x_wdt"
|
|
|
|
/* Runtime registers */
|
|
#define GP60 0x47
|
|
#define WDT_TIME_OUT 0x65
|
|
#define WDT_VAL 0x66
|
|
#define WDT_CFG 0x67
|
|
#define WDT_CTRL 0x68
|
|
|
|
/* internal variables */
|
|
static unsigned long sch311x_wdt_is_open;
|
|
static char sch311x_wdt_expect_close;
|
|
static struct platform_device *sch311x_wdt_pdev;
|
|
|
|
static int sch311x_ioports[] = { 0x2e, 0x4e, 0x162e, 0x164e, 0x00 };
|
|
|
|
static struct { /* The devices private data */
|
|
/* the Runtime Register base address */
|
|
unsigned short runtime_reg;
|
|
/* The card's boot status */
|
|
int boot_status;
|
|
/* the lock for io operations */
|
|
spinlock_t io_lock;
|
|
} sch311x_wdt_data;
|
|
|
|
/* Module load parameters */
|
|
static unsigned short force_id;
|
|
module_param(force_id, ushort, 0);
|
|
MODULE_PARM_DESC(force_id, "Override the detected device ID");
|
|
|
|
#define WATCHDOG_TIMEOUT 60 /* 60 sec default timeout */
|
|
static int timeout = WATCHDOG_TIMEOUT; /* in seconds */
|
|
module_param(timeout, int, 0);
|
|
MODULE_PARM_DESC(timeout,
|
|
"Watchdog timeout in seconds. 1<= timeout <=15300, default="
|
|
__MODULE_STRING(WATCHDOG_TIMEOUT) ".");
|
|
|
|
static bool nowayout = WATCHDOG_NOWAYOUT;
|
|
module_param(nowayout, bool, 0);
|
|
MODULE_PARM_DESC(nowayout,
|
|
"Watchdog cannot be stopped once started (default="
|
|
__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
|
|
|
|
/*
|
|
* Super-IO functions
|
|
*/
|
|
|
|
static inline void sch311x_sio_enter(int sio_config_port)
|
|
{
|
|
outb(0x55, sio_config_port);
|
|
}
|
|
|
|
static inline void sch311x_sio_exit(int sio_config_port)
|
|
{
|
|
outb(0xaa, sio_config_port);
|
|
}
|
|
|
|
static inline int sch311x_sio_inb(int sio_config_port, int reg)
|
|
{
|
|
outb(reg, sio_config_port);
|
|
return inb(sio_config_port + 1);
|
|
}
|
|
|
|
static inline void sch311x_sio_outb(int sio_config_port, int reg, int val)
|
|
{
|
|
outb(reg, sio_config_port);
|
|
outb(val, sio_config_port + 1);
|
|
}
|
|
|
|
/*
|
|
* Watchdog Operations
|
|
*/
|
|
|
|
static void sch311x_wdt_set_timeout(int t)
|
|
{
|
|
unsigned char timeout_unit = 0x80;
|
|
|
|
/* When new timeout is bigger then 255 seconds, we will use minutes */
|
|
if (t > 255) {
|
|
timeout_unit = 0;
|
|
t /= 60;
|
|
}
|
|
|
|
/* -- Watchdog Timeout --
|
|
* Bit 0-6 (Reserved)
|
|
* Bit 7 WDT Time-out Value Units Select
|
|
* (0 = Minutes, 1 = Seconds)
|
|
*/
|
|
outb(timeout_unit, sch311x_wdt_data.runtime_reg + WDT_TIME_OUT);
|
|
|
|
/* -- Watchdog Timer Time-out Value --
|
|
* Bit 0-7 Binary coded units (0=Disabled, 1..255)
|
|
*/
|
|
outb(t, sch311x_wdt_data.runtime_reg + WDT_VAL);
|
|
}
|
|
|
|
static void sch311x_wdt_start(void)
|
|
{
|
|
unsigned char t;
|
|
|
|
spin_lock(&sch311x_wdt_data.io_lock);
|
|
|
|
/* set watchdog's timeout */
|
|
sch311x_wdt_set_timeout(timeout);
|
|
/* enable the watchdog */
|
|
/* -- General Purpose I/O Bit 6.0 --
|
|
* Bit 0, In/Out: 0 = Output, 1 = Input
|
|
* Bit 1, Polarity: 0 = No Invert, 1 = Invert
|
|
* Bit 2-3, Function select: 00 = GPI/O, 01 = LED1, 11 = WDT,
|
|
* 10 = Either Edge Triggered Intr.4
|
|
* Bit 4-6 (Reserved)
|
|
* Bit 7, Output Type: 0 = Push Pull Bit, 1 = Open Drain
|
|
*/
|
|
t = inb(sch311x_wdt_data.runtime_reg + GP60);
|
|
outb((t & ~0x0d) | 0x0c, sch311x_wdt_data.runtime_reg + GP60);
|
|
|
|
spin_unlock(&sch311x_wdt_data.io_lock);
|
|
|
|
}
|
|
|
|
static void sch311x_wdt_stop(void)
|
|
{
|
|
unsigned char t;
|
|
|
|
spin_lock(&sch311x_wdt_data.io_lock);
|
|
|
|
/* stop the watchdog */
|
|
t = inb(sch311x_wdt_data.runtime_reg + GP60);
|
|
outb((t & ~0x0d) | 0x01, sch311x_wdt_data.runtime_reg + GP60);
|
|
/* disable timeout by setting it to 0 */
|
|
sch311x_wdt_set_timeout(0);
|
|
|
|
spin_unlock(&sch311x_wdt_data.io_lock);
|
|
}
|
|
|
|
static void sch311x_wdt_keepalive(void)
|
|
{
|
|
spin_lock(&sch311x_wdt_data.io_lock);
|
|
sch311x_wdt_set_timeout(timeout);
|
|
spin_unlock(&sch311x_wdt_data.io_lock);
|
|
}
|
|
|
|
static int sch311x_wdt_set_heartbeat(int t)
|
|
{
|
|
if (t < 1 || t > (255*60))
|
|
return -EINVAL;
|
|
|
|
/* When new timeout is bigger then 255 seconds,
|
|
* we will round up to minutes (with a max of 255) */
|
|
if (t > 255)
|
|
t = (((t - 1) / 60) + 1) * 60;
|
|
|
|
timeout = t;
|
|
return 0;
|
|
}
|
|
|
|
static void sch311x_wdt_get_status(int *status)
|
|
{
|
|
unsigned char new_status;
|
|
|
|
*status = 0;
|
|
|
|
spin_lock(&sch311x_wdt_data.io_lock);
|
|
|
|
/* -- Watchdog timer control --
|
|
* Bit 0 Status Bit: 0 = Timer counting, 1 = Timeout occurred
|
|
* Bit 1 Reserved
|
|
* Bit 2 Force Timeout: 1 = Forces WD timeout event (self-cleaning)
|
|
* Bit 3 P20 Force Timeout enabled:
|
|
* 0 = P20 activity does not generate the WD timeout event
|
|
* 1 = P20 Allows rising edge of P20, from the keyboard
|
|
* controller, to force the WD timeout event.
|
|
* Bit 4-7 Reserved
|
|
*/
|
|
new_status = inb(sch311x_wdt_data.runtime_reg + WDT_CTRL);
|
|
if (new_status & 0x01)
|
|
*status |= WDIOF_CARDRESET;
|
|
|
|
spin_unlock(&sch311x_wdt_data.io_lock);
|
|
}
|
|
|
|
/*
|
|
* /dev/watchdog handling
|
|
*/
|
|
|
|
static ssize_t sch311x_wdt_write(struct file *file, const char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
if (count) {
|
|
if (!nowayout) {
|
|
size_t i;
|
|
|
|
sch311x_wdt_expect_close = 0;
|
|
|
|
for (i = 0; i != count; i++) {
|
|
char c;
|
|
if (get_user(c, buf + i))
|
|
return -EFAULT;
|
|
if (c == 'V')
|
|
sch311x_wdt_expect_close = 42;
|
|
}
|
|
}
|
|
sch311x_wdt_keepalive();
|
|
}
|
|
return count;
|
|
}
|
|
|
|
static long sch311x_wdt_ioctl(struct file *file, unsigned int cmd,
|
|
unsigned long arg)
|
|
{
|
|
int status;
|
|
int new_timeout;
|
|
void __user *argp = (void __user *)arg;
|
|
int __user *p = argp;
|
|
static const struct watchdog_info ident = {
|
|
.options = WDIOF_KEEPALIVEPING |
|
|
WDIOF_SETTIMEOUT |
|
|
WDIOF_MAGICCLOSE,
|
|
.firmware_version = 1,
|
|
.identity = DRV_NAME,
|
|
};
|
|
|
|
switch (cmd) {
|
|
case WDIOC_GETSUPPORT:
|
|
if (copy_to_user(argp, &ident, sizeof(ident)))
|
|
return -EFAULT;
|
|
break;
|
|
|
|
case WDIOC_GETSTATUS:
|
|
{
|
|
sch311x_wdt_get_status(&status);
|
|
return put_user(status, p);
|
|
}
|
|
case WDIOC_GETBOOTSTATUS:
|
|
return put_user(sch311x_wdt_data.boot_status, p);
|
|
|
|
case WDIOC_SETOPTIONS:
|
|
{
|
|
int options, retval = -EINVAL;
|
|
|
|
if (get_user(options, p))
|
|
return -EFAULT;
|
|
if (options & WDIOS_DISABLECARD) {
|
|
sch311x_wdt_stop();
|
|
retval = 0;
|
|
}
|
|
if (options & WDIOS_ENABLECARD) {
|
|
sch311x_wdt_start();
|
|
retval = 0;
|
|
}
|
|
return retval;
|
|
}
|
|
case WDIOC_KEEPALIVE:
|
|
sch311x_wdt_keepalive();
|
|
break;
|
|
|
|
case WDIOC_SETTIMEOUT:
|
|
if (get_user(new_timeout, p))
|
|
return -EFAULT;
|
|
if (sch311x_wdt_set_heartbeat(new_timeout))
|
|
return -EINVAL;
|
|
sch311x_wdt_keepalive();
|
|
/* Fall through */
|
|
case WDIOC_GETTIMEOUT:
|
|
return put_user(timeout, p);
|
|
default:
|
|
return -ENOTTY;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int sch311x_wdt_open(struct inode *inode, struct file *file)
|
|
{
|
|
if (test_and_set_bit(0, &sch311x_wdt_is_open))
|
|
return -EBUSY;
|
|
/*
|
|
* Activate
|
|
*/
|
|
sch311x_wdt_start();
|
|
return stream_open(inode, file);
|
|
}
|
|
|
|
static int sch311x_wdt_close(struct inode *inode, struct file *file)
|
|
{
|
|
if (sch311x_wdt_expect_close == 42) {
|
|
sch311x_wdt_stop();
|
|
} else {
|
|
pr_crit("Unexpected close, not stopping watchdog!\n");
|
|
sch311x_wdt_keepalive();
|
|
}
|
|
clear_bit(0, &sch311x_wdt_is_open);
|
|
sch311x_wdt_expect_close = 0;
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Kernel Interfaces
|
|
*/
|
|
|
|
static const struct file_operations sch311x_wdt_fops = {
|
|
.owner = THIS_MODULE,
|
|
.llseek = no_llseek,
|
|
.write = sch311x_wdt_write,
|
|
.unlocked_ioctl = sch311x_wdt_ioctl,
|
|
.open = sch311x_wdt_open,
|
|
.release = sch311x_wdt_close,
|
|
};
|
|
|
|
static struct miscdevice sch311x_wdt_miscdev = {
|
|
.minor = WATCHDOG_MINOR,
|
|
.name = "watchdog",
|
|
.fops = &sch311x_wdt_fops,
|
|
};
|
|
|
|
/*
|
|
* Init & exit routines
|
|
*/
|
|
|
|
static int sch311x_wdt_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
int err;
|
|
|
|
spin_lock_init(&sch311x_wdt_data.io_lock);
|
|
|
|
if (!request_region(sch311x_wdt_data.runtime_reg + GP60, 1, DRV_NAME)) {
|
|
dev_err(dev, "Failed to request region 0x%04x-0x%04x.\n",
|
|
sch311x_wdt_data.runtime_reg + GP60,
|
|
sch311x_wdt_data.runtime_reg + GP60);
|
|
err = -EBUSY;
|
|
goto exit;
|
|
}
|
|
|
|
if (!request_region(sch311x_wdt_data.runtime_reg + WDT_TIME_OUT, 4,
|
|
DRV_NAME)) {
|
|
dev_err(dev, "Failed to request region 0x%04x-0x%04x.\n",
|
|
sch311x_wdt_data.runtime_reg + WDT_TIME_OUT,
|
|
sch311x_wdt_data.runtime_reg + WDT_CTRL);
|
|
err = -EBUSY;
|
|
goto exit_release_region;
|
|
}
|
|
|
|
/* Make sure that the watchdog is not running */
|
|
sch311x_wdt_stop();
|
|
|
|
/* Disable keyboard and mouse interaction and interrupt */
|
|
/* -- Watchdog timer configuration --
|
|
* Bit 0 Reserved
|
|
* Bit 1 Keyboard enable: 0* = No Reset, 1 = Reset WDT upon KBD Intr.
|
|
* Bit 2 Mouse enable: 0* = No Reset, 1 = Reset WDT upon Mouse Intr
|
|
* Bit 3 Reserved
|
|
* Bit 4-7 WDT Interrupt Mapping: (0000* = Disabled,
|
|
* 0001=IRQ1, 0010=(Invalid), 0011=IRQ3 to 1111=IRQ15)
|
|
*/
|
|
outb(0, sch311x_wdt_data.runtime_reg + WDT_CFG);
|
|
|
|
/* Check that the heartbeat value is within it's range ;
|
|
* if not reset to the default */
|
|
if (sch311x_wdt_set_heartbeat(timeout)) {
|
|
sch311x_wdt_set_heartbeat(WATCHDOG_TIMEOUT);
|
|
dev_info(dev, "timeout value must be 1<=x<=15300, using %d\n",
|
|
timeout);
|
|
}
|
|
|
|
/* Get status at boot */
|
|
sch311x_wdt_get_status(&sch311x_wdt_data.boot_status);
|
|
|
|
sch311x_wdt_miscdev.parent = dev;
|
|
|
|
err = misc_register(&sch311x_wdt_miscdev);
|
|
if (err != 0) {
|
|
dev_err(dev, "cannot register miscdev on minor=%d (err=%d)\n",
|
|
WATCHDOG_MINOR, err);
|
|
goto exit_release_region2;
|
|
}
|
|
|
|
dev_info(dev,
|
|
"SMSC SCH311x WDT initialized. timeout=%d sec (nowayout=%d)\n",
|
|
timeout, nowayout);
|
|
|
|
return 0;
|
|
|
|
exit_release_region2:
|
|
release_region(sch311x_wdt_data.runtime_reg + WDT_TIME_OUT, 4);
|
|
exit_release_region:
|
|
release_region(sch311x_wdt_data.runtime_reg + GP60, 1);
|
|
sch311x_wdt_data.runtime_reg = 0;
|
|
exit:
|
|
return err;
|
|
}
|
|
|
|
static int sch311x_wdt_remove(struct platform_device *pdev)
|
|
{
|
|
/* Stop the timer before we leave */
|
|
if (!nowayout)
|
|
sch311x_wdt_stop();
|
|
|
|
/* Deregister */
|
|
misc_deregister(&sch311x_wdt_miscdev);
|
|
release_region(sch311x_wdt_data.runtime_reg + WDT_TIME_OUT, 4);
|
|
release_region(sch311x_wdt_data.runtime_reg + GP60, 1);
|
|
sch311x_wdt_data.runtime_reg = 0;
|
|
return 0;
|
|
}
|
|
|
|
static void sch311x_wdt_shutdown(struct platform_device *dev)
|
|
{
|
|
/* Turn the WDT off if we have a soft shutdown */
|
|
sch311x_wdt_stop();
|
|
}
|
|
|
|
static struct platform_driver sch311x_wdt_driver = {
|
|
.probe = sch311x_wdt_probe,
|
|
.remove = sch311x_wdt_remove,
|
|
.shutdown = sch311x_wdt_shutdown,
|
|
.driver = {
|
|
.name = DRV_NAME,
|
|
},
|
|
};
|
|
|
|
static int __init sch311x_detect(int sio_config_port, unsigned short *addr)
|
|
{
|
|
int err = 0, reg;
|
|
unsigned short base_addr;
|
|
unsigned char dev_id;
|
|
|
|
sch311x_sio_enter(sio_config_port);
|
|
|
|
/* Check device ID. We currently know about:
|
|
* SCH3112 (0x7c), SCH3114 (0x7d), and SCH3116 (0x7f). */
|
|
reg = force_id ? force_id : sch311x_sio_inb(sio_config_port, 0x20);
|
|
if (!(reg == 0x7c || reg == 0x7d || reg == 0x7f)) {
|
|
err = -ENODEV;
|
|
goto exit;
|
|
}
|
|
dev_id = reg == 0x7c ? 2 : reg == 0x7d ? 4 : 6;
|
|
|
|
/* Select logical device A (runtime registers) */
|
|
sch311x_sio_outb(sio_config_port, 0x07, 0x0a);
|
|
|
|
/* Check if Logical Device Register is currently active */
|
|
if ((sch311x_sio_inb(sio_config_port, 0x30) & 0x01) == 0)
|
|
pr_info("Seems that LDN 0x0a is not active...\n");
|
|
|
|
/* Get the base address of the runtime registers */
|
|
base_addr = (sch311x_sio_inb(sio_config_port, 0x60) << 8) |
|
|
sch311x_sio_inb(sio_config_port, 0x61);
|
|
if (!base_addr) {
|
|
pr_err("Base address not set\n");
|
|
err = -ENODEV;
|
|
goto exit;
|
|
}
|
|
*addr = base_addr;
|
|
|
|
pr_info("Found an SMSC SCH311%d chip at 0x%04x\n", dev_id, base_addr);
|
|
|
|
exit:
|
|
sch311x_sio_exit(sio_config_port);
|
|
return err;
|
|
}
|
|
|
|
static int __init sch311x_wdt_init(void)
|
|
{
|
|
int err, i, found = 0;
|
|
unsigned short addr = 0;
|
|
|
|
for (i = 0; !found && sch311x_ioports[i]; i++)
|
|
if (sch311x_detect(sch311x_ioports[i], &addr) == 0)
|
|
found++;
|
|
|
|
if (!found)
|
|
return -ENODEV;
|
|
|
|
sch311x_wdt_data.runtime_reg = addr;
|
|
|
|
err = platform_driver_register(&sch311x_wdt_driver);
|
|
if (err)
|
|
return err;
|
|
|
|
sch311x_wdt_pdev = platform_device_register_simple(DRV_NAME, addr,
|
|
NULL, 0);
|
|
|
|
if (IS_ERR(sch311x_wdt_pdev)) {
|
|
err = PTR_ERR(sch311x_wdt_pdev);
|
|
goto unreg_platform_driver;
|
|
}
|
|
|
|
return 0;
|
|
|
|
unreg_platform_driver:
|
|
platform_driver_unregister(&sch311x_wdt_driver);
|
|
return err;
|
|
}
|
|
|
|
static void __exit sch311x_wdt_exit(void)
|
|
{
|
|
platform_device_unregister(sch311x_wdt_pdev);
|
|
platform_driver_unregister(&sch311x_wdt_driver);
|
|
}
|
|
|
|
module_init(sch311x_wdt_init);
|
|
module_exit(sch311x_wdt_exit);
|
|
|
|
MODULE_AUTHOR("Wim Van Sebroeck <wim@iguana.be>");
|
|
MODULE_DESCRIPTION("SMSC SCH311x WatchDog Timer Driver");
|
|
MODULE_LICENSE("GPL");
|