![Kirill Smelkov](/assets/img/avatar_default.png)
Using scripts/coccinelle/api/stream_open.cocci added in10dce8af34
("fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock"), search and convert to stream_open all in-kernel nonseekable_open users for which read and write actually do not depend on ppos and where there is no other methods in file_operations which assume @offset access. I've verified each generated change manually - that it is correct to convert - and each other nonseekable_open instance left - that it is either not correct to convert there, or that it is not converted due to current stream_open.cocci limitations. The script also does not convert files that should be valid to convert, but that currently have .llseek = noop_llseek or generic_file_llseek for unknown reason despite file being opened with nonseekable_open (e.g. drivers/input/mousedev.c) Among cases converted 14 were potentially vulnerable to read vs write deadlock (see details in10dce8af34
): drivers/char/pcmcia/cm4000_cs.c:1685:7-23: ERROR: cm4000_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/gnss/core.c:45:1-17: ERROR: gnss_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/hid/uhid.c:635:1-17: ERROR: uhid_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/infiniband/core/user_mad.c:988:1-17: ERROR: umad_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/evdev.c:527:1-17: ERROR: evdev_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/misc/uinput.c:401:1-17: ERROR: uinput_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/isdn/capi/capi.c:963:8-24: ERROR: capi_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/leds/uleds.c:77:1-17: ERROR: uleds_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/media/rc/lirc_dev.c:198:1-17: ERROR: lirc_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/s390/char/fs3270.c:488:1-17: ERROR: fs3270_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/usb/misc/ldusb.c:310:1-17: ERROR: ld_usb_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/xen/evtchn.c:667:8-24: ERROR: evtchn_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/batman-adv/icmp_socket.c:80:1-17: ERROR: batadv_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/rfkill/core.c:1146:8-24: ERROR: rfkill_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. and the rest were just safe to convert to stream_open because their read and write do not use ppos at all and corresponding file_operations do not have methods that assume @offset file access(*): arch/powerpc/platforms/52xx/mpc52xx_gpt.c:631:8-24: WARNING: mpc52xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/um/drivers/harddog_kern.c:88:8-24: WARNING: harddog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/x86/kernel/cpu/microcode/core.c:430:33-49: WARNING: microcode_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ds1620.c:215:8-24: WARNING: ds1620_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/dtlk.c:301:1-17: WARNING: dtlk_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ipmi/ipmi_watchdog.c:840:9-25: WARNING: ipmi_wdog_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/pcmcia/scr24x_cs.c:95:8-24: WARNING: scr24x_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/tb0219.c:246:9-25: WARNING: tb0219_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/firewire/nosy.c:306:8-24: WARNING: nosy_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/fschmd.c:840:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/w83793.c:1344:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucma.c:1747:8-24: WARNING: ucma_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucm.c:1178:8-24: WARNING: ucm_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/uverbs_main.c:1086:8-24: WARNING: uverbs_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/input/joydev.c:282:1-17: WARNING: joydev_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/pci/switch/switchtec.c:393:1-17: WARNING: switchtec_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/platform/chrome/cros_ec_debugfs.c:135:8-24: WARNING: cros_ec_console_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-ds1374.c:470:9-25: WARNING: ds1374_wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-m41t80.c:805:9-25: WARNING: wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/tape_char.c:293:2-18: WARNING: tape_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/zcore.c:194:8-24: WARNING: zcore_reipl_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/crypto/zcrypt_api.c:528:8-24: WARNING: zcrypt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/spi/spidev.c:594:1-17: WARNING: spidev_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/staging/pi433/pi433_if.c:974:1-17: WARNING: pi433_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/acquirewdt.c:203:8-24: WARNING: acq_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/advantechwdt.c:202:8-24: WARNING: advwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim1535_wdt.c:252:8-24: WARNING: ali_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim7101_wdt.c:217:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ar7_wdt.c:166:8-24: WARNING: ar7_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/at91rm9200_wdt.c:113:8-24: WARNING: at91wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ath79_wdt.c:135:8-24: WARNING: ath79_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/bcm63xx_wdt.c:119:8-24: WARNING: bcm63xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpu5wdt.c:143:8-24: WARNING: cpu5wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpwd.c:397:8-24: WARNING: cpwd_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/eurotechwdt.c:319:8-24: WARNING: eurwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/f71808e_wdt.c:528:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/gef_wdt.c:232:8-24: WARNING: gef_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/geodewdt.c:95:8-24: WARNING: geodewdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ib700wdt.c:241:8-24: WARNING: ibwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ibmasr.c:326:8-24: WARNING: asr_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/indydog.c:80:8-24: WARNING: indydog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/intel_scu_watchdog.c:307:8-24: WARNING: intel_scu_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/iop_wdt.c:104:8-24: WARNING: iop_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/it8712f_wdt.c:330:8-24: WARNING: it8712f_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ixp4xx_wdt.c:68:8-24: WARNING: ixp4xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ks8695_wdt.c:145:8-24: WARNING: ks8695wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/m54xx_wdt.c:88:8-24: WARNING: m54xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/machzwd.c:336:8-24: WARNING: zf_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mixcomwd.c:153:8-24: WARNING: mixcomwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mtx-1_wdt.c:121:8-24: WARNING: mtx1_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mv64x60_wdt.c:136:8-24: WARNING: mv64x60_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nuc900_wdt.c:134:8-24: WARNING: nuc900wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nv_tco.c:164:8-24: WARNING: nv_tco_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pc87413_wdt.c:289:8-24: WARNING: pc87413_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:698:8-24: WARNING: pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:737:8-24: WARNING: pcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:581:8-24: WARNING: pcipcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:623:8-24: WARNING: pcipcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:488:8-24: WARNING: usb_pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:527:8-24: WARNING: usb_pcwd_temperature_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pika_wdt.c:121:8-24: WARNING: pikawdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pnx833x_wdt.c:119:8-24: WARNING: pnx833x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rc32434_wdt.c:153:8-24: WARNING: rc32434_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rdc321x_wdt.c:145:8-24: WARNING: rdc321x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/riowd.c:79:1-17: WARNING: riowd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sa1100_wdt.c:62:8-24: WARNING: sa1100dog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc60xxwdt.c:211:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc7240_wdt.c:139:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc8360.c:274:8-24: WARNING: sbc8360_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_epx_c3.c:81:8-24: WARNING: epx_c3_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_fitpc2_wdt.c:78:8-24: WARNING: fitpc2_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sb_wdog.c:108:1-17: WARNING: sbwdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc1200wdt.c:181:8-24: WARNING: sc1200wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc520_wdt.c:261:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sch311x_wdt.c:319:8-24: WARNING: sch311x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/scx200_wdt.c:105:8-24: WARNING: scx200_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/smsc37b787_wdt.c:369:8-24: WARNING: wb_smsc_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83877f_wdt.c:227:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83977f_wdt.c:301:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wafer5823wdt.c:200:8-24: WARNING: wafwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/watchdog_dev.c:828:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:379:8-24: WARNING: wdrtas_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:445:8-24: WARNING: wdrtas_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt285.c:104:1-17: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt977.c:276:8-24: WARNING: wdt977_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:424:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:484:8-24: WARNING: wdt_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:464:8-24: WARNING: wdtpci_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:527:8-24: WARNING: wdtpci_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. net/batman-adv/log.c:105:1-17: WARNING: batadv_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/control.c:57:7-23: WARNING: snd_ctl_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/rawmidi.c:385:7-23: WARNING: snd_rawmidi_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/seq/seq_clientmgr.c:310:7-23: WARNING: snd_seq_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/timer.c:1428:7-23: WARNING: snd_timer_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. One can also recheck/review the patch via generating it with explanation comments included via $ make coccicheck MODE=patch COCCI=scripts/coccinelle/api/stream_open.cocci SPFLAGS="-D explain" (*) This second group also contains cases with read/write deadlocks that stream_open.cocci don't yet detect, but which are still valid to convert to stream_open since ppos is not used. For example drivers/pci/switch/switchtec.c calls wait_for_completion_interruptible() in its .read, but stream_open.cocci currently detects only "wait_event*" as blocking. Cc: Michael Kerrisk <mtk.manpages@gmail.com> Cc: Yongzhi Pan <panyongzhi@gmail.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: David Vrabel <david.vrabel@citrix.com> Cc: Juergen Gross <jgross@suse.com> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: Tejun Heo <tj@kernel.org> Cc: Kirill Tkhai <ktkhai@virtuozzo.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Christoph Hellwig <hch@lst.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Nikolaus Rath <Nikolaus@rath.org> Cc: Han-Wen Nienhuys <hanwen@google.com> Cc: Anatolij Gustschin <agust@denx.de> Cc: Jeff Dike <jdike@addtoit.com> Cc: Richard Weinberger <richard@nod.at> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "James R. Van Zandt" <jrv@vanzandt.mv.com> Cc: Corey Minyard <minyard@acm.org> Cc: Harald Welte <laforge@gnumonks.org> Acked-by: Lubomir Rintel <lkundrak@v3.sk> [scr24x_cs] Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> Cc: Johan Hovold <johan@kernel.org> Cc: David Herrmann <dh.herrmann@googlemail.com> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: Jean Delvare <jdelvare@suse.com> Acked-by: Guenter Roeck <linux@roeck-us.net> [watchdog/* hwmon/*] Cc: Rudolf Marek <r.marek@assembler.cz> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Karsten Keil <isdn@linux-pingi.de> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Kurt Schwemmer <kurt.schwemmer@microsemi.com> Acked-by: Logan Gunthorpe <logang@deltatee.com> [drivers/pci/switch/switchtec] Acked-by: Bjorn Helgaas <bhelgaas@google.com> [drivers/pci/switch/switchtec] Cc: Benson Leung <bleung@chromium.org> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> [platform/chrome] Cc: Alessandro Zummo <a.zummo@towertech.it> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> [rtc/*] Cc: Mark Brown <broonie@kernel.org> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: Wan ZongShun <mcuos.com@gmail.com> Cc: Zwane Mwaikambo <zwanem@gmail.com> Cc: Marek Lindner <mareklindner@neomailbox.ch> Cc: Simon Wunderlich <sw@simonwunderlich.de> Cc: Antonio Quartulli <a@unstable.cc> Cc: "David S. Miller" <davem@davemloft.net> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Signed-off-by: Kirill Smelkov <kirr@nexedi.com>
510 lines
12 KiB
C
510 lines
12 KiB
C
/*
|
|
* Wdt977 0.04: A Watchdog Device for Netwinder W83977AF chip
|
|
*
|
|
* (c) Copyright 1998 Rebel.com (Woody Suwalski <woody@netwinder.org>)
|
|
*
|
|
* -----------------------
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*
|
|
* -----------------------
|
|
* 14-Dec-2001 Matt Domsch <Matt_Domsch@dell.com>
|
|
* Added nowayout module option to override CONFIG_WATCHDOG_NOWAYOUT
|
|
* 19-Dec-2001 Woody Suwalski: Netwinder fixes, ioctl interface
|
|
* 06-Jan-2002 Woody Suwalski: For compatibility, convert all timeouts
|
|
* from minutes to seconds.
|
|
* 07-Jul-2003 Daniele Bellucci: Audit return code of misc_register in
|
|
* nwwatchdog_init.
|
|
* 25-Oct-2005 Woody Suwalski: Convert addresses to #defs, add spinlocks
|
|
* remove limitiation to be used on
|
|
* Netwinders only
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/moduleparam.h>
|
|
#include <linux/types.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/miscdevice.h>
|
|
#include <linux/init.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/watchdog.h>
|
|
#include <linux/notifier.h>
|
|
#include <linux/reboot.h>
|
|
#include <linux/io.h>
|
|
#include <linux/uaccess.h>
|
|
|
|
#include <asm/mach-types.h>
|
|
|
|
#define WATCHDOG_VERSION "0.04"
|
|
#define WATCHDOG_NAME "Wdt977"
|
|
|
|
#define IO_INDEX_PORT 0x370 /* on some systems it can be 0x3F0 */
|
|
#define IO_DATA_PORT (IO_INDEX_PORT + 1)
|
|
|
|
#define UNLOCK_DATA 0x87
|
|
#define LOCK_DATA 0xAA
|
|
#define DEVICE_REGISTER 0x07
|
|
|
|
|
|
#define DEFAULT_TIMEOUT 60 /* default timeout in seconds */
|
|
|
|
static int timeout = DEFAULT_TIMEOUT;
|
|
static int timeoutM; /* timeout in minutes */
|
|
static unsigned long timer_alive;
|
|
static int testmode;
|
|
static char expect_close;
|
|
static DEFINE_SPINLOCK(spinlock);
|
|
|
|
module_param(timeout, int, 0);
|
|
MODULE_PARM_DESC(timeout, "Watchdog timeout in seconds (60..15300, default="
|
|
__MODULE_STRING(DEFAULT_TIMEOUT) ")");
|
|
module_param(testmode, int, 0);
|
|
MODULE_PARM_DESC(testmode, "Watchdog testmode (1 = no reboot), default=0");
|
|
|
|
static bool nowayout = WATCHDOG_NOWAYOUT;
|
|
module_param(nowayout, bool, 0);
|
|
MODULE_PARM_DESC(nowayout,
|
|
"Watchdog cannot be stopped once started (default="
|
|
__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
|
|
|
|
/*
|
|
* Start the watchdog
|
|
*/
|
|
|
|
static int wdt977_start(void)
|
|
{
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&spinlock, flags);
|
|
|
|
/* unlock the SuperIO chip */
|
|
outb_p(UNLOCK_DATA, IO_INDEX_PORT);
|
|
outb_p(UNLOCK_DATA, IO_INDEX_PORT);
|
|
|
|
/* select device Aux2 (device=8) and set watchdog regs F2, F3 and F4
|
|
* F2 has the timeout in minutes
|
|
* F3 could be set to the POWER LED blink (with GP17 set to PowerLed)
|
|
* at timeout, and to reset timer on kbd/mouse activity (not impl.)
|
|
* F4 is used to just clear the TIMEOUT'ed state (bit 0)
|
|
*/
|
|
outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
|
|
outb_p(0x08, IO_DATA_PORT);
|
|
outb_p(0xF2, IO_INDEX_PORT);
|
|
outb_p(timeoutM, IO_DATA_PORT);
|
|
outb_p(0xF3, IO_INDEX_PORT);
|
|
outb_p(0x00, IO_DATA_PORT); /* another setting is 0E for
|
|
kbd/mouse/LED */
|
|
outb_p(0xF4, IO_INDEX_PORT);
|
|
outb_p(0x00, IO_DATA_PORT);
|
|
|
|
/* At last select device Aux1 (dev=7) and set GP16 as a
|
|
* watchdog output. In test mode watch the bit 1 on F4 to
|
|
* indicate "triggered"
|
|
*/
|
|
if (!testmode) {
|
|
outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
|
|
outb_p(0x07, IO_DATA_PORT);
|
|
outb_p(0xE6, IO_INDEX_PORT);
|
|
outb_p(0x08, IO_DATA_PORT);
|
|
}
|
|
|
|
/* lock the SuperIO chip */
|
|
outb_p(LOCK_DATA, IO_INDEX_PORT);
|
|
|
|
spin_unlock_irqrestore(&spinlock, flags);
|
|
pr_info("activated\n");
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Stop the watchdog
|
|
*/
|
|
|
|
static int wdt977_stop(void)
|
|
{
|
|
unsigned long flags;
|
|
spin_lock_irqsave(&spinlock, flags);
|
|
|
|
/* unlock the SuperIO chip */
|
|
outb_p(UNLOCK_DATA, IO_INDEX_PORT);
|
|
outb_p(UNLOCK_DATA, IO_INDEX_PORT);
|
|
|
|
/* select device Aux2 (device=8) and set watchdog regs F2,F3 and F4
|
|
* F3 is reset to its default state
|
|
* F4 can clear the TIMEOUT'ed state (bit 0) - back to default
|
|
* We can not use GP17 as a PowerLed, as we use its usage as a RedLed
|
|
*/
|
|
outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
|
|
outb_p(0x08, IO_DATA_PORT);
|
|
outb_p(0xF2, IO_INDEX_PORT);
|
|
outb_p(0xFF, IO_DATA_PORT);
|
|
outb_p(0xF3, IO_INDEX_PORT);
|
|
outb_p(0x00, IO_DATA_PORT);
|
|
outb_p(0xF4, IO_INDEX_PORT);
|
|
outb_p(0x00, IO_DATA_PORT);
|
|
outb_p(0xF2, IO_INDEX_PORT);
|
|
outb_p(0x00, IO_DATA_PORT);
|
|
|
|
/* at last select device Aux1 (dev=7) and set
|
|
GP16 as a watchdog output */
|
|
outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
|
|
outb_p(0x07, IO_DATA_PORT);
|
|
outb_p(0xE6, IO_INDEX_PORT);
|
|
outb_p(0x08, IO_DATA_PORT);
|
|
|
|
/* lock the SuperIO chip */
|
|
outb_p(LOCK_DATA, IO_INDEX_PORT);
|
|
|
|
spin_unlock_irqrestore(&spinlock, flags);
|
|
pr_info("shutdown\n");
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Send a keepalive ping to the watchdog
|
|
* This is done by simply re-writing the timeout to reg. 0xF2
|
|
*/
|
|
|
|
static int wdt977_keepalive(void)
|
|
{
|
|
unsigned long flags;
|
|
spin_lock_irqsave(&spinlock, flags);
|
|
|
|
/* unlock the SuperIO chip */
|
|
outb_p(UNLOCK_DATA, IO_INDEX_PORT);
|
|
outb_p(UNLOCK_DATA, IO_INDEX_PORT);
|
|
|
|
/* select device Aux2 (device=8) and kicks watchdog reg F2 */
|
|
/* F2 has the timeout in minutes */
|
|
outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
|
|
outb_p(0x08, IO_DATA_PORT);
|
|
outb_p(0xF2, IO_INDEX_PORT);
|
|
outb_p(timeoutM, IO_DATA_PORT);
|
|
|
|
/* lock the SuperIO chip */
|
|
outb_p(LOCK_DATA, IO_INDEX_PORT);
|
|
spin_unlock_irqrestore(&spinlock, flags);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Set the watchdog timeout value
|
|
*/
|
|
|
|
static int wdt977_set_timeout(int t)
|
|
{
|
|
int tmrval;
|
|
|
|
/* convert seconds to minutes, rounding up */
|
|
tmrval = (t + 59) / 60;
|
|
|
|
if (machine_is_netwinder()) {
|
|
/* we have a hw bug somewhere, so each 977 minute is actually
|
|
* only 30sec. This limits the max timeout to half of device
|
|
* max of 255 minutes...
|
|
*/
|
|
tmrval += tmrval;
|
|
}
|
|
|
|
if (tmrval < 1 || tmrval > 255)
|
|
return -EINVAL;
|
|
|
|
/* timeout is the timeout in seconds, timeoutM is
|
|
the timeout in minutes) */
|
|
timeout = t;
|
|
timeoutM = tmrval;
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Get the watchdog status
|
|
*/
|
|
|
|
static int wdt977_get_status(int *status)
|
|
{
|
|
int new_status;
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&spinlock, flags);
|
|
|
|
/* unlock the SuperIO chip */
|
|
outb_p(UNLOCK_DATA, IO_INDEX_PORT);
|
|
outb_p(UNLOCK_DATA, IO_INDEX_PORT);
|
|
|
|
/* select device Aux2 (device=8) and read watchdog reg F4 */
|
|
outb_p(DEVICE_REGISTER, IO_INDEX_PORT);
|
|
outb_p(0x08, IO_DATA_PORT);
|
|
outb_p(0xF4, IO_INDEX_PORT);
|
|
new_status = inb_p(IO_DATA_PORT);
|
|
|
|
/* lock the SuperIO chip */
|
|
outb_p(LOCK_DATA, IO_INDEX_PORT);
|
|
|
|
spin_unlock_irqrestore(&spinlock, flags);
|
|
|
|
*status = 0;
|
|
if (new_status & 1)
|
|
*status |= WDIOF_CARDRESET;
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
/*
|
|
* /dev/watchdog handling
|
|
*/
|
|
|
|
static int wdt977_open(struct inode *inode, struct file *file)
|
|
{
|
|
/* If the watchdog is alive we don't need to start it again */
|
|
if (test_and_set_bit(0, &timer_alive))
|
|
return -EBUSY;
|
|
|
|
if (nowayout)
|
|
__module_get(THIS_MODULE);
|
|
|
|
wdt977_start();
|
|
return stream_open(inode, file);
|
|
}
|
|
|
|
static int wdt977_release(struct inode *inode, struct file *file)
|
|
{
|
|
/*
|
|
* Shut off the timer.
|
|
* Lock it in if it's a module and we set nowayout
|
|
*/
|
|
if (expect_close == 42) {
|
|
wdt977_stop();
|
|
clear_bit(0, &timer_alive);
|
|
} else {
|
|
wdt977_keepalive();
|
|
pr_crit("Unexpected close, not stopping watchdog!\n");
|
|
}
|
|
expect_close = 0;
|
|
return 0;
|
|
}
|
|
|
|
|
|
/*
|
|
* wdt977_write:
|
|
* @file: file handle to the watchdog
|
|
* @buf: buffer to write (unused as data does not matter here
|
|
* @count: count of bytes
|
|
* @ppos: pointer to the position to write. No seeks allowed
|
|
*
|
|
* A write to a watchdog device is defined as a keepalive signal. Any
|
|
* write of data will do, as we we don't define content meaning.
|
|
*/
|
|
|
|
static ssize_t wdt977_write(struct file *file, const char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
if (count) {
|
|
if (!nowayout) {
|
|
size_t i;
|
|
|
|
/* In case it was set long ago */
|
|
expect_close = 0;
|
|
|
|
for (i = 0; i != count; i++) {
|
|
char c;
|
|
if (get_user(c, buf + i))
|
|
return -EFAULT;
|
|
if (c == 'V')
|
|
expect_close = 42;
|
|
}
|
|
}
|
|
|
|
/* someone wrote to us, we should restart timer */
|
|
wdt977_keepalive();
|
|
}
|
|
return count;
|
|
}
|
|
|
|
static const struct watchdog_info ident = {
|
|
.options = WDIOF_SETTIMEOUT |
|
|
WDIOF_MAGICCLOSE |
|
|
WDIOF_KEEPALIVEPING,
|
|
.firmware_version = 1,
|
|
.identity = WATCHDOG_NAME,
|
|
};
|
|
|
|
/*
|
|
* wdt977_ioctl:
|
|
* @inode: inode of the device
|
|
* @file: file handle to the device
|
|
* @cmd: watchdog command
|
|
* @arg: argument pointer
|
|
*
|
|
* The watchdog API defines a common set of functions for all watchdogs
|
|
* according to their available features.
|
|
*/
|
|
|
|
static long wdt977_ioctl(struct file *file, unsigned int cmd,
|
|
unsigned long arg)
|
|
{
|
|
int status;
|
|
int new_options, retval = -EINVAL;
|
|
int new_timeout;
|
|
union {
|
|
struct watchdog_info __user *ident;
|
|
int __user *i;
|
|
} uarg;
|
|
|
|
uarg.i = (int __user *)arg;
|
|
|
|
switch (cmd) {
|
|
case WDIOC_GETSUPPORT:
|
|
return copy_to_user(uarg.ident, &ident,
|
|
sizeof(ident)) ? -EFAULT : 0;
|
|
|
|
case WDIOC_GETSTATUS:
|
|
wdt977_get_status(&status);
|
|
return put_user(status, uarg.i);
|
|
|
|
case WDIOC_GETBOOTSTATUS:
|
|
return put_user(0, uarg.i);
|
|
|
|
case WDIOC_SETOPTIONS:
|
|
if (get_user(new_options, uarg.i))
|
|
return -EFAULT;
|
|
|
|
if (new_options & WDIOS_DISABLECARD) {
|
|
wdt977_stop();
|
|
retval = 0;
|
|
}
|
|
|
|
if (new_options & WDIOS_ENABLECARD) {
|
|
wdt977_start();
|
|
retval = 0;
|
|
}
|
|
|
|
return retval;
|
|
|
|
case WDIOC_KEEPALIVE:
|
|
wdt977_keepalive();
|
|
return 0;
|
|
|
|
case WDIOC_SETTIMEOUT:
|
|
if (get_user(new_timeout, uarg.i))
|
|
return -EFAULT;
|
|
|
|
if (wdt977_set_timeout(new_timeout))
|
|
return -EINVAL;
|
|
|
|
wdt977_keepalive();
|
|
/* Fall */
|
|
|
|
case WDIOC_GETTIMEOUT:
|
|
return put_user(timeout, uarg.i);
|
|
|
|
default:
|
|
return -ENOTTY;
|
|
|
|
}
|
|
}
|
|
|
|
static int wdt977_notify_sys(struct notifier_block *this, unsigned long code,
|
|
void *unused)
|
|
{
|
|
if (code == SYS_DOWN || code == SYS_HALT)
|
|
wdt977_stop();
|
|
return NOTIFY_DONE;
|
|
}
|
|
|
|
static const struct file_operations wdt977_fops = {
|
|
.owner = THIS_MODULE,
|
|
.llseek = no_llseek,
|
|
.write = wdt977_write,
|
|
.unlocked_ioctl = wdt977_ioctl,
|
|
.open = wdt977_open,
|
|
.release = wdt977_release,
|
|
};
|
|
|
|
static struct miscdevice wdt977_miscdev = {
|
|
.minor = WATCHDOG_MINOR,
|
|
.name = "watchdog",
|
|
.fops = &wdt977_fops,
|
|
};
|
|
|
|
static struct notifier_block wdt977_notifier = {
|
|
.notifier_call = wdt977_notify_sys,
|
|
};
|
|
|
|
static int __init wd977_init(void)
|
|
{
|
|
int rc;
|
|
|
|
pr_info("driver v%s\n", WATCHDOG_VERSION);
|
|
|
|
/* Check that the timeout value is within its range;
|
|
if not reset to the default */
|
|
if (wdt977_set_timeout(timeout)) {
|
|
wdt977_set_timeout(DEFAULT_TIMEOUT);
|
|
pr_info("timeout value must be 60 < timeout < 15300, using %d\n",
|
|
DEFAULT_TIMEOUT);
|
|
}
|
|
|
|
/* on Netwinder the IOports are already reserved by
|
|
* arch/arm/mach-footbridge/netwinder-hw.c
|
|
*/
|
|
if (!machine_is_netwinder()) {
|
|
if (!request_region(IO_INDEX_PORT, 2, WATCHDOG_NAME)) {
|
|
pr_err("I/O address 0x%04x already in use\n",
|
|
IO_INDEX_PORT);
|
|
rc = -EIO;
|
|
goto err_out;
|
|
}
|
|
}
|
|
|
|
rc = register_reboot_notifier(&wdt977_notifier);
|
|
if (rc) {
|
|
pr_err("cannot register reboot notifier (err=%d)\n", rc);
|
|
goto err_out_region;
|
|
}
|
|
|
|
rc = misc_register(&wdt977_miscdev);
|
|
if (rc) {
|
|
pr_err("cannot register miscdev on minor=%d (err=%d)\n",
|
|
wdt977_miscdev.minor, rc);
|
|
goto err_out_reboot;
|
|
}
|
|
|
|
pr_info("initialized. timeout=%d sec (nowayout=%d, testmode=%i)\n",
|
|
timeout, nowayout, testmode);
|
|
|
|
return 0;
|
|
|
|
err_out_reboot:
|
|
unregister_reboot_notifier(&wdt977_notifier);
|
|
err_out_region:
|
|
if (!machine_is_netwinder())
|
|
release_region(IO_INDEX_PORT, 2);
|
|
err_out:
|
|
return rc;
|
|
}
|
|
|
|
static void __exit wd977_exit(void)
|
|
{
|
|
wdt977_stop();
|
|
misc_deregister(&wdt977_miscdev);
|
|
unregister_reboot_notifier(&wdt977_notifier);
|
|
release_region(IO_INDEX_PORT, 2);
|
|
}
|
|
|
|
module_init(wd977_init);
|
|
module_exit(wd977_exit);
|
|
|
|
MODULE_AUTHOR("Woody Suwalski <woodys@xandros.com>");
|
|
MODULE_DESCRIPTION("W83977AF Watchdog driver");
|
|
MODULE_LICENSE("GPL");
|