1
0
Fork 0
alistair23-linux/net/l2tp
Xin Long f8504f4ca0 l2tp: fix a sock refcnt leak in l2tp_tunnel_register
This issue happens when trying to add an existent tunnel. It
doesn't call sock_put() before returning -EEXIST to release
the sock refcnt that was held by calling sock_hold() before
the existence check.

This patch is to fix it by holding the sock after doing the
existence check.

Fixes: f6cd651b05 ("l2tp: fix race in duplicate tunnel detection")
Reported-by: Jianlin Shi <jishi@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-11-14 22:49:31 -08:00
..
Kconfig l2tp: Call udp_sock_create 2014-07-14 16:12:15 -07:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
l2tp_core.c l2tp: fix a sock refcnt leak in l2tp_tunnel_register 2018-11-14 22:49:31 -08:00
l2tp_core.h l2tp: fix unused function warning 2018-08-13 20:45:49 -07:00
l2tp_debugfs.c l2tp: ignore L2TP_ATTR_MTU 2018-08-03 10:03:57 -07:00
l2tp_eth.c l2tp: fix unused function warning 2018-08-13 20:45:49 -07:00
l2tp_ip.c l2tp: split l2tp_session_get() 2018-08-11 12:13:49 -07:00
l2tp_ip6.c l2tp: split l2tp_session_get() 2018-08-11 12:13:49 -07:00
l2tp_netlink.c l2tp: split l2tp_session_get() 2018-08-11 12:13:49 -07:00
l2tp_ppp.c l2tp: fix unused function warning 2018-08-13 20:45:49 -07:00