David Ahern 75270f8196 ipv6: fib6_select_path can not use out path for nexthop objects ... [ Upstream commit 34fe5a1cf9 ] Brian reported a crash in IPv6 code when using rpfilter with a setup running FRR and external nexthop objects. The root cause of the crash is fib6_select_path setting fib6_nh in the result to NULL because of an improper check for nexthop objects. More specifically, rpfilter invokes ip6_route_lookup with flowi6_oif set causing fib6_select_path to be called with have_oif_match set. fib6_select_path has early check on have_oif_match and jumps to the out label which presumes a builtin fib6_nh. This path is invalid for nexthop objects; for external nexthops fib6_select_path needs to just return if the fib6_nh has already been set in the result otherwise it returns after the call to nexthop_path_fib6_result. Update the check on have_oif_match to not bail on external nexthops. Update selftests for this problem. Fixes: f88d8ea67f ("ipv6: Plumb support for nexthop object in a fib6_info") Reported-by: Brian Rak <brak@choopa.com> Signed-off-by: David Ahern <dsahern@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-07-22 09:32:47 +02:00
..
ila	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netfilter	netfilter: drop bridge nf reset from nf_reset	2019-10-01 18:42:15 +02:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	xfrm: make xfrm modes builtin	2019-04-08 09:15:17 +02:00
addrconf.c	ipv6: don't auto-add link-local address to lag ports	2020-04-13 10:48:02 +02:00
addrconf_core.c	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2019-12-18 16:08:42 +01:00
addrlabel.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
af_inet6.c	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2019-12-18 16:08:42 +01:00
ah6.c	ipv6: Use ipv6_authlen for len	2019-07-11 14:43:25 -07:00
anycast.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
calipso.c	netlabel: cope with NULL catmap	2020-05-20 08:20:08 +02:00
datagram.c	net: ipv6: add net argument to ip6_dst_lookup_flow	2019-12-18 16:08:40 +01:00
esp6.c	xfrm: remove get_mtu indirection from xfrm_type	2019-07-01 06:16:40 +02:00
esp6_offload.c	esp6: get the right proto for transport mode in esp6_gso_encap	2020-06-03 08:21:35 +02:00
exthdrs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
exthdrs_core.c	ipv6: remove printk	2019-07-27 14:23:48 -07:00
exthdrs_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
fib6_notifier.c	net: Add module reference to FIB notifiers	2017-09-01 20:33:42 -07:00
fib6_rules.c	ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule	2019-09-26 09:34:25 +02:00
fou6.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
icmp.c	ipv6: icmp: allow flowlabel reflection in echo replies	2019-07-01 10:54:51 -07:00
inet6_connection_sock.c	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2020-01-04 19:18:58 +01:00
inet6_hashtables.c	net: annotate accesses to sk->sk_incoming_cpu	2019-10-30 13:24:25 -07:00
ip6_checksum.c	net: udp: fix handling of CHECKSUM_COMPLETE packets	2018-10-24 14:18:16 -07:00
ip6_fib.c	net: don't return invalid table id error when we fall back to PF_UNSPEC	2020-06-03 08:20:41 +02:00
ip6_flowlabel.c	ipv6: fix static key imbalance in fl_create()	2019-07-11 14:43:25 -07:00
ip6_gre.c	ip6_gre: fix use-after-free in ip6gre_tunnel_lookup()	2020-06-30 15:36:46 -04:00
ip6_icmp.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ip6_input.c	ipv6: drop incoming packets having a v4mapped source address	2019-10-03 11:40:21 -04:00
ip6_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ip6_offload.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ip6_output.c	net: ipv6: add net argument to ip6_dst_lookup_flow	2019-12-18 16:08:40 +01:00
ip6_tunnel.c	net, ip6_tunnel: fix namespaces move	2020-01-29 16:45:20 +01:00
ip6_udp_tunnel.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
ip6_vti.c	vti6: Fix memory leak of skb if input policy check fails	2020-04-01 11:02:12 +02:00
ip6mr.c	net: don't return invalid table id error when we fall back to PF_UNSPEC	2020-06-03 08:20:41 +02:00
ipcomp6.c	xfrm: remove type and offload_type map from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
ipv6_sockglue.c	ipv6: fix IPV6_ADDRFORM operation logic	2020-06-17 16:40:19 +02:00
mcast.c	mld: fix memory leak in ipv6_mc_destroy_dev()	2020-06-30 15:36:43 -04:00
mcast_snoop.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 343	2019-06-05 17:37:07 +02:00
mip6.c	xfrm: remove type and offload_type map from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
ndisc.c	net-ipv6-ndisc: add support for RFC7710 RA Captive Portal Identifier	2019-07-22 12:10:54 -07:00
netfilter.c	net: ensure correct skb->tstamp in various fragmenters	2019-10-18 10:02:37 -07:00
output_core.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
ping.c	ipv6: Fix the link time qualifier of 'ping_v6_proc_exit_net()'	2019-09-12 11:20:33 +01:00
proc.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-07 11:00:14 -07:00
protocol.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
raw.c	net: ipv6: add net argument to ip6_dst_lookup_flow	2019-12-18 16:08:40 +01:00
reassembly.c	inet: frags: re-introduce skb coalescing for local delivery	2019-08-08 15:55:10 -07:00
route.c	ipv6: fib6_select_path can not use out path for nexthop objects	2020-07-22 09:32:47 +02:00
seg6.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
seg6_hmac.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
seg6_iptunnel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
seg6_local.c	ipv6: sr: remove SKB_GSO_IPXIP6 on End.D* actions	2020-01-29 16:45:20 +01:00
sit.c	sit: do not confirm neighbor when do pmtu update	2020-01-04 19:19:04 +01:00
syncookies.c	net: ipv6: add net argument to ip6_dst_lookup_flow	2019-12-18 16:08:40 +01:00
sysctl_net_ipv6.c	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
tcp_ipv6.c	net: ipv6: add net argument to ip6_dst_lookup_flow	2019-12-18 16:08:40 +01:00
tcpv6_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tunnel6.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
udp.c	net: annotate accesses to sk->sk_incoming_cpu	2019-10-30 13:24:25 -07:00
udp_impl.h	udp6: add missing rehash callback to udplite	2019-01-17 15:01:08 -08:00
udp_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
udplite.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xfrm6_input.c	net: use skb_sec_path helper in more places	2018-12-19 11:21:37 -08:00
xfrm6_output.c	xfrm: Always set XFRM_TRANSFORMED in xfrm{4,6}_output_finish	2020-04-29 16:33:11 +02:00
xfrm6_policy.c	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2020-01-04 19:18:58 +01:00
xfrm6_protocol.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xfrm6_state.c	xfrm: remove eth_proto value from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
xfrm6_tunnel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00